From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [PATCH 1/2] rtc: goldfish: Fix return value of goldfish_rtc_probe()
Date: Sat, 23 May 2020 21:50:06 +0200 [thread overview]
Message-ID: <20200523195006.GB3429@piout.net> (raw)
In-Reply-To: <1590227782-32249-1-git-send-email-yangtiezhu@loongson.cn>
Hi,
On 23/05/2020 17:56:21+0800, Tiezhu Yang wrote:
> When call function devm_platform_ioremap_resource(), we should use IS_ERR()
> to check the return value and return PTR_ERR() if failed.
>
> Fixes: 89576bebbc17 ("rtc: Use devm_platform_ioremap_resource()")
This doesn't fix an issue and it was anyway not introduced by that
commit. Please correct your commit message and subject.
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
> drivers/rtc/rtc-goldfish.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-goldfish.c b/drivers/rtc/rtc-goldfish.c
> index cb6b0ad..2779715 100644
> --- a/drivers/rtc/rtc-goldfish.c
> +++ b/drivers/rtc/rtc-goldfish.c
> @@ -174,7 +174,7 @@ static int goldfish_rtc_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, rtcdrv);
> rtcdrv->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(rtcdrv->base))
> - return -ENODEV;
> + return PTR_ERR(rtcdrv->base);
>
> rtcdrv->irq = platform_get_irq(pdev, 0);
> if (rtcdrv->irq < 0)
> --
> 2.1.0
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-05-23 19:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-23 9:56 [PATCH 1/2] rtc: goldfish: Fix return value of goldfish_rtc_probe() Tiezhu Yang
2020-05-23 9:56 ` [PATCH 2/2] rtc: mpc5121: Fix return value of mpc5121_rtc_probe() Tiezhu Yang
2020-05-23 19:51 ` Alexandre Belloni
2020-05-23 19:50 ` Alexandre Belloni [this message]
2020-05-25 1:27 ` [PATCH 1/2] rtc: goldfish: Fix return value of goldfish_rtc_probe() Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200523195006.GB3429@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.