All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] media: exynos4-is: Fix runtime PM imbalance in isp_video_open
@ 2020-05-24  3:34 ` Dinghao Liu
  0 siblings, 0 replies; 4+ messages in thread
From: Dinghao Liu @ 2020-05-24  3:34 UTC (permalink / raw)
  To: dinghao.liu, kjlu
  Cc: Kyungmin Park, Sylwester Nawrocki, Mauro Carvalho Chehab,
	Kukjin Kim, Krzysztof Kozlowski, linux-media, linux-arm-kernel,
	linux-samsung-soc, linux-kernel

pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code. Thus a pairing decrement is needed on
the error handling path to keep the counter balanced.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
---
 drivers/media/platform/exynos4-is/fimc-isp-video.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/exynos4-is/fimc-isp-video.c b/drivers/media/platform/exynos4-is/fimc-isp-video.c
index 15f443fa7208..612b9872afc8 100644
--- a/drivers/media/platform/exynos4-is/fimc-isp-video.c
+++ b/drivers/media/platform/exynos4-is/fimc-isp-video.c
@@ -293,6 +293,7 @@ static int isp_video_open(struct file *file)
 	if (!ret)
 		goto unlock;
 rel_fh:
+	pm_runtime_put_noidle(&isp->pdev->dev);
 	v4l2_fh_release(file);
 unlock:
 	mutex_unlock(&isp->video_lock);
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] media: exynos4-is: Fix runtime PM imbalance in isp_video_open
@ 2020-05-24  3:34 ` Dinghao Liu
  0 siblings, 0 replies; 4+ messages in thread
From: Dinghao Liu @ 2020-05-24  3:34 UTC (permalink / raw)
  To: dinghao.liu, kjlu
  Cc: linux-samsung-soc, linux-kernel, Krzysztof Kozlowski,
	Kyungmin Park, Kukjin Kim, Sylwester Nawrocki,
	Mauro Carvalho Chehab, linux-arm-kernel, linux-media

pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code. Thus a pairing decrement is needed on
the error handling path to keep the counter balanced.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
---
 drivers/media/platform/exynos4-is/fimc-isp-video.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/exynos4-is/fimc-isp-video.c b/drivers/media/platform/exynos4-is/fimc-isp-video.c
index 15f443fa7208..612b9872afc8 100644
--- a/drivers/media/platform/exynos4-is/fimc-isp-video.c
+++ b/drivers/media/platform/exynos4-is/fimc-isp-video.c
@@ -293,6 +293,7 @@ static int isp_video_open(struct file *file)
 	if (!ret)
 		goto unlock;
 rel_fh:
+	pm_runtime_put_noidle(&isp->pdev->dev);
 	v4l2_fh_release(file);
 unlock:
 	mutex_unlock(&isp->video_lock);
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] media: exynos4-is: Fix runtime PM imbalance in isp_video_open
  2020-05-24  3:34 ` Dinghao Liu
@ 2020-05-25  8:40   ` Sylwester Nawrocki
  -1 siblings, 0 replies; 4+ messages in thread
From: Sylwester Nawrocki @ 2020-05-25  8:40 UTC (permalink / raw)
  To: Dinghao Liu, kjlu
  Cc: linux-samsung-soc, linux-kernel, Krzysztof Kozlowski,
	Kyungmin Park, Kukjin Kim, Sylwester Nawrocki,
	Mauro Carvalho Chehab, linux-arm-kernel, linux-media

On 5/24/20 05:34, Dinghao Liu wrote:
> pm_runtime_get_sync() increments the runtime PM usage counter even
> when it returns an error code. Thus a pairing decrement is needed on
> the error handling path to keep the counter balanced.
> 
> Signed-off-by: Dinghao Liu<dinghao.liu@zju.edu.cn>

Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] media: exynos4-is: Fix runtime PM imbalance in isp_video_open
@ 2020-05-25  8:40   ` Sylwester Nawrocki
  0 siblings, 0 replies; 4+ messages in thread
From: Sylwester Nawrocki @ 2020-05-25  8:40 UTC (permalink / raw)
  To: Dinghao Liu, kjlu
  Cc: linux-samsung-soc, linux-kernel, Krzysztof Kozlowski,
	Kyungmin Park, Kukjin Kim, Sylwester Nawrocki,
	Mauro Carvalho Chehab, linux-arm-kernel, linux-media

On 5/24/20 05:34, Dinghao Liu wrote:
> pm_runtime_get_sync() increments the runtime PM usage counter even
> when it returns an error code. Thus a pairing decrement is needed on
> the error handling path to keep the counter balanced.
> 
> Signed-off-by: Dinghao Liu<dinghao.liu@zju.edu.cn>

Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-05-25  8:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-24  3:34 [PATCH] media: exynos4-is: Fix runtime PM imbalance in isp_video_open Dinghao Liu
2020-05-24  3:34 ` Dinghao Liu
2020-05-25  8:40 ` Sylwester Nawrocki
2020-05-25  8:40   ` Sylwester Nawrocki

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.