From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80475C433DF for ; Sun, 24 May 2020 11:36:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5371B2075F for ; Sun, 24 May 2020 11:36:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mWGtXYAZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728382AbgEXLgZ (ORCPT ); Sun, 24 May 2020 07:36:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726734AbgEXLgY (ORCPT ); Sun, 24 May 2020 07:36:24 -0400 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B96BEC061A0E for ; Sun, 24 May 2020 04:36:24 -0700 (PDT) Received: by mail-pl1-x641.google.com with SMTP id t16so6387023plo.7 for ; Sun, 24 May 2020 04:36:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:user-agent; bh=OzC1cpXNW9KBgR0mwrAtmdi+yItcgjZnfiOPXDFp23M=; b=mWGtXYAZgPloy/PcX8td9tpO0s+U5SlTnLflaLN82KZ0wteS3RypAvV/8X+/VOXbM8 JCo8rJ5VHiuLk99CD3ElLAUvVfpaGbKXGL1s624kPOLx4+SFe4AlegguFYEM+7Za3HS8 v0pZ7p9RZpqcW2GNjMFdoqqSLagW3fRtBApUdnjlJvlHmLeZHK17YxAYiPn3qgkw1KHI xc9HZ4vsakDxat0jkO5w1K7dLy+pV7Ew3wpazZHVpmMWUspVoXSsoSE/MleO1yZYh1W6 UAf9VEIzr7asP6ZIN1Wsv6LBnsvlKvXJvjjkQ4ClHHed8JREfpIItOrtt93jcM3hrXvz 58OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:user-agent; bh=OzC1cpXNW9KBgR0mwrAtmdi+yItcgjZnfiOPXDFp23M=; b=lPcYRyIZQvEZhewaw9/NCuDbzX/j6th1uXnTzauvCqZCGqU7CQ0z9KRjtKsEaz5OHO wCUyRIVIhZ4qY2dXBKw2+Qe1ln2jT4UhSgmdGRpECbFBrqyxBzrgEcPBvfJvGtPVhvY0 HlBUqk0eASf6tLP5I6pVL3YnCV1zhp67aagETLwMPDHKlw4XTQr90W8+PX3hrfnzoml0 I930K6uA6i0XBm3NtaJylqVUEkRrPDlXJtblmAJR6Pf9wBQhxhSWjaJs7B1p5zVbZhtw z/KRW3ACRf81fMY9Rvq4nTeKWziwteUJdk7qoIqM/BXwUT469yz3TJmYNtrI3n71g2+e ZqRg== X-Gm-Message-State: AOAM5310/reoSi2AQwqIjFQYLladvyBAwGBymSYKup+AmyJTnGKryr43 nfjhK2vnaqcQM2H3y61fTzfYvzlI2oQ= X-Google-Smtp-Source: ABdhPJwZGEO+StBipy4P9Mw+5nSi+vbSv8EhI7Hhmu+ABSs//I9kMDy6Vq9YROqshYB085U/ukxdWA== X-Received: by 2002:a17:90a:1aa3:: with SMTP id p32mr15642918pjp.4.1590320184145; Sun, 24 May 2020 04:36:24 -0700 (PDT) Received: from xebrium.com ([182.70.106.85]) by smtp.gmail.com with ESMTPSA id 62sm10871174pfc.204.2020.05.24.04.36.21 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 24 May 2020 04:36:23 -0700 (PDT) Date: Sun, 24 May 2020 17:06:18 +0530 From: Gaurav Pathak To: abbotti@mev.co.uk, gregkh@linuxfoundation.org, hsweeten@visionengravers.com Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Subject: [PATCH] Removing ununsed variable int lo, hi, int data and int i from comedi/drivers/dt2814.c. Message-ID: <20200524113613.GA19734@xebrium.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Silence following sparse warning: drivers/staging/comedi/drivers/dt2814.c: In function ‘dt2814_interrupt’: drivers/staging/comedi/drivers/dt2814.c:193:6: warning: variable ‘data’ set but not used [-Wunused-but-set-variable] int data; ^~~~ drivers/staging/comedi/drivers/dt2814.c: In function ‘dt2814_attach’: drivers/staging/comedi/drivers/dt2814.c:232:6: warning: variable ‘i’ set but not used [-Wunused-but-set-variable] int i; ^ Signed-off-by: Gaurav Pathak --- drivers/staging/comedi/drivers/dt2814.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/comedi/drivers/dt2814.c b/drivers/staging/comedi/drivers/dt2814.c index d2c715737361..eea587d63e18 100644 --- a/drivers/staging/comedi/drivers/dt2814.c +++ b/drivers/staging/comedi/drivers/dt2814.c @@ -186,22 +186,15 @@ static int dt2814_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s) static irqreturn_t dt2814_interrupt(int irq, void *d) { - int lo, hi; struct comedi_device *dev = d; struct dt2814_private *devpriv = dev->private; struct comedi_subdevice *s = dev->read_subdev; - int data; if (!dev->attached) { dev_err(dev->class_dev, "spurious interrupt\n"); return IRQ_HANDLED; } - hi = inb(dev->iobase + DT2814_DATA); - lo = inb(dev->iobase + DT2814_DATA); - - data = (hi << 4) | (lo >> 4); - if (!(--devpriv->ntrig)) { int i; @@ -229,7 +222,6 @@ static int dt2814_attach(struct comedi_device *dev, struct comedi_devconfig *it) struct dt2814_private *devpriv; struct comedi_subdevice *s; int ret; - int i; ret = comedi_request_region(dev, it->options[0], 0x2); if (ret) @@ -241,8 +233,6 @@ static int dt2814_attach(struct comedi_device *dev, struct comedi_devconfig *it) dev_err(dev->class_dev, "reset error (fatal)\n"); return -EIO; } - i = inb(dev->iobase + DT2814_DATA); - i = inb(dev->iobase + DT2814_DATA); if (it->options[1]) { ret = request_irq(it->options[1], dt2814_interrupt, 0, -- 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F803C433E0 for ; Sun, 24 May 2020 11:36:29 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A42D2075F for ; Sun, 24 May 2020 11:36:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mWGtXYAZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A42D2075F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id ED51221FEF; Sun, 24 May 2020 11:36:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yLBt2rB9Sm4b; Sun, 24 May 2020 11:36:26 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 884CE20410; Sun, 24 May 2020 11:36:26 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 8C2271BF419 for ; Sun, 24 May 2020 11:36:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 8906C868BD for ; Sun, 24 May 2020 11:36:25 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BoFhnudYY-5w for ; Sun, 24 May 2020 11:36:24 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 887EA86739 for ; Sun, 24 May 2020 11:36:24 +0000 (UTC) Received: by mail-pl1-f195.google.com with SMTP id w19so6374597ply.11 for ; Sun, 24 May 2020 04:36:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:user-agent; bh=OzC1cpXNW9KBgR0mwrAtmdi+yItcgjZnfiOPXDFp23M=; b=mWGtXYAZgPloy/PcX8td9tpO0s+U5SlTnLflaLN82KZ0wteS3RypAvV/8X+/VOXbM8 JCo8rJ5VHiuLk99CD3ElLAUvVfpaGbKXGL1s624kPOLx4+SFe4AlegguFYEM+7Za3HS8 v0pZ7p9RZpqcW2GNjMFdoqqSLagW3fRtBApUdnjlJvlHmLeZHK17YxAYiPn3qgkw1KHI xc9HZ4vsakDxat0jkO5w1K7dLy+pV7Ew3wpazZHVpmMWUspVoXSsoSE/MleO1yZYh1W6 UAf9VEIzr7asP6ZIN1Wsv6LBnsvlKvXJvjjkQ4ClHHed8JREfpIItOrtt93jcM3hrXvz 58OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:user-agent; bh=OzC1cpXNW9KBgR0mwrAtmdi+yItcgjZnfiOPXDFp23M=; b=H0e9nKI1FSv/pwJjE/YHGoGsRASNzl8dGM0V0TOMPG5y5WJpCqpmqkLX+9OrpoU3nB 8OtXB/jhFzqTGmRCk4+8Xg21AIPXl1sEqNvuUBSUjJ1gDsWolU7uQQl0rKMpiafBKBgb f7ybHA2DUkqRSG7ugU3M7c9Q5/pYY+2k3S0STO1uLAExHdPjrXVhOqaepKrktReEoOgn /ANzatb1oM1JPGmfMN3+JjE31T6SIIgLzoklsikxdHPTdcoNrCY0E3GnixPvnLQY4Asc O3HH/m/qNZxxpfu3ZMYzl77wwksulJp8FI9rKRTXB+Wco4vxzoF+u3G4arsDxSacKlPd i83w== X-Gm-Message-State: AOAM533s7dLWDMoM7BdEWBU4h2suZ8yoMCcKWJt6vEirKL64j4mKgTIu iMOc5u8zqMdMLxyP29mC5W8= X-Google-Smtp-Source: ABdhPJwZGEO+StBipy4P9Mw+5nSi+vbSv8EhI7Hhmu+ABSs//I9kMDy6Vq9YROqshYB085U/ukxdWA== X-Received: by 2002:a17:90a:1aa3:: with SMTP id p32mr15642918pjp.4.1590320184145; Sun, 24 May 2020 04:36:24 -0700 (PDT) Received: from xebrium.com ([182.70.106.85]) by smtp.gmail.com with ESMTPSA id 62sm10871174pfc.204.2020.05.24.04.36.21 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 24 May 2020 04:36:23 -0700 (PDT) Date: Sun, 24 May 2020 17:06:18 +0530 From: Gaurav Pathak To: abbotti@mev.co.uk, gregkh@linuxfoundation.org, hsweeten@visionengravers.com Subject: [PATCH] Removing ununsed variable int lo, hi, int data and int i from comedi/drivers/dt2814.c. Message-ID: <20200524113613.GA19734@xebrium.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" U2lsZW5jZSBmb2xsb3dpbmcgc3BhcnNlIHdhcm5pbmc6CmRyaXZlcnMvc3RhZ2luZy9jb21lZGkv ZHJpdmVycy9kdDI4MTQuYzogSW4gZnVuY3Rpb24g4oCYZHQyODE0X2ludGVycnVwdOKAmToKZHJp dmVycy9zdGFnaW5nL2NvbWVkaS9kcml2ZXJzL2R0MjgxNC5jOjE5Mzo2OiB3YXJuaW5nOiB2YXJp YWJsZSDigJhkYXRh4oCZIHNldCBidXQgbm90IHVzZWQgWy1XdW51c2VkLWJ1dC1zZXQtdmFyaWFi bGVdCiAgaW50IGRhdGE7CiAgICAgIF5+fn4KZHJpdmVycy9zdGFnaW5nL2NvbWVkaS9kcml2ZXJz L2R0MjgxNC5jOiBJbiBmdW5jdGlvbiDigJhkdDI4MTRfYXR0YWNo4oCZOgpkcml2ZXJzL3N0YWdp bmcvY29tZWRpL2RyaXZlcnMvZHQyODE0LmM6MjMyOjY6IHdhcm5pbmc6IHZhcmlhYmxlIOKAmGni gJkgc2V0IGJ1dCBub3QgdXNlZCBbLVd1bnVzZWQtYnV0LXNldC12YXJpYWJsZV0KICBpbnQgaTsK ICAgICAgXgoKU2lnbmVkLW9mZi1ieTogR2F1cmF2IFBhdGhhayA8Z2F1cmF2cGF0aGFrMTI5QGdt YWlsLmNvbT4KLS0tCiBkcml2ZXJzL3N0YWdpbmcvY29tZWRpL2RyaXZlcnMvZHQyODE0LmMgfCAx MCAtLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvZHJpdmVycy9zdGFnaW5nL2NvbWVkaS9kcml2ZXJzL2R0MjgxNC5jIGIvZHJpdmVycy9zdGFn aW5nL2NvbWVkaS9kcml2ZXJzL2R0MjgxNC5jCmluZGV4IGQyYzcxNTczNzM2MS4uZWVhNTg3ZDYz ZTE4IDEwMDY0NAotLS0gYS9kcml2ZXJzL3N0YWdpbmcvY29tZWRpL2RyaXZlcnMvZHQyODE0LmMK KysrIGIvZHJpdmVycy9zdGFnaW5nL2NvbWVkaS9kcml2ZXJzL2R0MjgxNC5jCkBAIC0xODYsMjIg KzE4NiwxNSBAQCBzdGF0aWMgaW50IGR0MjgxNF9haV9jbWQoc3RydWN0IGNvbWVkaV9kZXZpY2Ug KmRldiwgc3RydWN0IGNvbWVkaV9zdWJkZXZpY2UgKnMpCiAKIHN0YXRpYyBpcnFyZXR1cm5fdCBk dDI4MTRfaW50ZXJydXB0KGludCBpcnEsIHZvaWQgKmQpCiB7Ci0JaW50IGxvLCBoaTsKIAlzdHJ1 Y3QgY29tZWRpX2RldmljZSAqZGV2ID0gZDsKIAlzdHJ1Y3QgZHQyODE0X3ByaXZhdGUgKmRldnBy aXYgPSBkZXYtPnByaXZhdGU7CiAJc3RydWN0IGNvbWVkaV9zdWJkZXZpY2UgKnMgPSBkZXYtPnJl YWRfc3ViZGV2OwotCWludCBkYXRhOwogCiAJaWYgKCFkZXYtPmF0dGFjaGVkKSB7CiAJCWRldl9l cnIoZGV2LT5jbGFzc19kZXYsICJzcHVyaW91cyBpbnRlcnJ1cHRcbiIpOwogCQlyZXR1cm4gSVJR X0hBTkRMRUQ7CiAJfQogCi0JaGkgPSBpbmIoZGV2LT5pb2Jhc2UgKyBEVDI4MTRfREFUQSk7Ci0J bG8gPSBpbmIoZGV2LT5pb2Jhc2UgKyBEVDI4MTRfREFUQSk7Ci0KLQlkYXRhID0gKGhpIDw8IDQp IHwgKGxvID4+IDQpOwotCiAJaWYgKCEoLS1kZXZwcml2LT5udHJpZykpIHsKIAkJaW50IGk7CiAK QEAgLTIyOSw3ICsyMjIsNiBAQCBzdGF0aWMgaW50IGR0MjgxNF9hdHRhY2goc3RydWN0IGNvbWVk aV9kZXZpY2UgKmRldiwgc3RydWN0IGNvbWVkaV9kZXZjb25maWcgKml0KQogCXN0cnVjdCBkdDI4 MTRfcHJpdmF0ZSAqZGV2cHJpdjsKIAlzdHJ1Y3QgY29tZWRpX3N1YmRldmljZSAqczsKIAlpbnQg cmV0OwotCWludCBpOwogCiAJcmV0ID0gY29tZWRpX3JlcXVlc3RfcmVnaW9uKGRldiwgaXQtPm9w dGlvbnNbMF0sIDB4Mik7CiAJaWYgKHJldCkKQEAgLTI0MSw4ICsyMzMsNiBAQCBzdGF0aWMgaW50 IGR0MjgxNF9hdHRhY2goc3RydWN0IGNvbWVkaV9kZXZpY2UgKmRldiwgc3RydWN0IGNvbWVkaV9k ZXZjb25maWcgKml0KQogCQlkZXZfZXJyKGRldi0+Y2xhc3NfZGV2LCAicmVzZXQgZXJyb3IgKGZh dGFsKVxuIik7CiAJCXJldHVybiAtRUlPOwogCX0KLQlpID0gaW5iKGRldi0+aW9iYXNlICsgRFQy ODE0X0RBVEEpOwotCWkgPSBpbmIoZGV2LT5pb2Jhc2UgKyBEVDI4MTRfREFUQSk7CiAKIAlpZiAo aXQtPm9wdGlvbnNbMV0pIHsKIAkJcmV0ID0gcmVxdWVzdF9pcnEoaXQtPm9wdGlvbnNbMV0sIGR0 MjgxNF9pbnRlcnJ1cHQsIDAsCi0tIAoyLjE3LjEKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmRldmVsIG1haWxpbmcgbGlzdApkZXZlbEBsaW51eGRyaXZl cnByb2plY3Qub3JnCmh0dHA6Ly9kcml2ZXJkZXYubGludXhkcml2ZXJwcm9qZWN0Lm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaXZlcmRldi1kZXZlbAo=