From: Pavel Machek <pavel@denx.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
Michal Kubecek <mkubecek@suse.cz>, Marek Vasut <marex@denx.de>,
Florian Fainelli <f.fainelli@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
mkl@pengutronix.de, kernel@pengutronix.de,
David Jander <david@protonic.nl>,
Jakub Kicinski <kuba@kernel.org>,
Christian Herber <christian.herber@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: signal quality and cable diagnostic
Date: Sun, 24 May 2020 23:28:36 +0200 [thread overview]
Message-ID: <20200524212836.GE1192@bug> (raw)
In-Reply-To: <20200512130418.GF409897@lunn.ch>
On Tue 2020-05-12 15:04:18, Andrew Lunn wrote:
> > > As for getting / setting the threshold, perhaps ETHTOOL_MSG_LINKINFO_GET
> > > and ETHTOOL_MSG_LINKINFO_SET. Unless you expect more configurable
> > > parameters like this in which case we may want to consider adding new
> > > request type (e.g. link params or link management).
> >
> > Currently in my short term todo are:
> > - SQI
>
>
> > - PHY undervoltage
> > - PHY overtemerature
>
> Do you only have alarms? Or are current values available for voltage
> and temperature?
>
> Both of these would fit hwmon. It even has the option to set the alarm
> thresholds. The advantage of hwmon is that they are then just more
> sensors. You could even include the temperature sensor into a thermal zone to influence
> cooling. There are a couple of PHYs which already do hwmon, so there is code you can
> copy.
Yes, hwmon can do a lot of stuff. OTOH figuring out "what hwmon device corresponds to what
network device is going to be tricky, and Im not sure if we want utilities like mii-tool to
start using hwmon interfaces...
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2020-05-24 21:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 14:13 signal quality and cable diagnostic Oleksij Rempel
2020-05-11 14:33 ` Andrew Lunn
2020-05-12 8:22 ` Oleksij Rempel
2020-05-12 8:54 ` Robert Schwebel
2020-05-14 7:13 ` [EXT] " Christian Herber
2020-05-14 8:28 ` Oleksij Rempel
2020-05-11 14:59 ` Michal Kubecek
2020-05-12 6:48 ` Oleksij Rempel
2020-05-12 13:04 ` Andrew Lunn
2020-05-24 21:28 ` Pavel Machek [this message]
2020-05-26 7:06 ` PHYs with advanced cable diagnostic support Oleksij Rempel
2020-05-14 8:42 signal quality and cable diagnostic Christian Herber
2020-05-24 21:27 ` Pavel Machek
2020-05-24 22:42 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200524212836.GE1192@bug \
--to=pavel@denx.de \
--cc=andrew@lunn.ch \
--cc=christian.herber@nxp.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=david@protonic.nl \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marex@denx.de \
--cc=mkl@pengutronix.de \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.