All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v5 0/3] Add Caninos Loucos Labrador CoM and Base Board Device Tree
@ 2020-05-25  1:30 ` Matheus Castello
  0 siblings, 0 replies; 12+ messages in thread
From: Matheus Castello @ 2020-05-25  1:30 UTC (permalink / raw)
  To: afaerber, manivannan.sadhasivam, mark.rutland, robh+dt
  Cc: edgar.righi, igor.lima, linux-arm-kernel, devicetree,
	linux-kernel, linux-actions, Matheus Castello

Sorry for the delay.
Thanks Andreas, Mani and Rob for your time reviewing it.

Changes since v4:
(Suggested by Rob Herring)
- Fix issues with yaml indentation

Changes since v3:
(Suggested by Andreas Färber)
- Fix sort on actions.yaml
- Change the file owl-s500-labrador-bb.dts to owl-s500-labrador-base-m.dts
- Add description for both the SoM and Base Board
- Add Model description for both the SoM and Base Board

Matheus Castello (3):
  dt-bindings: Add vendor prefix for Caninos Loucos
  dt-bindings: arm: actions: Document Caninos Loucos Labrador
  ARM: dts: Add Caninos Loucos Labrador

 .../devicetree/bindings/arm/actions.yaml      |  5 +++
 .../devicetree/bindings/vendor-prefixes.yaml  |  2 ++
 arch/arm/boot/dts/Makefile                    |  1 +
 .../arm/boot/dts/owl-s500-labrador-base-m.dts | 34 +++++++++++++++++++
 arch/arm/boot/dts/owl-s500-labrador-v2.dtsi   | 22 ++++++++++++
 5 files changed, 64 insertions(+)
 create mode 100644 arch/arm/boot/dts/owl-s500-labrador-base-m.dts
 create mode 100644 arch/arm/boot/dts/owl-s500-labrador-v2.dtsi

--
2.26.2


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH v5 0/3] Add Caninos Loucos Labrador CoM and Base Board Device Tree
@ 2020-05-25  1:30 ` Matheus Castello
  0 siblings, 0 replies; 12+ messages in thread
From: Matheus Castello @ 2020-05-25  1:30 UTC (permalink / raw)
  To: afaerber, manivannan.sadhasivam, mark.rutland, robh+dt
  Cc: devicetree, Matheus Castello, linux-actions, linux-kernel,
	igor.lima, edgar.righi, linux-arm-kernel

Sorry for the delay.
Thanks Andreas, Mani and Rob for your time reviewing it.

Changes since v4:
(Suggested by Rob Herring)
- Fix issues with yaml indentation

Changes since v3:
(Suggested by Andreas Färber)
- Fix sort on actions.yaml
- Change the file owl-s500-labrador-bb.dts to owl-s500-labrador-base-m.dts
- Add description for both the SoM and Base Board
- Add Model description for both the SoM and Base Board

Matheus Castello (3):
  dt-bindings: Add vendor prefix for Caninos Loucos
  dt-bindings: arm: actions: Document Caninos Loucos Labrador
  ARM: dts: Add Caninos Loucos Labrador

 .../devicetree/bindings/arm/actions.yaml      |  5 +++
 .../devicetree/bindings/vendor-prefixes.yaml  |  2 ++
 arch/arm/boot/dts/Makefile                    |  1 +
 .../arm/boot/dts/owl-s500-labrador-base-m.dts | 34 +++++++++++++++++++
 arch/arm/boot/dts/owl-s500-labrador-v2.dtsi   | 22 ++++++++++++
 5 files changed, 64 insertions(+)
 create mode 100644 arch/arm/boot/dts/owl-s500-labrador-base-m.dts
 create mode 100644 arch/arm/boot/dts/owl-s500-labrador-v2.dtsi

--
2.26.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH v5 1/3] dt-bindings: Add vendor prefix for Caninos Loucos
  2020-05-25  1:30 ` Matheus Castello
@ 2020-05-25  1:30   ` Matheus Castello
  -1 siblings, 0 replies; 12+ messages in thread
From: Matheus Castello @ 2020-05-25  1:30 UTC (permalink / raw)
  To: afaerber, manivannan.sadhasivam, mark.rutland, robh+dt
  Cc: edgar.righi, igor.lima, linux-arm-kernel, devicetree,
	linux-kernel, linux-actions, Matheus Castello, Rob Herring

The Caninos Loucos Program develops Single Board Computers with an open
structure. The Program wants to form a community of developers to use
IoT technologies and disseminate the learning of embedded systems in
Brazil.

It is an initiative of the Technological Integrated Systems Laboratory
(LSI-TEC) with the support of Polytechnic School of the University of
São Paulo (Poli-USP) and Jon "Maddog" Hall.

Signed-off-by: Matheus Castello <matheus@castello.eng.br>
Acked-by: Rob Herring <robh@kernel.org>
Reviewed-by: Andreas Färber <afaerber@suse.de>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index d3891386d671..a20a05e3deaa 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -167,6 +167,8 @@ patternProperties:
     description: CALAO Systems SAS
   "^calxeda,.*":
     description: Calxeda
+  "^caninos,.*":
+    description: Caninos Loucos Program
   "^capella,.*":
     description: Capella Microsystems, Inc
   "^cascoda,.*":
--
2.26.2


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH v5 1/3] dt-bindings: Add vendor prefix for Caninos Loucos
@ 2020-05-25  1:30   ` Matheus Castello
  0 siblings, 0 replies; 12+ messages in thread
From: Matheus Castello @ 2020-05-25  1:30 UTC (permalink / raw)
  To: afaerber, manivannan.sadhasivam, mark.rutland, robh+dt
  Cc: Rob Herring, devicetree, Matheus Castello, linux-actions,
	linux-kernel, igor.lima, edgar.righi, linux-arm-kernel

The Caninos Loucos Program develops Single Board Computers with an open
structure. The Program wants to form a community of developers to use
IoT technologies and disseminate the learning of embedded systems in
Brazil.

It is an initiative of the Technological Integrated Systems Laboratory
(LSI-TEC) with the support of Polytechnic School of the University of
São Paulo (Poli-USP) and Jon "Maddog" Hall.

Signed-off-by: Matheus Castello <matheus@castello.eng.br>
Acked-by: Rob Herring <robh@kernel.org>
Reviewed-by: Andreas Färber <afaerber@suse.de>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index d3891386d671..a20a05e3deaa 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -167,6 +167,8 @@ patternProperties:
     description: CALAO Systems SAS
   "^calxeda,.*":
     description: Calxeda
+  "^caninos,.*":
+    description: Caninos Loucos Program
   "^capella,.*":
     description: Capella Microsystems, Inc
   "^cascoda,.*":
--
2.26.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH v5 2/3] dt-bindings: arm: actions: Document Caninos Loucos Labrador
  2020-05-25  1:30 ` Matheus Castello
@ 2020-05-25  1:30   ` Matheus Castello
  -1 siblings, 0 replies; 12+ messages in thread
From: Matheus Castello @ 2020-05-25  1:30 UTC (permalink / raw)
  To: afaerber, manivannan.sadhasivam, mark.rutland, robh+dt
  Cc: edgar.righi, igor.lima, linux-arm-kernel, devicetree,
	linux-kernel, linux-actions, Matheus Castello, Rob Herring

Update the documentation to add the Caninos Loucos Labrador. Labrador
project consists of a computer on module based on the Actions Semi S500
processor and the Labrador base board.

Signed-off-by: Matheus Castello <matheus@castello.eng.br>
Acked-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/arm/actions.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/actions.yaml b/Documentation/devicetree/bindings/arm/actions.yaml
index ace3fdaa8396..2187e1c5bc73 100644
--- a/Documentation/devicetree/bindings/arm/actions.yaml
+++ b/Documentation/devicetree/bindings/arm/actions.yaml
@@ -19,6 +19,11 @@ properties:
               - allo,sparky # Allo.com Sparky
               - cubietech,cubieboard6 # Cubietech CubieBoard6
           - const: actions,s500
+      - items:
+          - enum:
+              - caninos,labrador-v2 # Labrador Core v2
+              - caninos,labrador-base-m # Labrador Base Board M v1
+          - const: actions,s500
       - items:
           - enum:
               - lemaker,guitar-bb-rev-b # LeMaker Guitar Base Board rev. B
--
2.26.2


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH v5 2/3] dt-bindings: arm: actions: Document Caninos Loucos Labrador
@ 2020-05-25  1:30   ` Matheus Castello
  0 siblings, 0 replies; 12+ messages in thread
From: Matheus Castello @ 2020-05-25  1:30 UTC (permalink / raw)
  To: afaerber, manivannan.sadhasivam, mark.rutland, robh+dt
  Cc: Rob Herring, devicetree, Matheus Castello, linux-actions,
	linux-kernel, igor.lima, edgar.righi, linux-arm-kernel

Update the documentation to add the Caninos Loucos Labrador. Labrador
project consists of a computer on module based on the Actions Semi S500
processor and the Labrador base board.

Signed-off-by: Matheus Castello <matheus@castello.eng.br>
Acked-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/arm/actions.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/actions.yaml b/Documentation/devicetree/bindings/arm/actions.yaml
index ace3fdaa8396..2187e1c5bc73 100644
--- a/Documentation/devicetree/bindings/arm/actions.yaml
+++ b/Documentation/devicetree/bindings/arm/actions.yaml
@@ -19,6 +19,11 @@ properties:
               - allo,sparky # Allo.com Sparky
               - cubietech,cubieboard6 # Cubietech CubieBoard6
           - const: actions,s500
+      - items:
+          - enum:
+              - caninos,labrador-v2 # Labrador Core v2
+              - caninos,labrador-base-m # Labrador Base Board M v1
+          - const: actions,s500
       - items:
           - enum:
               - lemaker,guitar-bb-rev-b # LeMaker Guitar Base Board rev. B
--
2.26.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH v5 3/3] ARM: dts: Add Caninos Loucos Labrador
  2020-05-25  1:30 ` Matheus Castello
@ 2020-05-25  1:30   ` Matheus Castello
  -1 siblings, 0 replies; 12+ messages in thread
From: Matheus Castello @ 2020-05-25  1:30 UTC (permalink / raw)
  To: afaerber, manivannan.sadhasivam, mark.rutland, robh+dt
  Cc: edgar.righi, igor.lima, linux-arm-kernel, devicetree,
	linux-kernel, linux-actions, Matheus Castello

Add Device Trees for Caninos Loucos Labrador CoM and base board.
Based on the work of Andreas Färber on Lemaker Guitar device tree.

Signed-off-by: Matheus Castello <matheus@castello.eng.br>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Andreas Färber <afaerber@suse.de>
---
 arch/arm/boot/dts/Makefile                    |  1 +
 .../arm/boot/dts/owl-s500-labrador-base-m.dts | 34 +++++++++++++++++++
 arch/arm/boot/dts/owl-s500-labrador-v2.dtsi   | 22 ++++++++++++
 3 files changed, 57 insertions(+)
 create mode 100644 arch/arm/boot/dts/owl-s500-labrador-base-m.dts
 create mode 100644 arch/arm/boot/dts/owl-s500-labrador-v2.dtsi

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index e8dd99201397..0f8c1f255574 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -856,6 +856,7 @@ dtb-$(CONFIG_ARCH_ORION5X) += \
 dtb-$(CONFIG_ARCH_ACTIONS) += \
 	owl-s500-cubieboard6.dtb \
 	owl-s500-guitar-bb-rev-b.dtb \
+	owl-s500-labrador-base-m.dtb \
 	owl-s500-sparky.dtb
 dtb-$(CONFIG_ARCH_PRIMA2) += \
 	prima2-evb.dtb
diff --git a/arch/arm/boot/dts/owl-s500-labrador-base-m.dts b/arch/arm/boot/dts/owl-s500-labrador-base-m.dts
new file mode 100644
index 000000000000..044568fec25e
--- /dev/null
+++ b/arch/arm/boot/dts/owl-s500-labrador-base-m.dts
@@ -0,0 +1,34 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Caninos Labrador Base Board
+ *
+ * Copyright (c) 2019-2020 Matheus Castello
+ */
+
+/dts-v1/;
+
+#include "owl-s500-labrador-v2.dtsi"
+
+/ {
+	model = "Caninos Labrador Base-M v1.0a";
+	compatible = "caninos,labrador-base-m", "actions,s500";
+
+	aliases {
+		serial3 = &uart3;
+	};
+
+	chosen {
+		stdout-path = "serial3:115200n8";
+	};
+
+	uart3_clk: uart3-clk {
+		compatible = "fixed-clock";
+		clock-frequency = <921600>;
+		#clock-cells = <0>;
+	};
+};
+
+&uart3 {
+	status = "okay";
+	clocks = <&uart3_clk>;
+};
diff --git a/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi b/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
new file mode 100644
index 000000000000..883ff2f9886d
--- /dev/null
+++ b/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
@@ -0,0 +1,22 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Caninos Labrador SoM V2
+ *
+ * Copyright (c) 2019-2020 Matheus Castello
+ */
+
+#include "owl-s500.dtsi"
+
+/ {
+	model = "Caninos Labrador Core V2.1";
+	compatible = "caninos,labrador-v2", "actions,s500";
+
+	memory@0 {
+		device_type = "memory";
+		reg = <0x0 0x80000000>;
+	};
+};
+
+&timer {
+	clocks = <&hosc>;
+};
--
2.26.2


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH v5 3/3] ARM: dts: Add Caninos Loucos Labrador
@ 2020-05-25  1:30   ` Matheus Castello
  0 siblings, 0 replies; 12+ messages in thread
From: Matheus Castello @ 2020-05-25  1:30 UTC (permalink / raw)
  To: afaerber, manivannan.sadhasivam, mark.rutland, robh+dt
  Cc: devicetree, Matheus Castello, linux-actions, linux-kernel,
	igor.lima, edgar.righi, linux-arm-kernel

Add Device Trees for Caninos Loucos Labrador CoM and base board.
Based on the work of Andreas Färber on Lemaker Guitar device tree.

Signed-off-by: Matheus Castello <matheus@castello.eng.br>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Andreas Färber <afaerber@suse.de>
---
 arch/arm/boot/dts/Makefile                    |  1 +
 .../arm/boot/dts/owl-s500-labrador-base-m.dts | 34 +++++++++++++++++++
 arch/arm/boot/dts/owl-s500-labrador-v2.dtsi   | 22 ++++++++++++
 3 files changed, 57 insertions(+)
 create mode 100644 arch/arm/boot/dts/owl-s500-labrador-base-m.dts
 create mode 100644 arch/arm/boot/dts/owl-s500-labrador-v2.dtsi

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index e8dd99201397..0f8c1f255574 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -856,6 +856,7 @@ dtb-$(CONFIG_ARCH_ORION5X) += \
 dtb-$(CONFIG_ARCH_ACTIONS) += \
 	owl-s500-cubieboard6.dtb \
 	owl-s500-guitar-bb-rev-b.dtb \
+	owl-s500-labrador-base-m.dtb \
 	owl-s500-sparky.dtb
 dtb-$(CONFIG_ARCH_PRIMA2) += \
 	prima2-evb.dtb
diff --git a/arch/arm/boot/dts/owl-s500-labrador-base-m.dts b/arch/arm/boot/dts/owl-s500-labrador-base-m.dts
new file mode 100644
index 000000000000..044568fec25e
--- /dev/null
+++ b/arch/arm/boot/dts/owl-s500-labrador-base-m.dts
@@ -0,0 +1,34 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Caninos Labrador Base Board
+ *
+ * Copyright (c) 2019-2020 Matheus Castello
+ */
+
+/dts-v1/;
+
+#include "owl-s500-labrador-v2.dtsi"
+
+/ {
+	model = "Caninos Labrador Base-M v1.0a";
+	compatible = "caninos,labrador-base-m", "actions,s500";
+
+	aliases {
+		serial3 = &uart3;
+	};
+
+	chosen {
+		stdout-path = "serial3:115200n8";
+	};
+
+	uart3_clk: uart3-clk {
+		compatible = "fixed-clock";
+		clock-frequency = <921600>;
+		#clock-cells = <0>;
+	};
+};
+
+&uart3 {
+	status = "okay";
+	clocks = <&uart3_clk>;
+};
diff --git a/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi b/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
new file mode 100644
index 000000000000..883ff2f9886d
--- /dev/null
+++ b/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
@@ -0,0 +1,22 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Caninos Labrador SoM V2
+ *
+ * Copyright (c) 2019-2020 Matheus Castello
+ */
+
+#include "owl-s500.dtsi"
+
+/ {
+	model = "Caninos Labrador Core V2.1";
+	compatible = "caninos,labrador-v2", "actions,s500";
+
+	memory@0 {
+		device_type = "memory";
+		reg = <0x0 0x80000000>;
+	};
+};
+
+&timer {
+	clocks = <&hosc>;
+};
--
2.26.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH v5 2/3] dt-bindings: arm: actions: Document Caninos Loucos Labrador
  2020-05-25  1:30   ` Matheus Castello
@ 2020-05-25 10:41     ` Andreas Färber
  -1 siblings, 0 replies; 12+ messages in thread
From: Andreas Färber @ 2020-05-25 10:41 UTC (permalink / raw)
  To: Matheus Castello, manivannan.sadhasivam, robh+dt
  Cc: mark.rutland, edgar.righi, igor.lima, linux-arm-kernel,
	devicetree, linux-kernel, linux-actions, Rob Herring

Hi,

Am 25.05.20 um 03:30 schrieb Matheus Castello:
> Update the documentation to add the Caninos Loucos Labrador. Labrador
> project consists of a computer on module based on the Actions Semi S500
> processor and the Labrador base board.
> 
> Signed-off-by: Matheus Castello <matheus@castello.eng.br>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
>   Documentation/devicetree/bindings/arm/actions.yaml | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/actions.yaml b/Documentation/devicetree/bindings/arm/actions.yaml
> index ace3fdaa8396..2187e1c5bc73 100644
> --- a/Documentation/devicetree/bindings/arm/actions.yaml
> +++ b/Documentation/devicetree/bindings/arm/actions.yaml
> @@ -19,6 +19,11 @@ properties:
>                 - allo,sparky # Allo.com Sparky
>                 - cubietech,cubieboard6 # Cubietech CubieBoard6
>             - const: actions,s500
> +      - items:
> +          - enum:
> +              - caninos,labrador-v2 # Labrador Core v2
> +              - caninos,labrador-base-m # Labrador Base Board M v1

This enum still strikes me as wrong, it means either-or. (Was planning 
to look into it myself, but no time yet...) caninos,labrador-v2 should 
be a const one level down: board, SoM, SoC from most specific to most 
generic. Compare Guitar below.

> +          - const: actions,s500
>         - items:
>             - enum:
>                 - lemaker,guitar-bb-rev-b # LeMaker Guitar Base Board rev. B

Regards,
Andreas

-- 
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v5 2/3] dt-bindings: arm: actions: Document Caninos Loucos Labrador
@ 2020-05-25 10:41     ` Andreas Färber
  0 siblings, 0 replies; 12+ messages in thread
From: Andreas Färber @ 2020-05-25 10:41 UTC (permalink / raw)
  To: Matheus Castello, manivannan.sadhasivam, robh+dt
  Cc: mark.rutland, devicetree, Rob Herring, linux-actions,
	linux-kernel, igor.lima, edgar.righi, linux-arm-kernel

Hi,

Am 25.05.20 um 03:30 schrieb Matheus Castello:
> Update the documentation to add the Caninos Loucos Labrador. Labrador
> project consists of a computer on module based on the Actions Semi S500
> processor and the Labrador base board.
> 
> Signed-off-by: Matheus Castello <matheus@castello.eng.br>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
>   Documentation/devicetree/bindings/arm/actions.yaml | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/actions.yaml b/Documentation/devicetree/bindings/arm/actions.yaml
> index ace3fdaa8396..2187e1c5bc73 100644
> --- a/Documentation/devicetree/bindings/arm/actions.yaml
> +++ b/Documentation/devicetree/bindings/arm/actions.yaml
> @@ -19,6 +19,11 @@ properties:
>                 - allo,sparky # Allo.com Sparky
>                 - cubietech,cubieboard6 # Cubietech CubieBoard6
>             - const: actions,s500
> +      - items:
> +          - enum:
> +              - caninos,labrador-v2 # Labrador Core v2
> +              - caninos,labrador-base-m # Labrador Base Board M v1

This enum still strikes me as wrong, it means either-or. (Was planning 
to look into it myself, but no time yet...) caninos,labrador-v2 should 
be a const one level down: board, SoM, SoC from most specific to most 
generic. Compare Guitar below.

> +          - const: actions,s500
>         - items:
>             - enum:
>                 - lemaker,guitar-bb-rev-b # LeMaker Guitar Base Board rev. B

Regards,
Andreas

-- 
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v5 2/3] dt-bindings: arm: actions: Document Caninos Loucos Labrador
  2020-05-25 10:41     ` Andreas Färber
@ 2020-05-25 12:38       ` Matheus Castello
  -1 siblings, 0 replies; 12+ messages in thread
From: Matheus Castello @ 2020-05-25 12:38 UTC (permalink / raw)
  To: Andreas Färber, manivannan.sadhasivam, robh+dt
  Cc: mark.rutland, edgar.righi, igor.lima, linux-arm-kernel,
	devicetree, linux-kernel, linux-actions, Rob Herring

Hi Andreas,

Em 5/25/20 7:41 AM, Andreas Färber escreveu:
> Hi,
> 
> Am 25.05.20 um 03:30 schrieb Matheus Castello:
>> Update the documentation to add the Caninos Loucos Labrador. Labrador
>> project consists of a computer on module based on the Actions Semi S500
>> processor and the Labrador base board.
>>
>> Signed-off-by: Matheus Castello <matheus@castello.eng.br>
>> Acked-by: Rob Herring <robh@kernel.org>
>> ---
>>   Documentation/devicetree/bindings/arm/actions.yaml | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/actions.yaml 
>> b/Documentation/devicetree/bindings/arm/actions.yaml
>> index ace3fdaa8396..2187e1c5bc73 100644
>> --- a/Documentation/devicetree/bindings/arm/actions.yaml
>> +++ b/Documentation/devicetree/bindings/arm/actions.yaml
>> @@ -19,6 +19,11 @@ properties:
>>                 - allo,sparky # Allo.com Sparky
>>                 - cubietech,cubieboard6 # Cubietech CubieBoard6
>>             - const: actions,s500
>> +      - items:
>> +          - enum:
>> +              - caninos,labrador-v2 # Labrador Core v2
>> +              - caninos,labrador-base-m # Labrador Base Board M v1
> 
> This enum still strikes me as wrong, it means either-or. (Was planning 
> to look into it myself, but no time yet...) caninos,labrador-v2 should 
> be a const one level down: board, SoM, SoC from most specific to most 
> generic. Compare Guitar below.

I got it, I agree make sense, I will send the v6.

> 
>> +          - const: actions,s500
>>         - items:
>>             - enum:
>>                 - lemaker,guitar-bb-rev-b # LeMaker Guitar Base Board 
>> rev. B
> 
> Regards,
> Andreas
> 

Best Regards,
Matheus Castello

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v5 2/3] dt-bindings: arm: actions: Document Caninos Loucos Labrador
@ 2020-05-25 12:38       ` Matheus Castello
  0 siblings, 0 replies; 12+ messages in thread
From: Matheus Castello @ 2020-05-25 12:38 UTC (permalink / raw)
  To: Andreas Färber, manivannan.sadhasivam, robh+dt
  Cc: mark.rutland, devicetree, Rob Herring, linux-actions,
	linux-kernel, igor.lima, edgar.righi, linux-arm-kernel

Hi Andreas,

Em 5/25/20 7:41 AM, Andreas Färber escreveu:
> Hi,
> 
> Am 25.05.20 um 03:30 schrieb Matheus Castello:
>> Update the documentation to add the Caninos Loucos Labrador. Labrador
>> project consists of a computer on module based on the Actions Semi S500
>> processor and the Labrador base board.
>>
>> Signed-off-by: Matheus Castello <matheus@castello.eng.br>
>> Acked-by: Rob Herring <robh@kernel.org>
>> ---
>>   Documentation/devicetree/bindings/arm/actions.yaml | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/actions.yaml 
>> b/Documentation/devicetree/bindings/arm/actions.yaml
>> index ace3fdaa8396..2187e1c5bc73 100644
>> --- a/Documentation/devicetree/bindings/arm/actions.yaml
>> +++ b/Documentation/devicetree/bindings/arm/actions.yaml
>> @@ -19,6 +19,11 @@ properties:
>>                 - allo,sparky # Allo.com Sparky
>>                 - cubietech,cubieboard6 # Cubietech CubieBoard6
>>             - const: actions,s500
>> +      - items:
>> +          - enum:
>> +              - caninos,labrador-v2 # Labrador Core v2
>> +              - caninos,labrador-base-m # Labrador Base Board M v1
> 
> This enum still strikes me as wrong, it means either-or. (Was planning 
> to look into it myself, but no time yet...) caninos,labrador-v2 should 
> be a const one level down: board, SoM, SoC from most specific to most 
> generic. Compare Guitar below.

I got it, I agree make sense, I will send the v6.

> 
>> +          - const: actions,s500
>>         - items:
>>             - enum:
>>                 - lemaker,guitar-bb-rev-b # LeMaker Guitar Base Board 
>> rev. B
> 
> Regards,
> Andreas
> 

Best Regards,
Matheus Castello

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2020-05-25 13:00 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-25  1:30 [PATCH v5 0/3] Add Caninos Loucos Labrador CoM and Base Board Device Tree Matheus Castello
2020-05-25  1:30 ` Matheus Castello
2020-05-25  1:30 ` [PATCH v5 1/3] dt-bindings: Add vendor prefix for Caninos Loucos Matheus Castello
2020-05-25  1:30   ` Matheus Castello
2020-05-25  1:30 ` [PATCH v5 2/3] dt-bindings: arm: actions: Document Caninos Loucos Labrador Matheus Castello
2020-05-25  1:30   ` Matheus Castello
2020-05-25 10:41   ` Andreas Färber
2020-05-25 10:41     ` Andreas Färber
2020-05-25 12:38     ` Matheus Castello
2020-05-25 12:38       ` Matheus Castello
2020-05-25  1:30 ` [PATCH v5 3/3] ARM: dts: Add " Matheus Castello
2020-05-25  1:30   ` Matheus Castello

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.