From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0FF2C433DF for ; Mon, 25 May 2020 06:16:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF5F12071A for ; Mon, 25 May 2020 06:16:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="viFVpiWH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730574AbgEYGQ3 (ORCPT ); Mon, 25 May 2020 02:16:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730280AbgEYGQ1 (ORCPT ); Mon, 25 May 2020 02:16:27 -0400 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0623DC061A0E; Sun, 24 May 2020 23:16:27 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id t11so8286006pgg.2; Sun, 24 May 2020 23:16:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=b96SL8+sRaQd4BNuO23oq4bmCu1x+cpwG9cm6rdCDA0=; b=viFVpiWHuDc+z9efiUkJdmh0VIDdJhkAiST+Q8beFUNnLgWtubZLHcJRe/qLLGg8Ip oTS8O5XPHQs5ZVa21IJrk9t5LGs94tYmAROm9iFn1gJg9EDp/ugeFILzwEj705KEvBGw b6JOOJ8Nw5uv/ziocgKDzhB84SwhMNSQMNaUAF+Ud1gvxPqt/eCPKpnOQcblDZXukU0k +YBUM4j7kZBcaRI3PmXwDJ1y1cgi3Lpe6Krsm8Hb3yurUa3b1ux8WWYM8OKxnhdxfQ25 h3j2njsqK4+wVLtpj54w7bo2yq5Pakh/CDS4wsnvE8rqEgH2ggXaQJ6GUB5Z+zZZcTX0 lA8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=b96SL8+sRaQd4BNuO23oq4bmCu1x+cpwG9cm6rdCDA0=; b=WJJ8B7LrkOCkPqg9R4Jo3SeWEr1/GhkSEUvQ9UlzyPRjJVms27sYjQMFM7b0uVKfvB BQNZ4qItBNDG2LIo90rXnqQXOQhb4gIbAAj/s21nok3xWv2Luq2PFAx/lyLeJoYOnzDh OVa87gEVlzwCi66iSK39KKlUpvpYTnIiRysGYDYfEfdaLRGis7r/9cCeXpGZV0nEJtAJ 50qzs1tUuh3QcNsf6E/ZK1zt6u6LayVMvThTq5BzhFu7U1bHgTmN82O5dF/Y+lgzyygT K1sdXSoTs1sHtXY7HWH0CZ5yQwnfC7ppLjRyq3LooNJ6BYtaRPTtMldnwDwKiFLT7s7R nL6A== X-Gm-Message-State: AOAM533p+B+L7CzhGEZXE9wl0WkWoLz7tWKgwpa+Kx9CahjImJ4O9u08 k6TV6pcq7XRpT3l6UBRei8E= X-Google-Smtp-Source: ABdhPJxgBcGXY7WW27C6rn95w54bsP+6x+NYWWLJeYwxugt6XN3ID/4qT8FuaL3vxAeluC7dMnrvaA== X-Received: by 2002:aa7:84c6:: with SMTP id x6mr15776442pfn.46.1590387386501; Sun, 24 May 2020 23:16:26 -0700 (PDT) Received: from localhost (c-73-241-114-122.hsd1.ca.comcast.net. [73.241.114.122]) by smtp.gmail.com with ESMTPSA id v1sm12380566pjn.9.2020.05.24.23.16.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 May 2020 23:16:25 -0700 (PDT) Date: Sun, 24 May 2020 23:16:22 -0700 From: Richard Cochran To: Jianyong Wu Cc: "maz@kernel.org" , "netdev@vger.kernel.org" , "yangbo.lu@nxp.com" , "john.stultz@linaro.org" , "tglx@linutronix.de" , "pbonzini@redhat.com" , "sean.j.christopherson@intel.com" , Mark Rutland , "will@kernel.org" , Suzuki Poulose , Steven Price , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.cs.columbia.edu" , "kvm@vger.kernel.org" , Steve Capper , Kaly Xin , Justin He , Wei Chen , nd Subject: Re: [RFC PATCH v12 10/11] arm64: add mechanism to let user choose which counter to return Message-ID: <20200525061622.GA13679@localhost> References: <20200522083724.38182-1-jianyong.wu@arm.com> <20200522083724.38182-11-jianyong.wu@arm.com> <20200524021106.GC335@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 25, 2020 at 04:50:28AM +0000, Jianyong Wu wrote: > How about adding an extra argument in struct ptp_clock_info to serve as a flag, then we can control this flag using IOCTL to determine the counter type. no, No, NO! > > From your description, this "flag" really should be a module parameter. > Maybe use flag as a module parameter is a better way. Yes. Thanks, Richard From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56815C433DF for ; Mon, 25 May 2020 06:16:32 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id C5F85207DA for ; Mon, 25 May 2020 06:16:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="viFVpiWH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5F85207DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id EA3434B138; Mon, 25 May 2020 02:16:30 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@gmail.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6byJ3GzGBaAr; Mon, 25 May 2020 02:16:29 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id CD9164B179; Mon, 25 May 2020 02:16:29 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 6354E4B165 for ; Mon, 25 May 2020 02:16:28 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XrHCjd-TEugj for ; Mon, 25 May 2020 02:16:27 -0400 (EDT) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 77AD04B138 for ; Mon, 25 May 2020 02:16:27 -0400 (EDT) Received: by mail-pg1-f196.google.com with SMTP id w20so3248694pga.6 for ; Sun, 24 May 2020 23:16:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=b96SL8+sRaQd4BNuO23oq4bmCu1x+cpwG9cm6rdCDA0=; b=viFVpiWHuDc+z9efiUkJdmh0VIDdJhkAiST+Q8beFUNnLgWtubZLHcJRe/qLLGg8Ip oTS8O5XPHQs5ZVa21IJrk9t5LGs94tYmAROm9iFn1gJg9EDp/ugeFILzwEj705KEvBGw b6JOOJ8Nw5uv/ziocgKDzhB84SwhMNSQMNaUAF+Ud1gvxPqt/eCPKpnOQcblDZXukU0k +YBUM4j7kZBcaRI3PmXwDJ1y1cgi3Lpe6Krsm8Hb3yurUa3b1ux8WWYM8OKxnhdxfQ25 h3j2njsqK4+wVLtpj54w7bo2yq5Pakh/CDS4wsnvE8rqEgH2ggXaQJ6GUB5Z+zZZcTX0 lA8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=b96SL8+sRaQd4BNuO23oq4bmCu1x+cpwG9cm6rdCDA0=; b=qgxZ1n+rqSpmufx/j2BZhuszj8g+F+3bUmTuLQ8osMbivQFdnK8tsYaclNh9fWorxb dP+c6xgDkbf9N0mMPxybyNX0DNQ9s9xfSqdFMyy1lf+rK1eqvc4+A+mnzoKHl5JLb5VQ X0yoDHA43p2rZT0h/OUmIX916uNSGbMjqT0KK25bIQPj4juIFKIjrkIV8NQfVwmM5n/0 9ZVvF/IaVVoP7Dcr1NUh5c2SvmVw3moDo5kbsij0XpYN2vPIw5RBdiOr7lWYL+KyXh4Z 3vgfPMSQSACdWIE5qHoigjMKax7nkQff9KB16ypxEZ/myWA9qG48WKU2Id2GcuiQ2reB XyUw== X-Gm-Message-State: AOAM532yAJkwbVNPIbaABKQjPsd+aoeTcW+gO80TZrqw1EbHFp8tQKGX kHBGGbYva7BZDIYL6U8td7w= X-Google-Smtp-Source: ABdhPJxgBcGXY7WW27C6rn95w54bsP+6x+NYWWLJeYwxugt6XN3ID/4qT8FuaL3vxAeluC7dMnrvaA== X-Received: by 2002:aa7:84c6:: with SMTP id x6mr15776442pfn.46.1590387386501; Sun, 24 May 2020 23:16:26 -0700 (PDT) Received: from localhost (c-73-241-114-122.hsd1.ca.comcast.net. [73.241.114.122]) by smtp.gmail.com with ESMTPSA id v1sm12380566pjn.9.2020.05.24.23.16.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 May 2020 23:16:25 -0700 (PDT) Date: Sun, 24 May 2020 23:16:22 -0700 From: Richard Cochran To: Jianyong Wu Subject: Re: [RFC PATCH v12 10/11] arm64: add mechanism to let user choose which counter to return Message-ID: <20200525061622.GA13679@localhost> References: <20200522083724.38182-1-jianyong.wu@arm.com> <20200522083724.38182-11-jianyong.wu@arm.com> <20200524021106.GC335@localhost> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Justin He , Wei Chen , "kvm@vger.kernel.org" , "maz@kernel.org" , "linux-kernel@vger.kernel.org" , "sean.j.christopherson@intel.com" , Steven Price , "netdev@vger.kernel.org" , "john.stultz@linaro.org" , "yangbo.lu@nxp.com" , "pbonzini@redhat.com" , "tglx@linutronix.de" , nd , "will@kernel.org" , "kvmarm@lists.cs.columbia.edu" , "linux-arm-kernel@lists.infradead.org" X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Mon, May 25, 2020 at 04:50:28AM +0000, Jianyong Wu wrote: > How about adding an extra argument in struct ptp_clock_info to serve as a flag, then we can control this flag using IOCTL to determine the counter type. no, No, NO! > > From your description, this "flag" really should be a module parameter. > Maybe use flag as a module parameter is a better way. Yes. Thanks, Richard _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15240C433E1 for ; Mon, 25 May 2020 06:16:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD44C2071A for ; Mon, 25 May 2020 06:16:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LGWKa5NN"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="viFVpiWH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD44C2071A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XXTo1Hf1QlqJ+ffyXH5jK6eUJxft+esNg6JUrQbSt6g=; b=LGWKa5NNAB5/lB 5pSCYQ6slYAbgB/VWMaqChyLywDOSAB8t3p19r3ObfaM+5Jtvi0PgF7ECdffNuf1kEPGaRPZCj7BQ JimioWuWZuAdgpfGq/Pe9mnt1dzAV4aJCaudpB2Nx2F8k9SpTYYwlGBRrwHr07UF8zLunO/s/1FvG xW0yqmrgt/H1BChTQPGa5SsnCyTDYs9SEBKZfNYjvTuN/PBW+OB+xwI4U5Mo2SBogVgM8ktXRBxpM N+YCtfjrgKvuVFTSscQOukzNdxx+0lrD79zkFf7HZyFI3nYXHcXYrReWN0UG2TOW2obphIy3u/Mdc mjb5tnTCxYHTbclxdYPg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jd6PW-0004iR-Hf; Mon, 25 May 2020 06:16:30 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jd6PT-0004ho-PZ for linux-arm-kernel@lists.infradead.org; Mon, 25 May 2020 06:16:28 +0000 Received: by mail-pg1-x544.google.com with SMTP id s10so8285584pgm.0 for ; Sun, 24 May 2020 23:16:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=b96SL8+sRaQd4BNuO23oq4bmCu1x+cpwG9cm6rdCDA0=; b=viFVpiWHuDc+z9efiUkJdmh0VIDdJhkAiST+Q8beFUNnLgWtubZLHcJRe/qLLGg8Ip oTS8O5XPHQs5ZVa21IJrk9t5LGs94tYmAROm9iFn1gJg9EDp/ugeFILzwEj705KEvBGw b6JOOJ8Nw5uv/ziocgKDzhB84SwhMNSQMNaUAF+Ud1gvxPqt/eCPKpnOQcblDZXukU0k +YBUM4j7kZBcaRI3PmXwDJ1y1cgi3Lpe6Krsm8Hb3yurUa3b1ux8WWYM8OKxnhdxfQ25 h3j2njsqK4+wVLtpj54w7bo2yq5Pakh/CDS4wsnvE8rqEgH2ggXaQJ6GUB5Z+zZZcTX0 lA8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=b96SL8+sRaQd4BNuO23oq4bmCu1x+cpwG9cm6rdCDA0=; b=EWlOhWEg/6JbBoJCbtRSzEcowszx/DznoUs3Vcz0bBxuk84eCHzXsFxoAosE9IDHeY /8P3NPiCsdU7cZ6b6qhQyOT1CV9G8zbAc0J2nrsbgPkTOV1gXPJlRVSZhvYK+/AgOcX4 hB83aNOxzUQdFsVz8NnMHip4yHoWSGqhvMjs5cvszr+dopAsFrRubvXIcJo4t/BbeIs4 mthauMYIUxBOExDNnLYI//TlqQoy7vg7qq+yJfKb6An3DrHp1NonoqWg/qjYjqpap7eo Ght5778gk8w3KTIk3rYhMTaQ6f0RbvPD7KkcG4f93PuSCAS/zwk3IeK0BEPrnM/igBCY 4YwQ== X-Gm-Message-State: AOAM533BbUfNyePlaoRztESLPr1LGberlqqbgaklgg8WGzI1m1AaNKJq vPzxDNhel5HvIke+caWpn58V82cTBpop/Q== X-Google-Smtp-Source: ABdhPJxgBcGXY7WW27C6rn95w54bsP+6x+NYWWLJeYwxugt6XN3ID/4qT8FuaL3vxAeluC7dMnrvaA== X-Received: by 2002:aa7:84c6:: with SMTP id x6mr15776442pfn.46.1590387386501; Sun, 24 May 2020 23:16:26 -0700 (PDT) Received: from localhost (c-73-241-114-122.hsd1.ca.comcast.net. [73.241.114.122]) by smtp.gmail.com with ESMTPSA id v1sm12380566pjn.9.2020.05.24.23.16.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 May 2020 23:16:25 -0700 (PDT) Date: Sun, 24 May 2020 23:16:22 -0700 From: Richard Cochran To: Jianyong Wu Subject: Re: [RFC PATCH v12 10/11] arm64: add mechanism to let user choose which counter to return Message-ID: <20200525061622.GA13679@localhost> References: <20200522083724.38182-1-jianyong.wu@arm.com> <20200522083724.38182-11-jianyong.wu@arm.com> <20200524021106.GC335@localhost> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200524_231627_828434_289E3ECA X-CRM114-Status: UNSURE ( 9.58 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Justin He , Wei Chen , "kvm@vger.kernel.org" , Suzuki Poulose , "maz@kernel.org" , Steve Capper , "linux-kernel@vger.kernel.org" , "sean.j.christopherson@intel.com" , Steven Price , Kaly Xin , "netdev@vger.kernel.org" , "john.stultz@linaro.org" , "yangbo.lu@nxp.com" , "pbonzini@redhat.com" , "tglx@linutronix.de" , nd , "will@kernel.org" , "kvmarm@lists.cs.columbia.edu" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 25, 2020 at 04:50:28AM +0000, Jianyong Wu wrote: > How about adding an extra argument in struct ptp_clock_info to serve as a flag, then we can control this flag using IOCTL to determine the counter type. no, No, NO! > > From your description, this "flag" really should be a module parameter. > Maybe use flag as a module parameter is a better way. Yes. Thanks, Richard _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel