From: David Miller <davem@davemloft.net>
To: W_Armin@gmx.de
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v3 net-next] ne2k-pci: Fix various coding-style issues and improve printk() usage
Date: Tue, 26 May 2020 23:19:52 -0700 (PDT) [thread overview]
Message-ID: <20200526.231952.313275088392613610.davem@davemloft.net> (raw)
In-Reply-To: <20200526180302.GA5340@mx-linux-amd>
From: Armin Wolf <W_Armin@gmx.de>
Date: Tue, 26 May 2020 20:03:02 +0200
> Fixed a ton of minor checkpatch errors/warnings and remove version
> printing at module init/when device is found and use MODULE_VERSION
> instead. Also modifying the RTL8029 PCI string to include the compatible
> RTL8029AS nic.
> The only mayor issue remaining is the missing SPDX tag, but since the
> exact version of the GPL is not stated anywhere inside the file, its
> impossible to add such a tag at the moment.
> But maybe it is possible, since 8390.h states Donald Becker's 8390
> drivers are licensed under GPL 2.2 only (= GPL-2.0-only ?).
> The kernel module containing this patch compiles and runs without
> problems on a RTL8029AS-based NE2000 clone card with kernel 5.7.0-rc6.
>
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Applied, thank you.
prev parent reply other threads:[~2020-05-27 6:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 18:03 [PATCH v3 net-next] ne2k-pci: Fix various coding-style issues and improve printk() usage Armin Wolf
2020-05-27 6:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526.231952.313275088392613610.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=W_Armin@gmx.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.