From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C215CC433E0 for ; Tue, 26 May 2020 11:00:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9BF622086A for ; Tue, 26 May 2020 11:00:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590490825; bh=W+yADIr6cx+w8qOoQumX4ZVB1TVjc19ruDQ1PWLl28I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=AdbU7gLK8dAVhgq76dWYRB0Vc8rBqXTjoPV31Y/BiyTQlritrB02697YYExqdcIZ2 +OL9bZWPJEAp1svyKTcWoIbRE3YyJeIWKbcuVW2VAuheWBfILf5dPBpBILK9Mr4tQg KS3o5/o1noDq91AGAtTTwSvOfZVmjCDE7gMU7Fw0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388728AbgEZLAZ (ORCPT ); Tue, 26 May 2020 07:00:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:32966 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388726AbgEZLAY (ORCPT ); Tue, 26 May 2020 07:00:24 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 11BA12084C; Tue, 26 May 2020 11:00:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590490824; bh=W+yADIr6cx+w8qOoQumX4ZVB1TVjc19ruDQ1PWLl28I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vt5WbMWzXjehA4waBQOmrw7WLh+CtEoSxwGAAUyXopo0qVpcSqNLY8no2gOSz6N+R AnkU44LcCC0h+PEDfKOk6lAJOo4P7UmrBJVkcrxt/yl5knBJ28pmjqCXH26MePMXfW fuI/PUq54l4wosco1j7MtzMuGpYFPTAkxpgT1IEc= Date: Tue, 26 May 2020 13:00:22 +0200 From: Greg KH To: Santosh Sivaraj Cc: stable@vger.kernel.org, linuxppc-dev , Michael Ellerman , Sasha Levin , Peter Zijlstra Subject: Re: [PATCH v4 3/6] asm-generic/tlb, arch: Invert CONFIG_HAVE_RCU_TABLE_INVALIDATE Message-ID: <20200526110022.GB2838783@kroah.com> References: <20200520083025.229011-1-santosh@fossix.org> <20200520083025.229011-4-santosh@fossix.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200520083025.229011-4-santosh@fossix.org> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, May 20, 2020 at 02:00:22PM +0530, Santosh Sivaraj wrote: > From: Peter Zijlstra > > commit 96bc9567cbe112e9320250f01b9c060c882e8619 upstream > > Make issuing a TLB invalidate for page-table pages the normal case. > > The reason is twofold: > > - too many invalidates is safer than too few, > - most architectures use the linux page-tables natively > and would thus require this. > > Make it an opt-out, instead of an opt-in. > > No change in behavior intended. > > Signed-off-by: Peter Zijlstra (Intel) > Cc: # 4.19 > Signed-off-by: Santosh Sivaraj > [santosh: prerequisite for upcoming tlbflush backports] > --- > arch/Kconfig | 2 +- > arch/powerpc/Kconfig | 1 + > arch/sparc/Kconfig | 1 + > arch/x86/Kconfig | 1 - > mm/memory.c | 2 +- > 5 files changed, 4 insertions(+), 3 deletions(-) Why did you not also change arch/arm64/Kconfig and include/asm-generic/tlb.h like the original patch changed? Why can those files be ignored/left out? You need to explain that in the backport section, all you said was "prerequisite..." and did not say why you changed this patch. Please fix up, and make sure you do the same for all of the other patches in this series for when you resend it. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD754C433DF for ; Tue, 26 May 2020 11:02:34 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 544472084C for ; Tue, 26 May 2020 11:02:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="vt5WbMWz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 544472084C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49WWJQ2hsbzDqPG for ; Tue, 26 May 2020 21:02:30 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linuxfoundation.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=gregkh@linuxfoundation.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=default header.b=vt5WbMWz; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49WWG33FgnzDqDc for ; Tue, 26 May 2020 21:00:26 +1000 (AEST) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 11BA12084C; Tue, 26 May 2020 11:00:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590490824; bh=W+yADIr6cx+w8qOoQumX4ZVB1TVjc19ruDQ1PWLl28I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vt5WbMWzXjehA4waBQOmrw7WLh+CtEoSxwGAAUyXopo0qVpcSqNLY8no2gOSz6N+R AnkU44LcCC0h+PEDfKOk6lAJOo4P7UmrBJVkcrxt/yl5knBJ28pmjqCXH26MePMXfW fuI/PUq54l4wosco1j7MtzMuGpYFPTAkxpgT1IEc= Date: Tue, 26 May 2020 13:00:22 +0200 From: Greg KH To: Santosh Sivaraj Subject: Re: [PATCH v4 3/6] asm-generic/tlb, arch: Invert CONFIG_HAVE_RCU_TABLE_INVALIDATE Message-ID: <20200526110022.GB2838783@kroah.com> References: <20200520083025.229011-1-santosh@fossix.org> <20200520083025.229011-4-santosh@fossix.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200520083025.229011-4-santosh@fossix.org> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , Peter Zijlstra , linuxppc-dev , stable@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, May 20, 2020 at 02:00:22PM +0530, Santosh Sivaraj wrote: > From: Peter Zijlstra > > commit 96bc9567cbe112e9320250f01b9c060c882e8619 upstream > > Make issuing a TLB invalidate for page-table pages the normal case. > > The reason is twofold: > > - too many invalidates is safer than too few, > - most architectures use the linux page-tables natively > and would thus require this. > > Make it an opt-out, instead of an opt-in. > > No change in behavior intended. > > Signed-off-by: Peter Zijlstra (Intel) > Cc: # 4.19 > Signed-off-by: Santosh Sivaraj > [santosh: prerequisite for upcoming tlbflush backports] > --- > arch/Kconfig | 2 +- > arch/powerpc/Kconfig | 1 + > arch/sparc/Kconfig | 1 + > arch/x86/Kconfig | 1 - > mm/memory.c | 2 +- > 5 files changed, 4 insertions(+), 3 deletions(-) Why did you not also change arch/arm64/Kconfig and include/asm-generic/tlb.h like the original patch changed? Why can those files be ignored/left out? You need to explain that in the backport section, all you said was "prerequisite..." and did not say why you changed this patch. Please fix up, and make sure you do the same for all of the other patches in this series for when you resend it. thanks, greg k-h