From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD106C433E1 for ; Tue, 26 May 2020 13:35:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA5B6207CB for ; Tue, 26 May 2020 13:35:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729118AbgEZNfA (ORCPT ); Tue, 26 May 2020 09:35:00 -0400 Received: from foss.arm.com ([217.140.110.172]:50816 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726437AbgEZNe7 (ORCPT ); Tue, 26 May 2020 09:34:59 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C24351FB; Tue, 26 May 2020 06:34:58 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4DF703F6C4; Tue, 26 May 2020 06:34:57 -0700 (PDT) Date: Tue, 26 May 2020 14:34:50 +0100 From: Lorenzo Pieralisi To: Kunihiko Hayashi , robh+dt@kernel.org Cc: Bjorn Helgaas , Masahiro Yamada , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Masami Hiramatsu , Jassi Brar Subject: Re: [PATCH v4 1/2] dt-bindings: PCI: Add UniPhier PCIe endpoint controller description Message-ID: <20200526133450.GA24169@e121166-lin.cambridge.arm.com> References: <1589457801-12796-1-git-send-email-hayashi.kunihiko@socionext.com> <1589457801-12796-2-git-send-email-hayashi.kunihiko@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1589457801-12796-2-git-send-email-hayashi.kunihiko@socionext.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 14, 2020 at 09:03:20PM +0900, Kunihiko Hayashi wrote: > Add DT bindings for PCIe controller implemented in UniPhier SoCs > when configured in endpoint mode. This controller is based on > the DesignWare PCIe core. > > Signed-off-by: Kunihiko Hayashi > --- > .../bindings/pci/socionext,uniphier-pcie-ep.yaml | 92 ++++++++++++++++++++++ > MAINTAINERS | 2 +- > 2 files changed, 93 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/pci/socionext,uniphier-pcie-ep.yaml Hi Rob, are you OK with this patch ? Please let me know, I'd like to pull the series, thanks. Lorenzo > diff --git a/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie-ep.yaml > new file mode 100644 > index 0000000..f0558b9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie-ep.yaml > @@ -0,0 +1,92 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pci/socionext,uniphier-pcie-ep.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Socionext UniPhier PCIe endpoint controller > + > +description: | > + UniPhier PCIe endpoint controller is based on the Synopsys DesignWare > + PCI core. It shares common features with the PCIe DesignWare core and > + inherits common properties defined in > + Documentation/devicetree/bindings/pci/designware-pcie.txt. > + > +maintainers: > + - Kunihiko Hayashi > + > +allOf: > + - $ref: "pci-ep.yaml#" > + > +properties: > + compatible: > + const: socionext,uniphier-pro5-pcie-ep > + > + reg: > + maxItems: 4 > + > + reg-names: > + items: > + - const: dbi > + - const: dbi2 > + - const: link > + - const: addr_space > + > + clocks: > + maxItems: 2 > + > + clock-names: > + items: > + - const: gio > + - const: link > + > + resets: > + maxItems: 2 > + > + reset-names: > + items: > + - const: gio > + - const: link > + > + num-ib-windows: > + const: 16 > + > + num-ob-windows: > + const: 16 > + > + num-lanes: true > + > + phys: > + maxItems: 1 > + > + phy-names: > + const: pcie-phy > + > +required: > + - compatible > + - reg > + - reg-names > + - clocks > + - clock-names > + - resets > + - reset-names > + > +additionalProperties: false > + > +examples: > + - | > + pcie_ep: pcie-ep@66000000 { > + compatible = "socionext,uniphier-pro5-pcie-ep"; > + reg-names = "dbi", "dbi2", "link", "addr_space"; > + reg = <0x66000000 0x1000>, <0x66001000 0x1000>, > + <0x66010000 0x10000>, <0x67000000 0x400000>; > + clock-names = "gio", "link"; > + clocks = <&sys_clk 12>, <&sys_clk 24>; > + reset-names = "gio", "link"; > + resets = <&sys_rst 12>, <&sys_rst 24>; > + num-ib-windows = <16>; > + num-ob-windows = <16>; > + num-lanes = <4>; > + phy-names = "pcie-phy"; > + phys = <&pcie_phy>; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 92657a1..7f26748 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -13211,7 +13211,7 @@ PCIE DRIVER FOR SOCIONEXT UNIPHIER > M: Kunihiko Hayashi > L: linux-pci@vger.kernel.org > S: Maintained > -F: Documentation/devicetree/bindings/pci/uniphier-pcie.txt > +F: Documentation/devicetree/bindings/pci/uniphier-pcie* > F: drivers/pci/controller/dwc/pcie-uniphier.c > > PCIE DRIVER FOR ST SPEAR13XX > -- > 2.7.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23907C433E1 for ; Tue, 26 May 2020 13:35:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E29DF207CB for ; Tue, 26 May 2020 13:35:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EKfC5Wjj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E29DF207CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Egvm5iqxBA0RaQM/x3knL0BVdcVi4d1rHjDiM88vZS4=; b=EKfC5WjjtW21Tz 2zHTZ8RZlLNotLe3gXlo79J6cGdRNWxr8HKvGU3rIjvCU4PuKWtRzYCV0Jo0ZiSK7dheJ+mKTVcPK Yts5Fc/0GDI6zRxEoKNdJ0iwswEES6Z9SrVC+Tnq1D1K/MpKt6x/N5b9oTnSop9/uydUG1TriKTn5 pEAtTs0p0952iPej1dPOVXSntnceSeq1rANu9PORc2ilPiLjC8TCXFCTGbOaUN+EshD6vVbnnh+dx Neeemz3GRVbCfJBBZczr7hBxYq8mhQTZsOeHx0YmXBgiYY454XMv8vuX4eRMhXibGU9mKG9uqnmom 208id2D5wrYEphXYP9ZQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdZjU-0006XY-JI; Tue, 26 May 2020 13:35:04 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdZjQ-0006AM-Oh for linux-arm-kernel@lists.infradead.org; Tue, 26 May 2020 13:35:02 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C24351FB; Tue, 26 May 2020 06:34:58 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4DF703F6C4; Tue, 26 May 2020 06:34:57 -0700 (PDT) Date: Tue, 26 May 2020 14:34:50 +0100 From: Lorenzo Pieralisi To: Kunihiko Hayashi , robh+dt@kernel.org Subject: Re: [PATCH v4 1/2] dt-bindings: PCI: Add UniPhier PCIe endpoint controller description Message-ID: <20200526133450.GA24169@e121166-lin.cambridge.arm.com> References: <1589457801-12796-1-git-send-email-hayashi.kunihiko@socionext.com> <1589457801-12796-2-git-send-email-hayashi.kunihiko@socionext.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1589457801-12796-2-git-send-email-hayashi.kunihiko@socionext.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200526_063500_902290_89BD53F6 X-CRM114-Status: GOOD ( 18.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Masami Hiramatsu , Jassi Brar , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Masahiro Yamada , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 14, 2020 at 09:03:20PM +0900, Kunihiko Hayashi wrote: > Add DT bindings for PCIe controller implemented in UniPhier SoCs > when configured in endpoint mode. This controller is based on > the DesignWare PCIe core. > > Signed-off-by: Kunihiko Hayashi > --- > .../bindings/pci/socionext,uniphier-pcie-ep.yaml | 92 ++++++++++++++++++++++ > MAINTAINERS | 2 +- > 2 files changed, 93 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/pci/socionext,uniphier-pcie-ep.yaml Hi Rob, are you OK with this patch ? Please let me know, I'd like to pull the series, thanks. Lorenzo > diff --git a/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie-ep.yaml > new file mode 100644 > index 0000000..f0558b9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie-ep.yaml > @@ -0,0 +1,92 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pci/socionext,uniphier-pcie-ep.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Socionext UniPhier PCIe endpoint controller > + > +description: | > + UniPhier PCIe endpoint controller is based on the Synopsys DesignWare > + PCI core. It shares common features with the PCIe DesignWare core and > + inherits common properties defined in > + Documentation/devicetree/bindings/pci/designware-pcie.txt. > + > +maintainers: > + - Kunihiko Hayashi > + > +allOf: > + - $ref: "pci-ep.yaml#" > + > +properties: > + compatible: > + const: socionext,uniphier-pro5-pcie-ep > + > + reg: > + maxItems: 4 > + > + reg-names: > + items: > + - const: dbi > + - const: dbi2 > + - const: link > + - const: addr_space > + > + clocks: > + maxItems: 2 > + > + clock-names: > + items: > + - const: gio > + - const: link > + > + resets: > + maxItems: 2 > + > + reset-names: > + items: > + - const: gio > + - const: link > + > + num-ib-windows: > + const: 16 > + > + num-ob-windows: > + const: 16 > + > + num-lanes: true > + > + phys: > + maxItems: 1 > + > + phy-names: > + const: pcie-phy > + > +required: > + - compatible > + - reg > + - reg-names > + - clocks > + - clock-names > + - resets > + - reset-names > + > +additionalProperties: false > + > +examples: > + - | > + pcie_ep: pcie-ep@66000000 { > + compatible = "socionext,uniphier-pro5-pcie-ep"; > + reg-names = "dbi", "dbi2", "link", "addr_space"; > + reg = <0x66000000 0x1000>, <0x66001000 0x1000>, > + <0x66010000 0x10000>, <0x67000000 0x400000>; > + clock-names = "gio", "link"; > + clocks = <&sys_clk 12>, <&sys_clk 24>; > + reset-names = "gio", "link"; > + resets = <&sys_rst 12>, <&sys_rst 24>; > + num-ib-windows = <16>; > + num-ob-windows = <16>; > + num-lanes = <4>; > + phy-names = "pcie-phy"; > + phys = <&pcie_phy>; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 92657a1..7f26748 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -13211,7 +13211,7 @@ PCIE DRIVER FOR SOCIONEXT UNIPHIER > M: Kunihiko Hayashi > L: linux-pci@vger.kernel.org > S: Maintained > -F: Documentation/devicetree/bindings/pci/uniphier-pcie.txt > +F: Documentation/devicetree/bindings/pci/uniphier-pcie* > F: drivers/pci/controller/dwc/pcie-uniphier.c > > PCIE DRIVER FOR ST SPEAR13XX > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel