From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FAKE_REPLY_C,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6616AC433E0 for ; Tue, 26 May 2020 13:38:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3ADA7208A7 for ; Tue, 26 May 2020 13:38:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZPkcwxAT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729416AbgEZNi3 (ORCPT ); Tue, 26 May 2020 09:38:29 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:55901 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728126AbgEZNi3 (ORCPT ); Tue, 26 May 2020 09:38:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590500307; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mabzjriXuR5UslAMwT5FPifo2JvIhJN5aCxBAg7GGAg=; b=ZPkcwxATfp/BEzoUFoPOeTcg6fGR81SYcrbn6Fk2cmf01pgGFs3kmLuwPDWXIfIQpmCRDi ob40YkAsTx+gs+uyPTaL41UmAOAwP3V1aPU4WqHcShFlGhr6muDLjHgxDHpqbuSOvWoPHQ aXKnnG3lSaWCpwxvm/ia1byGoy9NQkY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-118-CMIUl74hOO2FLNRY4bThDw-1; Tue, 26 May 2020 09:38:25 -0400 X-MC-Unique: CMIUl74hOO2FLNRY4bThDw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F28A71054F8B; Tue, 26 May 2020 13:38:23 +0000 (UTC) Received: from sandy.ghostprotocols.net (unknown [10.3.128.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7F77B6ED98; Tue, 26 May 2020 13:38:21 +0000 (UTC) Received: by sandy.ghostprotocols.net (Postfix, from userid 1000) id 531181C9; Tue, 26 May 2020 10:38:17 -0300 (BRT) Date: Tue, 26 May 2020 10:38:17 -0300 From: Arnaldo Carvalho de Melo To: Steven Rostedt , Andi Kleen , Jin Yao Cc: ahmadkhorrami , Linux-trace Users , linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo Subject: Re: Perf Reports Jump Instructions as Memory Access Instructions Message-ID: <20200526133817.GA23187@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Sender: linux-trace-users-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-users@vger.kernel.org Em Mon, May 25, 2020 at 10:52:25AM -0400, Steven Rostedt escreveu: > Arnaldo, > > This one may be for you ;-) Humm, I think linux-perf-users@vger.kernel.org may be better, I'm also adding some Intel guys that work on perf that may be of help. Jin came to mind as having worked in this feature in the past: commit 7e63a13a266da652f82731b845b5c35dd866ec7e Author: Jin Yao Date: Fri Jul 7 13:06:35 2017 +0800 perf annotate: Implement visual marker for macro fusion For marking fused instructions clearly this patch adds a line before the first instruction of pair and joins it with the arrow of the jump to its target. For example, when "je" is selected in annotate view, the line before cmpl is displayed and joins the arrow of "je". │ ┌──cmpl $0x0,argp_program_version_hook 81.93 │ ├──je 20 │ │ lock cmpxchg %esi,0x38a9a4(%rip) │ │↓ jne 29 │ │↓ jmp 43 11.47 │20:└─→cmpxch %esi,0x38a999(%rip) I took a stab at explaining it, but I'm not sure that makes sense, take a look :) > On Sun, 17 May 2020 19:40:52 +0430 ahmadkhorrami wrote: > > I used the following perf command to sample user space read accesses to > > DRAM by evince: > > perf record -d --call-graph dwarf -c 100 -e > > mem_load_uops_retired.l3_miss:uppp /opt/evince-3.28.4/bin/evince > > As can be seen, I used the PEBS feature to increase the accuracy of > > sampling. But there are some non-memory accesses reported as memory > > ones. Here is one of them reported by perf script -D: > > 11159097179866 0xfb80 [0x1778]: PERF_RECORD_SAMPLE(IP, 0x4002): > > 7309/7309: 0x7ffff6d6c310 period: 10000 addr: 0x7ffff7034e50 > > ... FP chain: nr:0 > > ... user regs: mask 0xff0fff ABI 64-bit > > .... AX 0x555555b8b4c0 > > .... BX 0x555555c48e10 > > .... CX 0x1 > > .... DX 0x7fffffffd988 > > .... SI 0x7fffffffd980 > > .... DI 0x555555b8b4c0 > > .... BP 0x258 > > .... SP 0x7fffffffd978 > > .... IP 0x7ffff6d6c310 > > .... FLAGS 0x20e > > .... CS 0x33 > > .... SS 0x2b > > .... R8 0x27c > > .... R9 0x24 > > .... R10 0x2a2 > > .... R11 0x0 > > .... R12 0x258 > > .... R13 0x555555b8b4c0 > > .... R14 0x3000 > > .... R15 0x7ffff5747000 > > ... ustack: size 5768, offset 0xd8 > > . data_src: 0x5080022 > > ... thread: evince:7309 > > ...... dso: /usr/lib/x86_64-linux-gnu/libgdk-3.so.0.2200.30 > > evince 7309 11159.097179: 10000 > > mem_load_uops_retired.l3_miss:uppp: 7ffff7034e50 5080022 > > N/A|SNP N/A|TLB N/A|LCK N/A > > 7ffff6d6c310 cairo_surface_get_device_scale@plt+0x0 > > (/usr/lib/x86_64-linux-gnu/libgdk-3.so.0.2200.30) > > 7ffff6d91029 gdk_window_create_similar_surface+0xc9 > > (/usr/lib/x86_64-linux-gnu/libgdk-3.so.0.2200.30) > > 7ffff6d95410 gdk_window_begin_paint_internal+0x350 > > (/usr/lib/x86_64-linux-gnu/libgdk-3.so.0.2200.30) > > 7ffff6d956f1 gdk_window_begin_draw_frame+0xc1 > > (/usr/lib/x86_64-linux-gnu/libgdk-3.so.0.2200.30) > > 7ffff73c4942 gtk_widget_render+0xd2 > > (/usr/lib/x86_64-linux-gnu/libgtk-3.so.0.2200.30) > > 7ffff7268858 gtk_main_do_event+0x708 > > (/usr/lib/x86_64-linux-gnu/libgtk-3.so.0.2200.30) > > 7ffff6d79764 _gdk_event_emit+0x24 > > (/usr/lib/x86_64-linux-gnu/libgdk-3.so.0.2200.30) > > 7ffff6d897f4 _gdk_window_process_updates_recurse_helper+0x104 > > (/usr/lib/x86_64-linux-gnu/libgdk-3.so.0.2200.30) > > 7ffff6d8a9f5 gdk_window_process_updates_internal+0x165 > > (/usr/lib/x86_64-linux-gnu/libgdk-3.so.0.2200.30) > > 7ffff6d8abef gdk_window_process_updates_with_mode+0x11f > > (/usr/lib/x86_64-linux-gnu/libgdk-3.so.0.2200.30) > > 7ffff574510c g_closure_invoke+0x19c > > (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.5600.4) > > 7ffff575805d signal_emit_unlocked_R+0xf4d > > (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.5600.4) > > 7ffff5760714 g_signal_emit_valist+0xa74 > > (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.5600.4) > > 7ffff576112e g_signal_emit+0x8e > > (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.5600.4) > > 7ffff6d82ac8 gdk_frame_clock_paint_idle+0x3c8 > > (/usr/lib/x86_64-linux-gnu/libgdk-3.so.0.2200.30) > > 7ffff6d6e07f gdk_threads_dispatch+0x1f > > (/usr/lib/x86_64-linux-gnu/libgdk-3.so.0.2200.30) > > 7ffff546ad02 g_timeout_dispatch+0x12 > > (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.5600.4) > > 7ffff546a284 g_main_dispatch+0x154 (inlined) > > 7ffff546a284 g_main_context_dispatch+0x154 > > (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.5600.4) > > 7ffff546a64f g_main_context_iterate+0x1ff (inlined) > > 7ffff546a6db g_main_context_iteration+0x2b > > (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.5600.4) > > 7ffff5a2be3c g_application_run+0x1fc > > (/usr/lib/x86_64-linux-gnu/libgio-2.0.so.0.5600.4) > > 555555573707 main+0x447 (/opt/evince-3.28.4/bin/evince) > > 7ffff4a91b96 __libc_start_main+0xe6 > > (/lib/x86_64-linux-gnu/libc-2.27.so) > > 555555573899 _start+0x29 (/opt/evince-3.28.4/bin/evince) > > > > The access point is at offset 0 of the following disassembly: > Dump of assembler code for function cairo_surface_get_device_scale@plt: > > 0x000000000002a310 <+0>: jmpq *0x2c8b3a(%rip) # 0x2f2e50 > > 0x000000000002a316 <+6>: pushq $0x1c7 > > 0x000000000002a31b <+11>: jmpq 0x28690 > > > > This is an unconditional jump which will not lead to macrofusion. But that will access memory, no? The instruction at offset 0. 11159097179866 0xfb80 [0x1778]: PERF_RECORD_SAMPLE(IP, 0x4002): 7309/7309: 0x7ffff6d6c310 period: 10000 addr: 0x7ffff7034e50 .... IP 0x7ffff6d6c310 So the sample was at 0x7ffff6d6c310 and was for the addr 0x7ffff7034e50: jmpq *0x2c8b3a(%rip) IP + 0x2c8b3a == 0x7ffff6d6c310 + 0x2c8b3a == 0x7ffff7034e4a 0x7ffff7034e4a - 0x7ffff7034e50 == -0x6 Close enough? Some PEBS measurement skid? Jin? > > Any help is appreciated. - Arnaldo