From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D70DCC433DF for ; Tue, 26 May 2020 14:36:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8DD1F2075F for ; Tue, 26 May 2020 14:36:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="U+0g7Zby" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DD1F2075F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 36C7A800AE; Tue, 26 May 2020 10:36:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 31BC280061; Tue, 26 May 2020 10:36:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20A5E800AE; Tue, 26 May 2020 10:36:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0033.hostedemail.com [216.40.44.33]) by kanga.kvack.org (Postfix) with ESMTP id 0642680061 for ; Tue, 26 May 2020 10:36:45 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id BF1065836 for ; Tue, 26 May 2020 14:36:44 +0000 (UTC) X-FDA: 76859121528.11.sheet19_750d6e326d813 X-HE-Tag: sheet19_750d6e326d813 X-Filterd-Recvd-Size: 3537 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Tue, 26 May 2020 14:36:44 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id n141so8330055qke.2 for ; Tue, 26 May 2020 07:36:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gSMxkbANh+XLN6PP/4ucZuGEACp8kUKlkMdq6GXfIvM=; b=U+0g7ZbyD4qZebQ9Yr1Tde+o7I3mql3aPxL8sWDvzlxU5cmn3t+uZbtx6mIDzprHCt 2C1fQt0QvnAPRBhgLV1A3bTwEtphKN0Lc25f0vKTBeBo2MSRgY/a7fkL6Pa7k6lRb8ZM 94e45AvYbveRYbGHyWuW2Njv/RRLthFzznzNwqkkTSBAhWQdyICWRSo5fZ3SIx4kGrU0 mNrFMJNxiRIop05HbW3bdvfcWD+GC1x8BjbP9We1hQ/lH+EkPK6bs2I7dwerFkfHRpxL iYavJ0KJ10REHmnxvLdjnI4beMn21lvjWSTncPsPsjtGSDIS0L6UPtmAoe3Qu8OSCfol CYYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=gSMxkbANh+XLN6PP/4ucZuGEACp8kUKlkMdq6GXfIvM=; b=rdASEWGdq4N4ETt48PYTYaGdpiy54C2c0XJ4Xg5GzgslEDjjqd2W4Ft+AmuGJPL7BW pBVoa0YCkyu8cOSpfBGIEJtee1AzlURFXHt0IR1RiuEKro8f9W9ILxGzHdoHT8A8Qnca oDPWjjbpDTd83r1RlMTryqkaNWP7EonkUq8LpqA9LC/Bkxu2cUnYHXdh4QXrTTEzhtXa 2N/Wok9akLudCQ3X3dNIMK2s9rFUkQUicMsC/wfic3+7XyfEGxa1kl19LNkm+q+XqMW8 xj9UOz/2eq7EMRdYS6b1lOzsB1Qr2JQAgQiru5EXgdi3osEKICS+T4l7cnw6eZgnUe/d 7UOw== X-Gm-Message-State: AOAM532EpAARwe4zCpu8IXjZy1/epPyjoQqM1Y4O5ZpdfjVXYdQ1DtDA RyVxIsgHGOHx5jEdtWEYN9euLg== X-Google-Smtp-Source: ABdhPJwOKF5sdpcFqW9yOgw50aYn4nD7GBnxXJATNZK4P49/0FheNH4a5ZFyHsrHdK8qUHMPywDWGw== X-Received: by 2002:a37:4c11:: with SMTP id z17mr1549126qka.180.1590503803641; Tue, 26 May 2020 07:36:43 -0700 (PDT) Received: from localhost (70.44.39.90.res-cmts.bus.ptd.net. [70.44.39.90]) by smtp.gmail.com with ESMTPSA id i3sm17142417qkf.39.2020.05.26.07.36.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2020 07:36:43 -0700 (PDT) Date: Tue, 26 May 2020 10:36:19 -0400 From: Johannes Weiner To: Jakub Kicinski Cc: akpm@linux-foundation.org, linux-mm@kvack.org, kernel-team@fb.com, tj@kernel.org, chris@chrisdown.name, cgroups@vger.kernel.org, shakeelb@google.com, mhocko@kernel.org Subject: Re: [PATCH mm v5 RESEND 2/4] mm: move penalty delay clamping out of calculate_high_delay() Message-ID: <20200526143619.GB848026@cmpxchg.org> References: <20200521002411.3963032-1-kuba@kernel.org> <20200521002411.3963032-3-kuba@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200521002411.3963032-3-kuba@kernel.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000398, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 20, 2020 at 05:24:09PM -0700, Jakub Kicinski wrote: > We will want to call calculate_high_delay() twice - once for > memory and once for swap, and we should apply the clamp value > to sum of the penalties. Clamping has to be applied outside > of calculate_high_delay(). > > Signed-off-by: Jakub Kicinski > Reviewed-by: Shakeel Butt Acked-by: Johannes Weiner From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Weiner Subject: Re: [PATCH mm v5 RESEND 2/4] mm: move penalty delay clamping out of calculate_high_delay() Date: Tue, 26 May 2020 10:36:19 -0400 Message-ID: <20200526143619.GB848026@cmpxchg.org> References: <20200521002411.3963032-1-kuba@kernel.org> <20200521002411.3963032-3-kuba@kernel.org> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gSMxkbANh+XLN6PP/4ucZuGEACp8kUKlkMdq6GXfIvM=; b=U+0g7ZbyD4qZebQ9Yr1Tde+o7I3mql3aPxL8sWDvzlxU5cmn3t+uZbtx6mIDzprHCt 2C1fQt0QvnAPRBhgLV1A3bTwEtphKN0Lc25f0vKTBeBo2MSRgY/a7fkL6Pa7k6lRb8ZM 94e45AvYbveRYbGHyWuW2Njv/RRLthFzznzNwqkkTSBAhWQdyICWRSo5fZ3SIx4kGrU0 mNrFMJNxiRIop05HbW3bdvfcWD+GC1x8BjbP9We1hQ/lH+EkPK6bs2I7dwerFkfHRpxL iYavJ0KJ10REHmnxvLdjnI4beMn21lvjWSTncPsPsjtGSDIS0L6UPtmAoe3Qu8OSCfol CYYw== Content-Disposition: inline In-Reply-To: <20200521002411.3963032-3-kuba-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jakub Kicinski Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, kernel-team-b10kYP2dOMg@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, chris-6Bi1550iOqEnzZ6mRAm98g@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org On Wed, May 20, 2020 at 05:24:09PM -0700, Jakub Kicinski wrote: > We will want to call calculate_high_delay() twice - once for > memory and once for swap, and we should apply the clamp value > to sum of the penalties. Clamping has to be applied outside > of calculate_high_delay(). > > Signed-off-by: Jakub Kicinski > Reviewed-by: Shakeel Butt Acked-by: Johannes Weiner