From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF977C433E0 for ; Tue, 26 May 2020 15:07:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A98772070A for ; Tue, 26 May 2020 15:07:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729709AbgEZPHt (ORCPT ); Tue, 26 May 2020 11:07:49 -0400 Received: from mail-ej1-f65.google.com ([209.85.218.65]:43297 "EHLO mail-ej1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728166AbgEZPHt (ORCPT ); Tue, 26 May 2020 11:07:49 -0400 Received: by mail-ej1-f65.google.com with SMTP id a2so24155918ejb.10; Tue, 26 May 2020 08:07:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KjgTih7A660W8l2Ai5zV0xie7l2fjS3cquiqxZY0eUs=; b=lj0xOxS+RFiPf9SsOq/2HiLpzJM8NqDxbOEmL6gK5IWHwUO1MvEcGdGh/ue2UIwHEs g1fuHrUZTMNafI1bJQlUpKzxnH0gIOZ2sDFdr3agSkIZjUNbR+E+3qyAH8GhAbdq+JQO uowDnKKCjJIGxSvbMpLth3SFSzzIFsGZtL8EgFNZpGPyXxh2/PdBvnFAGRG+aE0vP4A8 Jk5rQMDzbtDospNqOqOlXNmu5iNO6beaa8MWhQt6lm/O3dx5IYX2B9t6zjPUsAQuBYGW +1KPD8SnieaYmzDNPUcPPHZqGVuJBVrp4k5fShXQmCcuIFEyUovshFaMOKky8Wl3YcdI ToQA== X-Gm-Message-State: AOAM5306iPBdlX3xOO+3pC8x3R7m9tVCiXk0LcQ01D98VdJJ/LLCrMTi 8Sp0+ggbBZLudgHz0UkIczY= X-Google-Smtp-Source: ABdhPJzpF2izaI7HGirZOZ/xZQdcIiUyWXIQKdVRDh55kJz8UdqLFQpxuDMPANNvmQBg9fruG2pCcw== X-Received: by 2002:a17:906:8748:: with SMTP id hj8mr1609977ejb.335.1590505666414; Tue, 26 May 2020 08:07:46 -0700 (PDT) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id t22sm137834ejr.93.2020.05.26.08.07.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2020 08:07:45 -0700 (PDT) Date: Tue, 26 May 2020 17:07:44 +0200 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Greg Kroah-Hartman Cc: Dan Carpenter , "Rafael J. Wysocki" , Len Brown , Kevin Hilman , Ulf Hansson , Pavel Machek , Johan Hovold , Alex Elder , Bjorn Helgaas , "James E.J. Bottomley" , "Martin K. Petersen" , Felipe Balbi , Julian Wiedmann , Karsten Graul , Ursula Braun , Jakub Kicinski , Bjorn Andersson , John Stultz , "David S. Miller" , greybus-dev@lists.linaro.org, netdev@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 8/8] net/iucv: Use the new device_to_pm() helper to access struct dev_pm_ops Message-ID: <20200526150744.GC75990@rocinante> References: <20200525182608.1823735-1-kw@linux.com> <20200525182608.1823735-9-kw@linux.com> <20200526063521.GC2578492@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200526063521.GC2578492@kroah.com> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hello Greg, [...] > It's "interesting" how using your new helper doesn't actually make the > code smaller. Perhaps it isn't a good helper function? The idea for the helper was inspired by the comment Dan made to Bjorn about Bjorn's change, as per: https://lore.kernel.org/driverdev-devel/20191016135002.GA24678@kadam/ It looked like a good idea to try to reduce the following: dev->driver && dev->driver->pm && dev->driver->pm->prepare Into something more succinct. Albeit, given the feedback from yourself and Rafael, I gather that this helper is not really a good addition. Thank you everyone and sorry for the commotion! Krzysztof