All of lore.kernel.org
 help / color / mirror / Atom feed
* [rcu:dev.2020.05.25a 51/63] kernel/rcu/refperf.c:298:6: warning: no previous prototype for function 'reset_readers'
@ 2020-05-26 12:07 ` kbuild test robot
  0 siblings, 0 replies; 5+ messages in thread
From: kbuild test robot @ 2020-05-26 12:07 UTC (permalink / raw)
  To: Joel Fernandes (Google)
  Cc: kbuild-all, clang-built-linux, linux-kernel, Paul E. McKenney

[-- Attachment #1: Type: text/plain, Size: 2938 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2020.05.25a
head:   1e9451642683146552713c5ce6d269ae378eacd5
commit: 786a25497743696d79592b864cafbfe48787e6e1 [51/63] refperf: Add a test to measure performance of read-side synchronization
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 3393cc4cebf9969db94dc424b7a2b6195589c33b)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        git checkout 786a25497743696d79592b864cafbfe48787e6e1
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

>> kernel/rcu/refperf.c:298:6: warning: no previous prototype for function 'reset_readers' [-Wmissing-prototypes]
void reset_readers(int n)
^
kernel/rcu/refperf.c:298:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void reset_readers(int n)
^
static
>> kernel/rcu/refperf.c:311:5: warning: no previous prototype for function 'process_durations' [-Wmissing-prototypes]
u64 process_durations(int n)
^
kernel/rcu/refperf.c:311:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
u64 process_durations(int n)
^
static
2 warnings generated.

vim +/reset_readers +298 kernel/rcu/refperf.c

   297	
 > 298	void reset_readers(int n)
   299	{
   300		int i;
   301		struct reader_task *rt;
   302	
   303		for (i = 0; i < n; i++) {
   304			rt = &(reader_tasks[i]);
   305	
   306			rt->last_duration_ns = 0;
   307		}
   308	}
   309	
   310	// Print the results of each reader and return the sum of all their durations.
 > 311	u64 process_durations(int n)
   312	{
   313		int i;
   314		struct reader_task *rt;
   315		char buf1[64];
   316		char buf[512];
   317		u64 sum = 0;
   318	
   319		buf[0] = 0;
   320		sprintf(buf, "Experiment #%d (Format: <THREAD-NUM>:<Total loop time in ns>)",
   321			exp_idx);
   322	
   323		for (i = 0; i <= n && !torture_must_stop(); i++) {
   324			rt = &(reader_tasks[i]);
   325			sprintf(buf1, "%d: %llu\t", i, rt->last_duration_ns);
   326	
   327			if (i % 5 == 0)
   328				strcat(buf, "\n");
   329			strcat(buf, buf1);
   330	
   331			sum += rt->last_duration_ns;
   332		}
   333		strcat(buf, "\n");
   334	
   335		PERFOUT("%s\n", buf);
   336	
   337		return sum;
   338	}
   339	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 73580 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [rcu:dev.2020.05.25a 51/63] kernel/rcu/refperf.c:298:6: warning: no previous prototype for function 'reset_readers'
@ 2020-05-26 12:07 ` kbuild test robot
  0 siblings, 0 replies; 5+ messages in thread
From: kbuild test robot @ 2020-05-26 12:07 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 3024 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2020.05.25a
head:   1e9451642683146552713c5ce6d269ae378eacd5
commit: 786a25497743696d79592b864cafbfe48787e6e1 [51/63] refperf: Add a test to measure performance of read-side synchronization
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 3393cc4cebf9969db94dc424b7a2b6195589c33b)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        git checkout 786a25497743696d79592b864cafbfe48787e6e1
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

>> kernel/rcu/refperf.c:298:6: warning: no previous prototype for function 'reset_readers' [-Wmissing-prototypes]
void reset_readers(int n)
^
kernel/rcu/refperf.c:298:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void reset_readers(int n)
^
static
>> kernel/rcu/refperf.c:311:5: warning: no previous prototype for function 'process_durations' [-Wmissing-prototypes]
u64 process_durations(int n)
^
kernel/rcu/refperf.c:311:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
u64 process_durations(int n)
^
static
2 warnings generated.

vim +/reset_readers +298 kernel/rcu/refperf.c

   297	
 > 298	void reset_readers(int n)
   299	{
   300		int i;
   301		struct reader_task *rt;
   302	
   303		for (i = 0; i < n; i++) {
   304			rt = &(reader_tasks[i]);
   305	
   306			rt->last_duration_ns = 0;
   307		}
   308	}
   309	
   310	// Print the results of each reader and return the sum of all their durations.
 > 311	u64 process_durations(int n)
   312	{
   313		int i;
   314		struct reader_task *rt;
   315		char buf1[64];
   316		char buf[512];
   317		u64 sum = 0;
   318	
   319		buf[0] = 0;
   320		sprintf(buf, "Experiment #%d (Format: <THREAD-NUM>:<Total loop time in ns>)",
   321			exp_idx);
   322	
   323		for (i = 0; i <= n && !torture_must_stop(); i++) {
   324			rt = &(reader_tasks[i]);
   325			sprintf(buf1, "%d: %llu\t", i, rt->last_duration_ns);
   326	
   327			if (i % 5 == 0)
   328				strcat(buf, "\n");
   329			strcat(buf, buf1);
   330	
   331			sum += rt->last_duration_ns;
   332		}
   333		strcat(buf, "\n");
   334	
   335		PERFOUT("%s\n", buf);
   336	
   337		return sum;
   338	}
   339	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 73580 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [rcu:dev.2020.05.25a 51/63] kernel/rcu/refperf.c:298:6: warning: no previous prototype for function 'reset_readers'
  2020-05-26 12:07 ` kbuild test robot
@ 2020-05-26 16:11   ` Paul E. McKenney
  -1 siblings, 0 replies; 5+ messages in thread
From: Paul E. McKenney @ 2020-05-26 16:11 UTC (permalink / raw)
  To: kbuild test robot
  Cc: Joel Fernandes (Google), kbuild-all, clang-built-linux, linux-kernel

On Tue, May 26, 2020 at 08:07:35PM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2020.05.25a
> head:   1e9451642683146552713c5ce6d269ae378eacd5
> commit: 786a25497743696d79592b864cafbfe48787e6e1 [51/63] refperf: Add a test to measure performance of read-side synchronization
> config: x86_64-allyesconfig (attached as .config)
> compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 3393cc4cebf9969db94dc424b7a2b6195589c33b)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # install x86_64 cross compiling tool for clang build
>         # apt-get install binutils-x86-64-linux-gnu
>         git checkout 786a25497743696d79592b864cafbfe48787e6e1
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>, old ones prefixed by <<):
> 
> >> kernel/rcu/refperf.c:298:6: warning: no previous prototype for function 'reset_readers' [-Wmissing-prototypes]
> void reset_readers(int n)
> ^
> kernel/rcu/refperf.c:298:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> void reset_readers(int n)
> ^
> static
> >> kernel/rcu/refperf.c:311:5: warning: no previous prototype for function 'process_durations' [-Wmissing-prototypes]
> u64 process_durations(int n)
> ^
> kernel/rcu/refperf.c:311:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> u64 process_durations(int n)
> ^
> static
> 2 warnings generated.

Good catches, fixing!

							Thanx, Paul

> vim +/reset_readers +298 kernel/rcu/refperf.c
> 
>    297	
>  > 298	void reset_readers(int n)
>    299	{
>    300		int i;
>    301		struct reader_task *rt;
>    302	
>    303		for (i = 0; i < n; i++) {
>    304			rt = &(reader_tasks[i]);
>    305	
>    306			rt->last_duration_ns = 0;
>    307		}
>    308	}
>    309	
>    310	// Print the results of each reader and return the sum of all their durations.
>  > 311	u64 process_durations(int n)
>    312	{
>    313		int i;
>    314		struct reader_task *rt;
>    315		char buf1[64];
>    316		char buf[512];
>    317		u64 sum = 0;
>    318	
>    319		buf[0] = 0;
>    320		sprintf(buf, "Experiment #%d (Format: <THREAD-NUM>:<Total loop time in ns>)",
>    321			exp_idx);
>    322	
>    323		for (i = 0; i <= n && !torture_must_stop(); i++) {
>    324			rt = &(reader_tasks[i]);
>    325			sprintf(buf1, "%d: %llu\t", i, rt->last_duration_ns);
>    326	
>    327			if (i % 5 == 0)
>    328				strcat(buf, "\n");
>    329			strcat(buf, buf1);
>    330	
>    331			sum += rt->last_duration_ns;
>    332		}
>    333		strcat(buf, "\n");
>    334	
>    335		PERFOUT("%s\n", buf);
>    336	
>    337		return sum;
>    338	}
>    339	
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [rcu:dev.2020.05.25a 51/63] kernel/rcu/refperf.c:298:6: warning: no previous prototype for function 'reset_readers'
@ 2020-05-26 16:11   ` Paul E. McKenney
  0 siblings, 0 replies; 5+ messages in thread
From: Paul E. McKenney @ 2020-05-26 16:11 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 3307 bytes --]

On Tue, May 26, 2020 at 08:07:35PM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2020.05.25a
> head:   1e9451642683146552713c5ce6d269ae378eacd5
> commit: 786a25497743696d79592b864cafbfe48787e6e1 [51/63] refperf: Add a test to measure performance of read-side synchronization
> config: x86_64-allyesconfig (attached as .config)
> compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 3393cc4cebf9969db94dc424b7a2b6195589c33b)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # install x86_64 cross compiling tool for clang build
>         # apt-get install binutils-x86-64-linux-gnu
>         git checkout 786a25497743696d79592b864cafbfe48787e6e1
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>, old ones prefixed by <<):
> 
> >> kernel/rcu/refperf.c:298:6: warning: no previous prototype for function 'reset_readers' [-Wmissing-prototypes]
> void reset_readers(int n)
> ^
> kernel/rcu/refperf.c:298:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> void reset_readers(int n)
> ^
> static
> >> kernel/rcu/refperf.c:311:5: warning: no previous prototype for function 'process_durations' [-Wmissing-prototypes]
> u64 process_durations(int n)
> ^
> kernel/rcu/refperf.c:311:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> u64 process_durations(int n)
> ^
> static
> 2 warnings generated.

Good catches, fixing!

							Thanx, Paul

> vim +/reset_readers +298 kernel/rcu/refperf.c
> 
>    297	
>  > 298	void reset_readers(int n)
>    299	{
>    300		int i;
>    301		struct reader_task *rt;
>    302	
>    303		for (i = 0; i < n; i++) {
>    304			rt = &(reader_tasks[i]);
>    305	
>    306			rt->last_duration_ns = 0;
>    307		}
>    308	}
>    309	
>    310	// Print the results of each reader and return the sum of all their durations.
>  > 311	u64 process_durations(int n)
>    312	{
>    313		int i;
>    314		struct reader_task *rt;
>    315		char buf1[64];
>    316		char buf[512];
>    317		u64 sum = 0;
>    318	
>    319		buf[0] = 0;
>    320		sprintf(buf, "Experiment #%d (Format: <THREAD-NUM>:<Total loop time in ns>)",
>    321			exp_idx);
>    322	
>    323		for (i = 0; i <= n && !torture_must_stop(); i++) {
>    324			rt = &(reader_tasks[i]);
>    325			sprintf(buf1, "%d: %llu\t", i, rt->last_duration_ns);
>    326	
>    327			if (i % 5 == 0)
>    328				strcat(buf, "\n");
>    329			strcat(buf, buf1);
>    330	
>    331			sum += rt->last_duration_ns;
>    332		}
>    333		strcat(buf, "\n");
>    334	
>    335		PERFOUT("%s\n", buf);
>    336	
>    337		return sum;
>    338	}
>    339	
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [rcu:dev.2020.05.25a 51/63] kernel/rcu/refperf.c:298:6: warning: no previous prototype for function 'reset_readers'
  2020-05-26 16:11   ` Paul E. McKenney
  (?)
@ 2020-05-26 16:29   ` Joel Fernandes
  -1 siblings, 0 replies; 5+ messages in thread
From: Joel Fernandes @ 2020-05-26 16:29 UTC (permalink / raw)
  To: Paul E. McKenney
  Cc: kbuild test robot, kbuild-all, clang-built-linux, linux-kernel

On Tue, May 26, 2020 at 09:11:17AM -0700, Paul E. McKenney wrote:
> On Tue, May 26, 2020 at 08:07:35PM +0800, kbuild test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2020.05.25a
> > head:   1e9451642683146552713c5ce6d269ae378eacd5
> > commit: 786a25497743696d79592b864cafbfe48787e6e1 [51/63] refperf: Add a test to measure performance of read-side synchronization
> > config: x86_64-allyesconfig (attached as .config)
> > compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 3393cc4cebf9969db94dc424b7a2b6195589c33b)
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # install x86_64 cross compiling tool for clang build
> >         # apt-get install binutils-x86-64-linux-gnu
> >         git checkout 786a25497743696d79592b864cafbfe48787e6e1
> >         # save the attached .config to linux build tree
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 
> > 
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kbuild test robot <lkp@intel.com>
> > 
> > All warnings (new ones prefixed by >>, old ones prefixed by <<):
> > 
> > >> kernel/rcu/refperf.c:298:6: warning: no previous prototype for function 'reset_readers' [-Wmissing-prototypes]
> > void reset_readers(int n)
> > ^
> > kernel/rcu/refperf.c:298:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> > void reset_readers(int n)
> > ^
> > static
> > >> kernel/rcu/refperf.c:311:5: warning: no previous prototype for function 'process_durations' [-Wmissing-prototypes]
> > u64 process_durations(int n)
> > ^
> > kernel/rcu/refperf.c:311:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> > u64 process_durations(int n)
> > ^
> > static
> > 2 warnings generated.
> 
> Good catches, fixing!
> 
> 							Thanx, Paul

Thanks in advance, Paul, for the fix!

 - Joel

> > vim +/reset_readers +298 kernel/rcu/refperf.c
> > 
> >    297	
> >  > 298	void reset_readers(int n)
> >    299	{
> >    300		int i;
> >    301		struct reader_task *rt;
> >    302	
> >    303		for (i = 0; i < n; i++) {
> >    304			rt = &(reader_tasks[i]);
> >    305	
> >    306			rt->last_duration_ns = 0;
> >    307		}
> >    308	}
> >    309	
> >    310	// Print the results of each reader and return the sum of all their durations.
> >  > 311	u64 process_durations(int n)
> >    312	{
> >    313		int i;
> >    314		struct reader_task *rt;
> >    315		char buf1[64];
> >    316		char buf[512];
> >    317		u64 sum = 0;
> >    318	
> >    319		buf[0] = 0;
> >    320		sprintf(buf, "Experiment #%d (Format: <THREAD-NUM>:<Total loop time in ns>)",
> >    321			exp_idx);
> >    322	
> >    323		for (i = 0; i <= n && !torture_must_stop(); i++) {
> >    324			rt = &(reader_tasks[i]);
> >    325			sprintf(buf1, "%d: %llu\t", i, rt->last_duration_ns);
> >    326	
> >    327			if (i % 5 == 0)
> >    328				strcat(buf, "\n");
> >    329			strcat(buf, buf1);
> >    330	
> >    331			sum += rt->last_duration_ns;
> >    332		}
> >    333		strcat(buf, "\n");
> >    334	
> >    335		PERFOUT("%s\n", buf);
> >    336	
> >    337		return sum;
> >    338	}
> >    339	
> > 
> > ---
> > 0-DAY CI Kernel Test Service, Intel Corporation
> > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
> 
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-05-26 16:29 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-26 12:07 [rcu:dev.2020.05.25a 51/63] kernel/rcu/refperf.c:298:6: warning: no previous prototype for function 'reset_readers' kbuild test robot
2020-05-26 12:07 ` kbuild test robot
2020-05-26 16:11 ` Paul E. McKenney
2020-05-26 16:11   ` Paul E. McKenney
2020-05-26 16:29   ` Joel Fernandes

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.