Re: [OE-core] [PATCH 6/6] perf: drop 'include' copy

From: "Martin Jansa" <Martin.Jansa@gmail.com>
To: Andrey Zhizhikin <andrey.z@gmail.com>
Cc: Bruce Ashfield <bruce.ashfield@gmail.com>,
	Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH 6/6] perf: drop 'include' copy
Date: Tue, 26 May 2020 22:44:30 +0200	[thread overview]
Message-ID: <20200526203944.czx4xbpjblwnfdgf@jama> (raw)
In-Reply-To: <CAHtQpK5bDbibVfHytO5D2ksc-=93pHuSEdYY7+GJzdXFPwGmUw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2075 bytes --]

On Tue, May 26, 2020 at 10:22:07PM +0200, Andrey Zhizhikin wrote:
> Kernel 4.4 is also LTS and has (had) a very long time span, so I
> believe there are some people out there who might still have it in
> their Products (industrial applications are pretty conservative guys).
> I have to admit that Yocto 3.1 + Kernel 4.4 is a rather strange
> combination, but it also has a valid reason to exist.
> 
> I guess reverting this patch is not really an option, but this topic
> deserves then a bit of documentation somewhere so people can look this
> up and have a quick fix for themselves. The question is: where to put
> this information?
> 
> Honestly, it didn't take me long to find the commit that solved the
> build, it took me rather long to figure out why I didn't see changes
> from it on the [dunfell]...
> 
> >
> > What exactly was the build error that you saw ?
> 
> Exactly what JaMa had and fixed with his commit, namely a multitude of:
> <bitops> error: #include nested too deeply
> 
> and some of:
> 
> <snip>/perf/1.0-r9/perf-1.0/tools/include/linux/list.h:5:10: fatal
> error: ../../../include/linux/list.h: No such file or directory

But this isn't your only issue with perf on 4.4 kernel, right?

I still carry whatever is needed in a .bbappend, for dunfell I have
also:

# The tools/lib/api in kernels older than 4.8 don't respect WERROR env
# variable exported by perf.bb
EXTRA_OEMAKE += "EXTRA_CFLAGS='-ldw -Wno-error=stringop-truncation'"

# scripting PACKAGECONFIG is now using python3, but perf in kernel
# supports python3 only with 4.17-rc1 and newer kernel (here we are
# currently using 4.4.84), see:
# http://lists.openembedded.org/pipermail/openembedded-core/2019-September/286902.html
PACKAGECONFIG_remove = "scripting"

Maybe some of it got already resolved elsewhere, this bbappend just
collects whatever tweaks are needed when it gets broken and I very
rarely have time to go back through them to re-check if it's still
needed (with newer oe-core revision or slightly newer 4.4 kernel).

Cheers,

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 201 bytes --]