From: Nick Rosbrook <rosbrookn@gmail.com>
To: George Dunlap <george.dunlap@citrix.com>
Cc: Nick Rosbrook <rosbrookn@ainfosec.com>,
xen-devel@lists.xenproject.org,
Ian Jackson <ian.jackson@citrix.com>
Subject: [PATCH v2 2/5] golang/xenlight: Get rid of GOPATH-based build artefacts
Date: Tue, 26 May 2020 19:57:35 -0400 [thread overview]
Message-ID: <20200526235735.GA2978@six> (raw)
In-Reply-To: <20200526221612.900922-3-george.dunlap@citrix.com>
> diff --git a/tools/golang/xenlight/Makefile b/tools/golang/xenlight/Makefile
> index 8ab4cb5665..f8d8047524 100644
> --- a/tools/golang/xenlight/Makefile
> +++ b/tools/golang/xenlight/Makefile
> @@ -14,17 +14,8 @@ LIBXL_SRC_DIR = ../../libxl
> .PHONY: all
> all: build
>
> -.PHONY: package
> -package: $(XEN_GOPATH)$(GOXL_PKG_DIR)
> -
> GOXL_GEN_FILES = types.gen.go helpers.gen.go
>
> -$(XEN_GOPATH)/src/$(XEN_GOCODE_URL)/xenlight/: xenlight.go $(GOXL_GEN_FILES)
> - $(INSTALL_DIR) $(XEN_GOPATH)$(GOXL_PKG_DIR)
> - $(INSTALL_DATA) xenlight.go $(XEN_GOPATH)$(GOXL_PKG_DIR)
> - $(INSTALL_DATA) types.gen.go $(XEN_GOPATH)$(GOXL_PKG_DIR)
> - $(INSTALL_DATA) helpers.gen.go $(XEN_GOPATH)$(GOXL_PKG_DIR)
> -
I think the GOXL_PKG_DIR variable can be removed all together too. With
these changes it's only used to initialize GOXL_INSTALL_DIR.
-NR
next prev parent reply other threads:[~2020-05-26 23:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 22:16 [PATCH v2 0/5] Golang build fixes / improvements George Dunlap
2020-05-26 22:16 ` [PATCH v2 1/5] libxl: Generate golang bindings in libxl Makefile George Dunlap
2020-06-04 16:40 ` George Dunlap
2020-06-04 18:29 ` Nick Rosbrook
2020-06-08 9:54 ` George Dunlap
2020-06-08 14:10 ` Nick Rosbrook
2020-06-08 11:16 ` Ian Jackson
2020-06-08 11:48 ` George Dunlap
2020-05-26 22:16 ` [PATCH v2 2/5] golang/xenlight: Get rid of GOPATH-based build artefacts George Dunlap
2020-05-26 23:57 ` Nick Rosbrook [this message]
2020-05-27 0:03 ` Nick Rosbrook
2020-05-26 22:16 ` [PATCH v2 3/5] automation/archlinux: Add 32-bit glibc headers George Dunlap
2020-05-27 10:43 ` Anthony PERARD
2020-05-27 11:29 ` Wei Liu
2020-05-28 11:32 ` George Dunlap
2020-05-29 16:37 ` Anthony PERARD
2020-05-26 22:16 ` [PATCH v2 4/5] automation: Add golang packages to various dockerfiles George Dunlap
2020-05-26 22:16 ` [PATCH v2 5/5] automation/containerize: Add a shortcut for Debian unstable George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526235735.GA2978@six \
--to=rosbrookn@gmail.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=rosbrookn@ainfosec.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.