All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ivecera@redhat.com
Cc: dcaratti@redhat.com, netdev@vger.kernel.org,
	tahiliani@nitk.edu.in, jhs@mojatatu.com
Subject: Re: [PATCH net] net/sched: fix infinite loop in sch_fq_pie
Date: Wed, 27 May 2020 11:12:11 -0700 (PDT)	[thread overview]
Message-ID: <20200527.111211.1980078971767456943.davem@davemloft.net> (raw)
In-Reply-To: <20200527092451.5ae03435@ceranb>

From: Ivan Vecera <ivecera@redhat.com>
Date: Wed, 27 May 2020 09:24:51 +0200

> On Wed, 27 May 2020 02:04:26 +0200
> Davide Caratti <dcaratti@redhat.com> wrote:
> 
>> this command hangs forever:
>> 
>>  # tc qdisc add dev eth0 root fq_pie flows 65536
>> 
>>  watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [tc:1028]
 ...
>> 
>> we can't accept 65536 as a valid number for 'nflows', because the loop on
>> 'idx' in fq_pie_init() will never end. The extack message is correct, but
>> it doesn't say that 0 is not a valid number for 'flows': while at it, fix
>> this also. Add a tdc selftest to check correct validation of 'flows'.
>> 
>> CC: Ivan Vecera <ivecera@redhat.com>
>> Fixes: ec97ecf1ebe4 ("net: sched: add Flow Queue PIE packet scheduler")
>> Signed-off-by: Davide Caratti <dcaratti@redhat.com>
 ...
> Good catch, Davide.
> 
> Reviewed-by: Ivan Vecera <ivecera@redhat.com>

Applied and queued up for v5.6 -stable, thanks.

      reply	other threads:[~2020-05-27 18:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-27  0:04 [PATCH net] net/sched: fix infinite loop in sch_fq_pie Davide Caratti
2020-05-27  7:24 ` Ivan Vecera
2020-05-27 18:12   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200527.111211.1980078971767456943.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dcaratti@redhat.com \
    --cc=ivecera@redhat.com \
    --cc=jhs@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    --cc=tahiliani@nitk.edu.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.