From: David Miller <davem@davemloft.net>
To: simon.horman@netronome.com
Cc: jakub.kicinski@netronome.com, netdev@vger.kernel.org,
oss-drivers@netronome.com, heinrich.kuhn@netronome.com
Subject: Re: [PATCH net] nfp: flower: fix used time of merge flow statistics
Date: Wed, 27 May 2020 11:19:38 -0700 (PDT) [thread overview]
Message-ID: <20200527.111938.1919025199084337813.davem@davemloft.net> (raw)
In-Reply-To: <20200527074420.11232-1-simon.horman@netronome.com>
From: Simon Horman <simon.horman@netronome.com>
Date: Wed, 27 May 2020 09:44:20 +0200
> From: Heinrich Kuhn <heinrich.kuhn@netronome.com>
>
> Prior to this change the correct value for the used counter is calculated
> but not stored nor, therefore, propagated to user-space. In use-cases such
> as OVS use-case at least this results in active flows being removed from
> the hardware datapath. Which results in both unnecessary flow tear-down
> and setup, and packet processing on the host.
>
> This patch addresses the problem by saving the calculated used value
> which allows the value to propagate to user-space.
>
> Found by inspection.
>
> Fixes: aa6ce2ea0c93 ("nfp: flower: support stats update for merge flows")
> Signed-off-by: Heinrich Kuhn <heinrich.kuhn@netronome.com>
> Signed-off-by: Simon Horman <simon.horman@netronome.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2020-05-27 18:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 7:44 [PATCH net] nfp: flower: fix used time of merge flow statistics Simon Horman
2020-05-27 18:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527.111938.1919025199084337813.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=heinrich.kuhn@netronome.com \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.