From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FB48C433DF for ; Wed, 27 May 2020 00:37:11 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41E542071A for ; Wed, 27 May 2020 00:37:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LZg1q6gv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41E542071A Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-audit-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590539830; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=m1LUXoxvIWbISkMuFOXD7kkNpGVhOm6RqLDpb6EZn+E=; b=LZg1q6gv9GRB9vRfX6Ec/frM6WjX/GxrxTF7nRz4jkcUrkT9CXAiaCfWUQZPVCgE/5Wu4w ucyA9nzn8863Btt6asQIoN8CZW58t+tmnF0UjIEOkW9cjKljyJi2BwEpjkXNJdIj6U+bnJ /IkGFgY3Z+nSlU8ELu3SLbMhbGHXWXA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-18-S6ni3erVOIWlSERIfv9scA-1; Tue, 26 May 2020 20:37:06 -0400 X-MC-Unique: S6ni3erVOIWlSERIfv9scA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CFCBE18A0762; Wed, 27 May 2020 00:37:00 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 812B85D9E7; Wed, 27 May 2020 00:36:59 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 07CEC1809543; Wed, 27 May 2020 00:36:57 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 04R0atsR026879 for ; Tue, 26 May 2020 20:36:55 -0400 Received: by smtp.corp.redhat.com (Postfix) id 2DF6479C38; Wed, 27 May 2020 00:36:55 +0000 (UTC) Received: from shell-el7.hosts.prod.upshift.rdu2.redhat.com (shell-el7.hosts.prod.upshift.rdu2.redhat.com [10.0.15.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5ACAB79C2C; Wed, 27 May 2020 00:36:52 +0000 (UTC) Received: by shell-el7.hosts.prod.upshift.rdu2.redhat.com (Postfix, from userid 2518) id 46B4C600D26D; Wed, 27 May 2020 00:36:51 +0000 (UTC) Date: Wed, 27 May 2020 00:36:51 +0000 From: Alexander Viro To: Paul Moore Subject: Re: [RFC] audit: allow audit_reusename to check kernel path Message-ID: <20200527003651.GA97661@shell-el7.hosts.prod.upshift.rdu2.redhat.com> References: <1590391317-71528-1-git-send-email-guyiwen@huawei.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: linux-audit@redhat.com Cc: linux-audit@redhat.com X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline On Tue, May 26, 2020 at 08:32:06AM -0400, Paul Moore wrote: > On Mon, May 25, 2020 at 3:22 AM Yiwen Gu wrote: > > For now, we met a situation where the audit_reusename checking > > function returns the same filename structure for files sharing > > the same uptr. However, these files are different, and we are trying > > to open them in a loop where the names are loaded into the same address. > > Therefore, the function returns the same structure for different files. > > By the way, may I ask in what situation would the audit_list be kept > > across syscalls? Never. "reuse" is strictly within the same syscall, so e.g. -ESTALE retry logics doesn't have to worry about extra instances of struct filename. > What kernel are you using? Is this an Android kernel? > > Do you have a reproducer you can share? -- Linux-audit mailing list Linux-audit@redhat.com https://www.redhat.com/mailman/listinfo/linux-audit