From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97C73C433E0 for ; Wed, 27 May 2020 04:06:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 76C692078C for ; Wed, 27 May 2020 04:06:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WdYG8D0J" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725385AbgE0EGE (ORCPT ); Wed, 27 May 2020 00:06:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727787AbgE0EGE (ORCPT ); Wed, 27 May 2020 00:06:04 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE472C03E97B for ; Tue, 26 May 2020 21:06:03 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id q8so11256618pfu.5 for ; Tue, 26 May 2020 21:06:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=c7mmaWIhliSekrXxz20ZW1Ppbz2gcfDYDdhA8q0rEGw=; b=WdYG8D0JMfocNaSyB3kzR5gMVArCgT76OxP6MQ+pOzljOaoPmsxhznQi5FqWaStJFl lmTeWzYx5wPIgZAgg5ZFh1BQ4Yr9gqWGLEB7F4urpZ1Jnzq7IObLbhJNfUvMvWly+R+k uIzi49ZKS2aYnGejb8FjLfdye2J/j+BkLJZxdG64a0ETBYOjwhc09VIKUQESULFfdTCK G9S93Jd404+Mqzi2cpaNktkrpkuj2pKavzR+KPzN5uwVxxzBN/r8yWL1muX8SJ/54zJo H+yIYntYyYAwe+XkogvmXQcO5urNUSM7I1UFZ2l/b9ZS8OSJNlY6yxsp8jByejOISnvi ofqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=c7mmaWIhliSekrXxz20ZW1Ppbz2gcfDYDdhA8q0rEGw=; b=gaZ/qD4xMJtDlZp8lrAQ1bepJOhLNmyfYMYRiHoGyNZ468xZxmacLcfUYZ48hvMctf l2MgAeragAMLQqcHmTG4Hoz1ldOLRYqHGzcffmvhaC7HnKIuyux/4Y5J1yI8As3gNO9G heK/4gMosC75CRUAaj2f/AThl27MbIEBWIbw+Q6uGQTagOxkYQOEpdBXHM+QeM446g/l W0QMVVxNnxr5OIWdzR92bj0caHnwNUwyNbsMLIIbwShdlVZPkyyvjl59WXpaWBFsbqzX G505J0nVYNvZv7F7O9niRZ6s2cCRgnEFUyi2WqPQz5QszSyivvQA3/foO8D+IXL5cSZX FNqw== X-Gm-Message-State: AOAM5314JF2Ib4rLN3yCog8AyNX9nLVXNyr4DsscyZYhDVBxc0rHH8lB IhvNSmqMAw3A3Rjk/ItrlLWo0Q== X-Google-Smtp-Source: ABdhPJzopaTwRs6857IVLls5+Ux3GcVORnkKoE0IaW4/vMYy76PnhRsBBvhJDfafZnmxdp601/HxaA== X-Received: by 2002:a63:8f46:: with SMTP id r6mr2123412pgn.257.1590552363359; Tue, 26 May 2020 21:06:03 -0700 (PDT) Received: from localhost ([122.172.60.59]) by smtp.gmail.com with ESMTPSA id m2sm798738pfe.141.2020.05.26.21.06.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 May 2020 21:06:01 -0700 (PDT) Date: Wed, 27 May 2020 09:35:59 +0530 From: Viresh Kumar To: Sibi Sankar Cc: sboyd@kernel.org, georgi.djakov@linaro.org, bjorn.andersson@linaro.org, saravanak@google.com, mka@chromium.org, nm@ti.com, agross@kernel.org, david.brown@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, rjw@rjwysocki.net, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, dianders@chromium.org, vincent.guittot@linaro.org, amit.kucheria@linaro.org, ulf.hansson@linaro.org, lukasz.luba@arm.com, sudeep.holla@arm.com Subject: Re: [PATCH v4 06/12] cpufreq: qcom: Update the bandwidth levels on frequency change Message-ID: <20200527040559.5dryuxbf5ejzvpst@vireshk-i7> References: <20200504202243.5476-1-sibis@codeaurora.org> <20200504202243.5476-7-sibis@codeaurora.org> <20200505045012.zfx2e6chqo5f3e4n@vireshk-i7> <8fc5b72c9af6fd6a707a280cfc678677@codeaurora.org> <20200527035349.mrvvxeg3lqv53jm2@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200527035349.mrvvxeg3lqv53jm2@vireshk-i7> User-Agent: NeoMutt/20180716-391-311a52 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 27-05-20, 09:23, Viresh Kumar wrote: > On 26-05-20, 23:18, Sibi Sankar wrote: > > https://patchwork.kernel.org/cover/11548479/ > > GPU driver uses Georgi's series > > for scaling and will need a way to > > remove the icc votes in the suspend > > path, (this looks like a pattern > > that might be used by other clients > > as well) I could probably update > > opp_set_bw to support removing bw > > when NULL opp is specified. Similarly > > opp_set_rate will need to support > > set bw to 0 when set_rate is passed > > 0 as target freq for the same use case. > > Sure, please send a patch for that. On a second thought, here is the patch. Please test it. -------------------------8<------------------------- Subject: [PATCH] opp: Remove bandwidth votes when target_freq is zero We already drop several votes when target_freq is set to zero, drop bandwidth votes as well. Reported-by: Sibi Sankar Signed-off-by: Viresh Kumar --- drivers/opp/core.c | 47 +++++++++++++++++++++++++++++++++++----------- 1 file changed, 36 insertions(+), 11 deletions(-) diff --git a/drivers/opp/core.c b/drivers/opp/core.c index 56d3022c1ca2..0c259d5ed232 100644 --- a/drivers/opp/core.c +++ b/drivers/opp/core.c @@ -725,6 +725,34 @@ static int _generic_set_opp_regulator(struct opp_table *opp_table, return ret; } +static int _set_opp_bw(const struct opp_table *opp_table, + struct dev_pm_opp *opp, bool remove) +{ + u32 avg, peak; + int i, ret; + + if (!opp_table->paths) + return 0; + + for (i = 0; i < opp_table->path_count; i++) { + if (remove) { + avg = 0; + peak = 0; + } else { + avg = opp->bandwidth[i].avg; + peak = opp->bandwidth[i].peak; + } + ret = icc_set_bw(opp_table->paths[i], avg, peak); + if (ret) { + dev_err(dev, "Failed to %s bandwidth[%d]: %d\n", + remove ? "remove" : "set", i, ret); + retrun ret; + } + } + + return 0; +} + static int _set_opp_custom(const struct opp_table *opp_table, struct device *dev, unsigned long old_freq, unsigned long freq, @@ -837,12 +865,17 @@ int dev_pm_opp_set_rate(struct device *dev, unsigned long target_freq) if (!_get_opp_count(opp_table)) return 0; - if (!opp_table->required_opp_tables && !opp_table->regulators) { + if (!opp_table->required_opp_tables && !opp_table->regulators && + !opp_table->paths) { dev_err(dev, "target frequency can't be 0\n"); ret = -EINVAL; goto put_opp_table; } + ret = _set_opp_bw(opp_table, opp, true); + if (ret) + return ret; + if (opp_table->regulator_enabled) { regulator_disable(opp_table->regulators[0]); opp_table->regulator_enabled = false; @@ -932,16 +965,8 @@ int dev_pm_opp_set_rate(struct device *dev, unsigned long target_freq) dev_err(dev, "Failed to set required opps: %d\n", ret); } - if (!ret && opp_table->paths) { - for (i = 0; i < opp_table->path_count; i++) { - ret = icc_set_bw(opp_table->paths[i], - opp->bandwidth[i].avg, - opp->bandwidth[i].peak); - if (ret) - dev_err(dev, "Failed to set bandwidth[%d]: %d\n", - i, ret); - } - } + if (!ret) + ret = _set_opp_bw(opp_table, opp, false); put_opp: dev_pm_opp_put(opp);