From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E74CDC433E0 for ; Wed, 27 May 2020 08:45:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE8CF206F1 for ; Wed, 27 May 2020 08:45:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590569132; bh=PrG/wfJu4GEzoVBNL3trG0nXymQ/KbtrGBqZcfWWGJM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=KpKdo7vggH+WTXfITVNQX3dr/Uhyo128L1+BjrFp2uXLFj0s2ZsgdvtCyT5WtTNH7 2qO2+0Dw6kypbFRjKjXAXeJBlWeSNuK8vC6fnzq/HbBxvdGl5IAwlwUQ0G0MuVJafK WrkFJmhzCQFWXgzWUpG5E29YjTwffr0HmjmAg2Fw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388265AbgE0Ipb (ORCPT ); Wed, 27 May 2020 04:45:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:47210 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388173AbgE0Ipb (ORCPT ); Wed, 27 May 2020 04:45:31 -0400 Received: from coco.lan (ip5f5ad5c5.dynamic.kabel-deutschland.de [95.90.213.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7BE9B206F1; Wed, 27 May 2020 08:45:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590569131; bh=PrG/wfJu4GEzoVBNL3trG0nXymQ/KbtrGBqZcfWWGJM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BvL3nr0Ex/WOcfNQO+m9Hf/cDDlHB6UM5pSo9kdsQQ/tfXKsxQD5kzMpuLULjIggT UL70kpSxHZgA5Ql5+svLuJJTBouUiGKTB1hZI67qgzqBdjb5XxJYjifNBRd/fZpfxT AhSj2kgf6cum4OsW63T6q7scRbNv8XGLZA+GsDdI= Date: Wed, 27 May 2020 10:45:25 +0200 From: Mauro Carvalho Chehab To: Nathan Chancellor Cc: Sakari Ailus , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH 0/7] media: atomisp: Address several clang warnings Message-ID: <20200527104525.5e6cd93b@coco.lan> In-Reply-To: <20200527071150.3381228-1-natechancellor@gmail.com> References: <20200527071150.3381228-1-natechancellor@gmail.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, 27 May 2020 00:11:43 -0700 Nathan Chancellor escreveu: > Hi all, > > This series aims to clean up the code while addressing the majority of > clang warnings in this driver, some found by the 0day bot and others > found by me. > > There are several enum conversion warnings that happen, which I do not > really know how to solve without understanding how exactly this driver > works. I would appreciate some guidance or a solution. Below are the > warnings, sorry for not wrapping them but they would be hard to read > otherwise. ... > ../drivers/staging/media/atomisp//pci/atomisp_compat_css20.h:117:22: note: expanded from macro 'CSS_ID' > #define CSS_ID(val) (IA_ ## val) ... I actually wrote a patch getting rid of this ugly thing: https://git.linuxtv.org/mchehab/experimental.git/commit/?h=atomisp_v3&id=cf6a15543ace1e99364911c0b7a2f6b8f2f43021 This one was already submitted upstream (not merged yet), but there are also lots of other patches on my working tree. I'll try to apply your patch series on it, once I'll be able to fix a bug with mmap support. Thanks, Mauro From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35674C433E0 for ; Wed, 27 May 2020 08:45:36 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A414206F1 for ; Wed, 27 May 2020 08:45:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="BvL3nr0E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A414206F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id C384C2313B; Wed, 27 May 2020 08:45:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yD7Pa5AmeXQX; Wed, 27 May 2020 08:45:34 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 222C1231CB; Wed, 27 May 2020 08:45:34 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 243CC1BF844 for ; Wed, 27 May 2020 08:45:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 2009387D6D for ; Wed, 27 May 2020 08:45:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B+ZS6UVybpTS for ; Wed, 27 May 2020 08:45:31 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by whitealder.osuosl.org (Postfix) with ESMTPS id 4040E87D69 for ; Wed, 27 May 2020 08:45:31 +0000 (UTC) Received: from coco.lan (ip5f5ad5c5.dynamic.kabel-deutschland.de [95.90.213.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7BE9B206F1; Wed, 27 May 2020 08:45:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590569131; bh=PrG/wfJu4GEzoVBNL3trG0nXymQ/KbtrGBqZcfWWGJM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BvL3nr0Ex/WOcfNQO+m9Hf/cDDlHB6UM5pSo9kdsQQ/tfXKsxQD5kzMpuLULjIggT UL70kpSxHZgA5Ql5+svLuJJTBouUiGKTB1hZI67qgzqBdjb5XxJYjifNBRd/fZpfxT AhSj2kgf6cum4OsW63T6q7scRbNv8XGLZA+GsDdI= Date: Wed, 27 May 2020 10:45:25 +0200 From: Mauro Carvalho Chehab To: Nathan Chancellor Subject: Re: [PATCH 0/7] media: atomisp: Address several clang warnings Message-ID: <20200527104525.5e6cd93b@coco.lan> In-Reply-To: <20200527071150.3381228-1-natechancellor@gmail.com> References: <20200527071150.3381228-1-natechancellor@gmail.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org, Sakari Ailus , linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Em Wed, 27 May 2020 00:11:43 -0700 Nathan Chancellor escreveu: > Hi all, > > This series aims to clean up the code while addressing the majority of > clang warnings in this driver, some found by the 0day bot and others > found by me. > > There are several enum conversion warnings that happen, which I do not > really know how to solve without understanding how exactly this driver > works. I would appreciate some guidance or a solution. Below are the > warnings, sorry for not wrapping them but they would be hard to read > otherwise. ... > ../drivers/staging/media/atomisp//pci/atomisp_compat_css20.h:117:22: note: expanded from macro 'CSS_ID' > #define CSS_ID(val) (IA_ ## val) ... I actually wrote a patch getting rid of this ugly thing: https://git.linuxtv.org/mchehab/experimental.git/commit/?h=atomisp_v3&id=cf6a15543ace1e99364911c0b7a2f6b8f2f43021 This one was already submitted upstream (not merged yet), but there are also lots of other patches on my working tree. I'll try to apply your patch series on it, once I'll be able to fix a bug with mmap support. Thanks, Mauro _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel