* [PATCH] statx: remove redundant assignment to variable error
@ 2020-05-27 13:45 ` Colin King
0 siblings, 0 replies; 2+ messages in thread
From: Colin King @ 2020-05-27 13:45 UTC (permalink / raw)
To: Alexander Viro, linux-fsdevel; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable error is being initialized with a value that is never read
and it is being updated later with a new value. The initialization is
redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
fs/stat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/stat.c b/fs/stat.c
index 3213d1b2750e..d0d5b8cbe4b2 100644
--- a/fs/stat.c
+++ b/fs/stat.c
@@ -192,7 +192,7 @@ int vfs_statx(int dfd, const char __user *filename, int flags,
struct kstat *stat, u32 request_mask)
{
struct path path;
- int error = -EINVAL;
+ int error;
unsigned lookup_flags;
if (vfs_stat_set_lookup_flags(&lookup_flags, flags))
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] statx: remove redundant assignment to variable error
@ 2020-05-27 13:45 ` Colin King
0 siblings, 0 replies; 2+ messages in thread
From: Colin King @ 2020-05-27 13:45 UTC (permalink / raw)
To: Alexander Viro, linux-fsdevel; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable error is being initialized with a value that is never read
and it is being updated later with a new value. The initialization is
redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
fs/stat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/stat.c b/fs/stat.c
index 3213d1b2750e..d0d5b8cbe4b2 100644
--- a/fs/stat.c
+++ b/fs/stat.c
@@ -192,7 +192,7 @@ int vfs_statx(int dfd, const char __user *filename, int flags,
struct kstat *stat, u32 request_mask)
{
struct path path;
- int error = -EINVAL;
+ int error;
unsigned lookup_flags;
if (vfs_stat_set_lookup_flags(&lookup_flags, flags))
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-27 13:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-27 13:45 [PATCH] statx: remove redundant assignment to variable error Colin King
2020-05-27 13:45 ` Colin King
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.