All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Muhammad Bilal <m.bilal@emumba.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] Which tests are compulsory to PASS for Patch to be accepted
Date: Wed, 27 May 2020 13:59:14 -0700	[thread overview]
Message-ID: <20200527135914.05e624ff@hermes.lan> (raw)
In-Reply-To: <CAOFC0T2O+xoRO+Jaf_ocq=ifhwcaA_jrkhkweuttiRn=Y3xSdA@mail.gmail.com>

On Thu, 28 May 2020 01:13:27 +0500
Muhammad Bilal <m.bilal@emumba.com> wrote:

> Recently I have submitted patches and some tests were failing on patchwork.
> My question is, which tests are compulsory to pass for a patch to be accepted.
> As in the below mentioned patch, it is accepted while 1 test was still failing.
> http://patches.dpdk.org/patch/70348/
> 
> kind regards.
> Muhammad Bilal

There are two different issues:
  1. A patch should not get blamed for some failure in the CI infrastructure.
     Or collataral damage from an earlier merge.
  2. A patch must not introduce a failure. I.e. if all tests passed before
     each patch in a patchset must pass.

  reply	other threads:[~2020-05-27 20:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-27 20:13 [dpdk-dev] Which tests are compulsory to PASS for Patch to be accepted Muhammad Bilal
2020-05-27 20:59 ` Stephen Hemminger [this message]
2020-06-02 11:42   ` Muhammad Bilal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200527135914.05e624ff@hermes.lan \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=m.bilal@emumba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.