From: Martin KaFai Lau <kafai@fb.com>
To: Dmitry Yakunin <zeil@yandex-team.ru>
Cc: <davem@davemloft.net>, <brakmo@fb.com>, <bpf@vger.kernel.org>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH bpf-next] bpf: add SO_KEEPALIVE and related options to bpf_setsockopt
Date: Wed, 27 May 2020 10:02:21 -0700 [thread overview]
Message-ID: <20200527170221.iutwmch6sim35bkt@kafai-mbp> (raw)
In-Reply-To: <20200527150543.93335-1-zeil@yandex-team.ru>
On Wed, May 27, 2020 at 06:05:43PM +0300, Dmitry Yakunin wrote:
> This patch adds support of SO_KEEPALIVE flag and TCP related options
> to bpf_setsockopt() routine. This is helpful if we want to enable or tune
> TCP keepalive for applications which don't do it in the userspace code.
> In order to avoid copy-paste, common code from classic setsockopt was moved
> to auxiliary functions in the headers.
Thanks for refatoring some of the pieces. I suspect some more can be done.
In the long run, I don't think this copy-and-paste is scalable.
For most of the options (integer value and do not need ns_capable()),
do_tcp_setsockopt() and sock_setsockopt() can be directly called with
some refactoring.
The change looks good. For this patch,
Acked-by: Martin KaFai Lau <kafai@fb.com>
next prev parent reply other threads:[~2020-05-27 17:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 15:05 [PATCH bpf-next] bpf: add SO_KEEPALIVE and related options to bpf_setsockopt Dmitry Yakunin
2020-05-27 16:42 ` Eric Dumazet
2020-05-27 20:17 ` Dmitry Yakunin
2020-05-29 12:41 ` David Laight
2020-05-27 17:02 ` Martin KaFai Lau [this message]
2020-05-27 20:44 ` Dmitry Yakunin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527170221.iutwmch6sim35bkt@kafai-mbp \
--to=kafai@fb.com \
--cc=bpf@vger.kernel.org \
--cc=brakmo@fb.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=zeil@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.