All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: u-boot@lists.denx.de
Subject: [PATCH 2/4] trace: clang compatible handling of gd register
Date: Wed, 27 May 2020 20:04:22 +0200	[thread overview]
Message-ID: <20200527180424.39395-3-xypron.glpk@gmx.de> (raw)
In-Reply-To: <20200527180424.39395-1-xypron.glpk@gmx.de>

On ARM systems gd is stored in register r9 or x18. When compiling with
clang gd is defined as a macro calling function gd_ptr(). So we can not
make assignments to gd.

Use function set_gd() for setting the register on ARM.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 lib/trace.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/trace.c b/lib/trace.c
index ea8c8e0d40..831283c283 100644
--- a/lib/trace.c
+++ b/lib/trace.c
@@ -57,12 +57,12 @@ static inline uintptr_t __attribute__((no_instrument_function))
 	return offset / FUNC_SITE_SIZE;
 }

-#ifdef CONFIG_EFI_LOADER
+#if defined(CONFIG_EFI_LOADER) && defined(CONFIG_ARM)

 /**
  * trace_gd - the value of the gd register
  */
-static volatile void *trace_gd;
+static volatile gd_t *trace_gd;

 /**
  * trace_save_gd() - save the value of the gd register
@@ -82,10 +82,10 @@ static void __attribute__((no_instrument_function)) trace_save_gd(void)
  */
 static void __attribute__((no_instrument_function)) trace_swap_gd(void)
 {
-	volatile void *temp_gd = trace_gd;
+	volatile gd_t *temp_gd = trace_gd;

 	trace_gd = gd;
-	gd = temp_gd;
+	set_gd(temp_gd);
 }

 #else
--
2.26.2

  parent reply	other threads:[~2020-05-27 18:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-27 18:04 [PATCH 0/4] arm: fix clang build errors Heinrich Schuchardt
2020-05-27 18:04 ` [PATCH 1/4] efi_loader: allow compiling with clang Heinrich Schuchardt
2020-05-31 14:08   ` Simon Glass
2020-05-27 18:04 ` Heinrich Schuchardt [this message]
2020-05-31 14:08   ` [PATCH 2/4] trace: clang compatible handling of gd register Simon Glass
2020-07-08  3:03   ` Tom Rini
2020-05-27 18:04 ` [PATCH 3/4] arm: remove outdated comment concerning -ffixed-x18 Heinrich Schuchardt
2020-05-31 14:08   ` Simon Glass
2020-07-08  3:03   ` Tom Rini
2020-05-27 18:04 ` [PATCH 4/4] arm: use correct argument size of special registers Heinrich Schuchardt
2020-07-08  3:03   ` Tom Rini
2020-06-14 15:51 ` [PATCH 0/4] arm: fix clang build errors Heinrich Schuchardt
2020-06-14 15:59   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200527180424.39395-3-xypron.glpk@gmx.de \
    --to=xypron.glpk@gmx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.