From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73286C433DF for ; Wed, 27 May 2020 18:59:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 52C2F2073B for ; Wed, 27 May 2020 18:59:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DFl0fF7d" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729098AbgE0S7K (ORCPT ); Wed, 27 May 2020 14:59:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728564AbgE0S5h (ORCPT ); Wed, 27 May 2020 14:57:37 -0400 Received: from mail-ot1-x344.google.com (mail-ot1-x344.google.com [IPv6:2607:f8b0:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3921DC08C5C1; Wed, 27 May 2020 11:57:37 -0700 (PDT) Received: by mail-ot1-x344.google.com with SMTP id x22so415352otq.4; Wed, 27 May 2020 11:57:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eW6ryn1rOfnt2FF7cISQz6U787vY1TgBbRYE31eh+Uw=; b=DFl0fF7dcBxB5zqV1ix3II/kS7GQWkr6h7MlBOIRyyX9w/lmsBDVqgZKwMtq0L4M9H JTBc6t/jarulee9eP3RPJKMS2NvII2IvXAT0SjYl2xUHexw2iLgQZVQwSUPKlmY5/tYu blnENDtu+hHIbyK+fWHgVFD2xWYKMl0dQlHidD4j3U3cRAYEdixqEZsEMbCUaOiO6Iem AaZO+xMLT7bai9YdpZ8wEx6wvizd+XffPHmevaIB/n/EpgKdqo1WI7hkfxe32wVQeBOf UFz9ZFZlvdfXGql8cPsqCC4q63jmWoSjd5QqXTYzEdiKuCUTHUkLidSnDhGYt0Y9Sh8U cFrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eW6ryn1rOfnt2FF7cISQz6U787vY1TgBbRYE31eh+Uw=; b=LZ78mXkLqXZvW1PqKUgBHFUBx/MvKDMDC4Qm9+ZhiYzssPBbfTBtDjIcty0DZmQ4pE fwx3iv4/de8yBOM7vACUzK8dUpM4N18JXTja1kx6QoBxniGDbaVfPx2xxnn+nAGC5l0/ O7HGgHMs9+e8qxKifvWdb8ZIGqBCS/+c1LyN5tINW0NwHolCgOEZkT0DDhe8mBE290dE an/y7bna+GcgWiCD2W6oouxANX02/mWi+WyntD3LU3UFnPJAqbvH47BB/QP1RNIr8+sV nNONuh416mdRNz8am9nusoLfbskgpXKHdljr0VNzzapkRvYxzhhhB1ycXCwFOVTvQjse Hj3A== X-Gm-Message-State: AOAM533pk8tM+prv1mkdjWCfJdlIhLUUe9xkeZrSr/m9pl2u6Wp9+V3m A+zDVORpW/IAUrKgJZ9cN2s= X-Google-Smtp-Source: ABdhPJy0KJw3sf9zmT1G+HDG+6Q0TCF/0gOW2ku15pcSyJcP5yU5cr/zlnwmgb0j4Gon70V/ZXqnNw== X-Received: by 2002:a9d:4807:: with SMTP id c7mr5327778otf.279.1590605856664; Wed, 27 May 2020 11:57:36 -0700 (PDT) Received: from localhost.members.linode.com ([2600:3c00::f03c:92ff:fe3e:1759]) by smtp.gmail.com with ESMTPSA id i127sm1074596oih.38.2020.05.27.11.57.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2020 11:57:35 -0700 (PDT) From: Anton Protopopov To: Alexei Starovoitov , Daniel Borkmann , Shuah Khan Cc: Anton Protopopov , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH bpf 2/5] selftests/bpf: cleanup some file descriptors in test_maps Date: Wed, 27 May 2020 18:56:57 +0000 Message-Id: <20200527185700.14658-3-a.s.protopopov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200527185700.14658-2-a.s.protopopov@gmail.com> References: <20200527185700.14658-1-a.s.protopopov@gmail.com> <20200527185700.14658-2-a.s.protopopov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The test_map_rdonly and test_map_wronly tests should close file descriptors which they open. Signed-off-by: Anton Protopopov --- tools/testing/selftests/bpf/test_maps.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/testing/selftests/bpf/test_maps.c b/tools/testing/selftests/bpf/test_maps.c index f717acc0c68d..46cf2c232964 100644 --- a/tools/testing/selftests/bpf/test_maps.c +++ b/tools/testing/selftests/bpf/test_maps.c @@ -1401,6 +1401,8 @@ static void test_map_rdonly(void) /* Check that key=2 is not found. */ assert(bpf_map_lookup_elem(fd, &key, &value) == -1 && errno == ENOENT); assert(bpf_map_get_next_key(fd, &key, &value) == -1 && errno == ENOENT); + + close(fd); } static void test_map_wronly(void) @@ -1423,6 +1425,8 @@ static void test_map_wronly(void) /* Check that key=2 is not found. */ assert(bpf_map_lookup_elem(fd, &key, &value) == -1 && errno == EPERM); assert(bpf_map_get_next_key(fd, &key, &value) == -1 && errno == EPERM); + + close(fd); } static void prepare_reuseport_grp(int type, int map_fd, size_t map_elem_size, -- 2.20.1