From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F701C433E0 for ; Wed, 27 May 2020 19:36:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5FDD42078B for ; Wed, 27 May 2020 19:36:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590608203; bh=20ngQY8drqqEd7Q0YdanKFN2w4zrcB73OEFdthzGpOk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=PCZNlSjx7dtpFU6h9vTqkGAEJfXrSzm2pnV/P6d184a8WQ65gunTVxPu7osC13917 pBoszmUt/ikJG1qOHgw3ZyXm3FyNaVHyfmCKzM0g8EIDf8eQr/JzFI2221nwu9FMd5 MIHjgT8GmCQCVfurDLXjzHXPaWNtun5tdvq7uyiA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726938AbgE0Tgn (ORCPT ); Wed, 27 May 2020 15:36:43 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:38226 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725872AbgE0Tgm (ORCPT ); Wed, 27 May 2020 15:36:42 -0400 Received: by mail-io1-f67.google.com with SMTP id d7so27457174ioq.5; Wed, 27 May 2020 12:36:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=io7JL+6QWqwr5UMM9NElEX66dtm9kKXNvmpsHXQSLm8=; b=l2gERoQnmyqHY8g+/VuMbG3/10li/MIaPvO/8px7BVVZWCEVDOBlMF2pEVD74TODpG qGbW+IvIXcikiqr39TrQOrpGpBPF2BTBYp07rnWDuDG99Q1ufjf4A7OyR9slT68I6zb+ 92HFVPP6kBot1Uh9xVuyLy7HGra6HpUv7XD2Dw9O0rLPSU71GCS4BuFUMQ0YAl0Db6LM 6QDC4M7sZFaMueMEJVVLWxIBHKrkhmQR2SHLAq4Lj+2jGNh7qazKcApN65MtgO6vKQlB fjemnw+Cg/f4NJD9Cx0qqkxvSydyRYkWN2VdikOX+HnQNQ4yyhvOklcenbYwdFztUfbL nDTw== X-Gm-Message-State: AOAM530JNaydLIhkgzGt6ELdQTT8Pj7SuB0/7sItLIo9XSuv+Aa4yzXS x9e5SozDSSIDaKTr2X4kWA== X-Google-Smtp-Source: ABdhPJzja/44mLPDsRi9Us+9wAPvOQ/J+0Wdpj6Prbtm0EAoaesENU75sSr4Wx7bmnNEdQs7rA6GEg== X-Received: by 2002:a02:740d:: with SMTP id o13mr606075jac.42.1590608200163; Wed, 27 May 2020 12:36:40 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id o70sm2146812ild.3.2020.05.27.12.36.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2020 12:36:39 -0700 (PDT) Received: (nullmailer pid 2608242 invoked by uid 1000); Wed, 27 May 2020 19:36:38 -0000 Date: Wed, 27 May 2020 13:36:38 -0600 From: Rob Herring To: Rajendra Nayak Cc: stanimir.varbanov@linaro.org, agross@kernel.org, bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, mka@chromium.org Subject: Re: [PATCH v2] dt-bindings: media: venus: Add an optional power domain for perf voting Message-ID: <20200527193638.GA2604206@bogus> References: <1589349807-10163-1-git-send-email-rnayak@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1589349807-10163-1-git-send-email-rnayak@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, May 13, 2020 at 11:33:27AM +0530, Rajendra Nayak wrote: > Add an optional power domain which when specified can be used for > setting the performance state of Venus. > > Signed-off-by: Rajendra Nayak > --- > Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml | 6 +++++- > Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 6 +++++- > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml > index 764affa..ac1ed64 100644 > --- a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml > @@ -25,12 +25,16 @@ properties: > maxItems: 1 > > power-domains: > - maxItems: 2 > + minItems: 2 > + maxItems: 3 > > power-domain-names: > + minItems: 2 > + maxItems: 3 > items: > - const: venus > - const: vcodec0 > + - const: opp-pd Humm, looks suspicious. This is a phyical power island in this block? Because that's what 'power-domains' are supposed to represent. Not $os pm-domain construct. Rob