From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Vinod Koul <vkoul@kernel.org> Cc: Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>, Rob Clark <robdclark@gmail.com>, linux-arm-msm@vger.kernel.org, Bjorn Andersson <bjorn.andersson@linaro.org>, Andrzej Hajda <a.hajda@samsung.com>, Neil Armstrong <narmstrong@baylibre.com>, Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@siol.net>, Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 2/3] dt-bindings: display: bridge: Add documentation for LT9611 Date: Thu, 28 May 2020 04:48:37 +0300 [thread overview] Message-ID: <20200528014837.GD4670@pendragon.ideasonboard.com> (raw) In-Reply-To: <20200513100533.42996-3-vkoul@kernel.org> Hi Vinod, Thank you for the patch. On Wed, May 13, 2020 at 03:35:32PM +0530, Vinod Koul wrote: > Lontium LT9611 is a DSI to HDMI bridge which supports 2 DSI ports > and I2S port as input and one HDMI port as output > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > --- > .../display/bridge/lontium,lt9611.yaml | 178 ++++++++++++++++++ > 1 file changed, 178 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml b/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml > new file mode 100644 > index 000000000000..77ee8cc35cd8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml > @@ -0,0 +1,178 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/lontium,lt9611.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Lontium LT9611 2 Port MIPI to HDMI Bridge > + > +maintainers: > + - Vinod Koul <vkoul@kernel.org> > + > +description: | > + The LT9611 is a bridge device which converts DSI to HDMI > + > +properties: > + compatible: > + enum: > + - lontium,lt9611 > + > + reg: > + maxItems: 1 > + description: base I2C address of the device. > + > + "#sound-dai-cells": > + const: 1 > + > + interrupts: > + maxItems: 1 > + description: interrupt line for the chip I think you could drop the descriptions for the reg and interrupt properties, they don't add much. > + > + reset-gpios: > + maxItems: 1 > + description: GPIO connected to active high RESET pin. > + > + vdd-supply: > + description: Regulator for 1.8V MIPI phy power. > + > + vcc-supply: > + description: Regulator for 3.3V IO power. > + > + ports: > + type: object > + > + properties: > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + port@0: > + type: object > + additionalProperties: false > + > + description: | > + HDMI port for HDMI output The usual practice is to have the input ports first, followed by the output ports. Is there a reason not to follow that rule ? > + > + properties: > + reg: > + const: 0 > + > + patternProperties: > + endpoint: If you want to use patternProperties, this should be "^endpoint@[0-9]+$": (including the quotes). Same below. > + type: object > + additionalProperties: false > + > + properties: > + remote-endpoint: true How about remote-endpoint: $ref: /schemas/types.yaml#/definitions/phandle and the same below ? You also need a reg property if multiple endpoints are present. > + > + required: > + - reg > + > + port@1: > + type: object > + additionalProperties: false > + > + description: | > + MIPI port-1 for MIPI input > + > + properties: > + reg: > + const: 1 > + > + patternProperties: > + endpoint: > + type: object > + additionalProperties: false > + > + properties: > + remote-endpoint: true > + > + required: > + - reg > + > + port@2: > + type: object > + additionalProperties: false > + > + description: | > + MIPI port-2 for MIPI input A description of how the two MIPI inputs differ would be useful. In particular, are both mandatory, or is it valid to connect only one of the two ? If using a single input is supported, can it be either, or does it have to be the first one ? When using both inputs, what should be connected to them ? > + > + properties: > + reg: > + const: 2 > + > + patternProperties: > + endpoint: > + type: object > + additionalProperties: false > + > + properties: > + remote-endpoint: true > + > + required: > + - reg > + > + required: > + - "#address-cells" > + - "#size-cells" > + - port@0 > + - port@1 > + > +required: > + - compatible > + - reg > + - interrupts > + - vdd-supply > + - vcc-supply > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + > + i2c10 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + lt9611_codec: hdmi-bridge@3b { Please drop unused labels. > + compatible = "lontium,lt9611"; > + reg = <0x3b>; > + > + reset-gpios = <&tlmm 128 GPIO_ACTIVE_HIGH>; > + interrupts-extended = <&tlmm 84 IRQ_TYPE_EDGE_FALLING>; > + > + vdd-supply = <<9611_1v8>; > + vcc-supply = <<9611_3v3>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + lt9611_out: endpoint { > + remote-endpoint = <&hdmi_con>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + lt9611_a: endpoint { > + remote-endpoint = <&dsi0_out>; > + }; > + }; > + > + port@2 { > + reg = <2>; > + lt9611_b: endpoint { > + remote-endpoint = <&dsi1_out>; > + }; > + }; > + }; > + }; > + }; It's customary to end YAML schema files with ... on a separate line. -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Vinod Koul <vkoul@kernel.org> Cc: devicetree@vger.kernel.org, Jernej Skrabec <jernej.skrabec@siol.net>, Neil Armstrong <narmstrong@baylibre.com>, David Airlie <airlied@linux.ie>, linux-arm-msm@vger.kernel.org, Jonas Karlman <jonas@kwiboo.se>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Bjorn Andersson <bjorn.andersson@linaro.org>, Andrzej Hajda <a.hajda@samsung.com>, Rob Herring <robh+dt@kernel.org> Subject: Re: [PATCH 2/3] dt-bindings: display: bridge: Add documentation for LT9611 Date: Thu, 28 May 2020 04:48:37 +0300 [thread overview] Message-ID: <20200528014837.GD4670@pendragon.ideasonboard.com> (raw) In-Reply-To: <20200513100533.42996-3-vkoul@kernel.org> Hi Vinod, Thank you for the patch. On Wed, May 13, 2020 at 03:35:32PM +0530, Vinod Koul wrote: > Lontium LT9611 is a DSI to HDMI bridge which supports 2 DSI ports > and I2S port as input and one HDMI port as output > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > --- > .../display/bridge/lontium,lt9611.yaml | 178 ++++++++++++++++++ > 1 file changed, 178 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml b/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml > new file mode 100644 > index 000000000000..77ee8cc35cd8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml > @@ -0,0 +1,178 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/lontium,lt9611.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Lontium LT9611 2 Port MIPI to HDMI Bridge > + > +maintainers: > + - Vinod Koul <vkoul@kernel.org> > + > +description: | > + The LT9611 is a bridge device which converts DSI to HDMI > + > +properties: > + compatible: > + enum: > + - lontium,lt9611 > + > + reg: > + maxItems: 1 > + description: base I2C address of the device. > + > + "#sound-dai-cells": > + const: 1 > + > + interrupts: > + maxItems: 1 > + description: interrupt line for the chip I think you could drop the descriptions for the reg and interrupt properties, they don't add much. > + > + reset-gpios: > + maxItems: 1 > + description: GPIO connected to active high RESET pin. > + > + vdd-supply: > + description: Regulator for 1.8V MIPI phy power. > + > + vcc-supply: > + description: Regulator for 3.3V IO power. > + > + ports: > + type: object > + > + properties: > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + port@0: > + type: object > + additionalProperties: false > + > + description: | > + HDMI port for HDMI output The usual practice is to have the input ports first, followed by the output ports. Is there a reason not to follow that rule ? > + > + properties: > + reg: > + const: 0 > + > + patternProperties: > + endpoint: If you want to use patternProperties, this should be "^endpoint@[0-9]+$": (including the quotes). Same below. > + type: object > + additionalProperties: false > + > + properties: > + remote-endpoint: true How about remote-endpoint: $ref: /schemas/types.yaml#/definitions/phandle and the same below ? You also need a reg property if multiple endpoints are present. > + > + required: > + - reg > + > + port@1: > + type: object > + additionalProperties: false > + > + description: | > + MIPI port-1 for MIPI input > + > + properties: > + reg: > + const: 1 > + > + patternProperties: > + endpoint: > + type: object > + additionalProperties: false > + > + properties: > + remote-endpoint: true > + > + required: > + - reg > + > + port@2: > + type: object > + additionalProperties: false > + > + description: | > + MIPI port-2 for MIPI input A description of how the two MIPI inputs differ would be useful. In particular, are both mandatory, or is it valid to connect only one of the two ? If using a single input is supported, can it be either, or does it have to be the first one ? When using both inputs, what should be connected to them ? > + > + properties: > + reg: > + const: 2 > + > + patternProperties: > + endpoint: > + type: object > + additionalProperties: false > + > + properties: > + remote-endpoint: true > + > + required: > + - reg > + > + required: > + - "#address-cells" > + - "#size-cells" > + - port@0 > + - port@1 > + > +required: > + - compatible > + - reg > + - interrupts > + - vdd-supply > + - vcc-supply > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + > + i2c10 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + lt9611_codec: hdmi-bridge@3b { Please drop unused labels. > + compatible = "lontium,lt9611"; > + reg = <0x3b>; > + > + reset-gpios = <&tlmm 128 GPIO_ACTIVE_HIGH>; > + interrupts-extended = <&tlmm 84 IRQ_TYPE_EDGE_FALLING>; > + > + vdd-supply = <<9611_1v8>; > + vcc-supply = <<9611_3v3>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + lt9611_out: endpoint { > + remote-endpoint = <&hdmi_con>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + lt9611_a: endpoint { > + remote-endpoint = <&dsi0_out>; > + }; > + }; > + > + port@2 { > + reg = <2>; > + lt9611_b: endpoint { > + remote-endpoint = <&dsi1_out>; > + }; > + }; > + }; > + }; > + }; It's customary to end YAML schema files with ... on a separate line. -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-05-28 1:48 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-13 10:05 [PATCH 0/3] Add LT9611 DSI to HDMI bridge Vinod Koul 2020-05-13 10:05 ` Vinod Koul 2020-05-13 10:05 ` [PATCH 1/3] dt-bindings: vendor-prefixes: Add Lontium vendor prefix Vinod Koul 2020-05-13 10:05 ` Vinod Koul 2020-05-28 1:34 ` Rob Herring 2020-05-28 1:34 ` Rob Herring 2020-05-13 10:05 ` [PATCH 2/3] dt-bindings: display: bridge: Add documentation for LT9611 Vinod Koul 2020-05-13 10:05 ` Vinod Koul 2020-05-28 1:37 ` Rob Herring 2020-05-28 1:37 ` Rob Herring 2020-05-28 1:48 ` Laurent Pinchart [this message] 2020-05-28 1:48 ` Laurent Pinchart 2020-06-04 7:18 ` Vinod Koul 2020-06-04 7:18 ` Vinod Koul 2020-06-04 7:29 ` Laurent Pinchart 2020-06-04 7:29 ` Laurent Pinchart 2020-05-13 10:05 ` [PATCH 3/3] drm/bridge: Introduce LT9611 DSI to HDMI bridge Vinod Koul 2020-05-13 10:05 ` Vinod Koul 2020-05-13 16:14 ` kbuild test robot 2020-05-13 16:14 ` kbuild test robot 2020-05-13 16:14 ` kbuild test robot 2020-05-13 16:46 ` kbuild test robot 2020-05-13 16:46 ` kbuild test robot 2020-05-13 16:46 ` kbuild test robot 2020-05-13 19:20 ` Emil Velikov 2020-05-13 19:20 ` Emil Velikov 2020-05-14 7:06 ` Vinod Koul 2020-05-14 7:06 ` Vinod Koul 2020-05-28 1:52 ` Laurent Pinchart 2020-05-28 1:52 ` Laurent Pinchart 2020-06-04 7:25 ` Vinod Koul 2020-06-04 7:25 ` Vinod Koul 2020-06-04 7:38 ` Laurent Pinchart 2020-06-04 7:38 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200528014837.GD4670@pendragon.ideasonboard.com \ --to=laurent.pinchart@ideasonboard.com \ --cc=a.hajda@samsung.com \ --cc=airlied@linux.ie \ --cc=bjorn.andersson@linaro.org \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=jernej.skrabec@siol.net \ --cc=jonas@kwiboo.se \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=narmstrong@baylibre.com \ --cc=robdclark@gmail.com \ --cc=robh+dt@kernel.org \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.