From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EFB7C433E0 for ; Thu, 28 May 2020 06:14:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0FCEC2078C for ; Thu, 28 May 2020 06:14:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="n6L4oCgg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727800AbgE1GOA (ORCPT ); Thu, 28 May 2020 02:14:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725859AbgE1GOA (ORCPT ); Thu, 28 May 2020 02:14:00 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC1D2C05BD1E for ; Wed, 27 May 2020 23:13:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zni0B8k5iMx2062s+cLkcal1ezBX/6+aSXESnytrVBA=; b=n6L4oCgg5qx1q88mtA0neKBlJH VH5WkwsKABSpxb2nXXripcejQz22sXvL/OXW6RXPrCwIl3MJy9Z0HTPAP2asJIv+VT3HxqDGr6Qtj Db/jZtyXSdRaq03bWrdWmluP1qui019NEK5NZkiRVdb6cNJNj85irS1+kavTyvaJ3gwBTlAAShxgF 6jcnT1yUoRPamgODIO4mqAstUWV9KEQzTDTcyuAukl73XzsP2imQk1CtHPU8waqlwRAPN6V8CP717 A1wABNoblFdvkivbGnODWd7/NBuXGGgYsjNhvA4Qmt3/7dasgoJfiboIkWqXJ2iSsbO87fAqkCStm SIyURPEA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeBnd-0007EK-9j; Thu, 28 May 2020 06:13:53 +0000 Date: Wed, 27 May 2020 23:13:53 -0700 From: Christoph Hellwig To: Joerg Roedel Cc: iommu@lists.linux-foundation.org, jroedel@suse.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/10] iommu/amd: Unexport get_dev_data() Message-ID: <20200528061353.GA17035@infradead.org> References: <20200527115313.7426-1-joro@8bytes.org> <20200527115313.7426-3-joro@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200527115313.7426-3-joro@8bytes.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2020 at 01:53:05PM +0200, Joerg Roedel wrote: > From: Joerg Roedel > > This function is internal to the AMD IOMMU driver and only exported > because the amd_iommu_v2 modules calls it. But the reason it is called > from there could better be handled by amd_iommu_is_attach_deferred(). > So unexport get_dev_data() and use amd_iommu_is_attach_deferred() > instead. Btw, what is the reason amd_iommu_v2 is a separate module? It is very little code, and other drivers seem to just integrate such functionality. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DA27C433DF for ; Thu, 28 May 2020 06:14:04 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 12EAD2078C for ; Thu, 28 May 2020 06:14:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="n6L4oCgg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12EAD2078C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id C7A6386F2B; Thu, 28 May 2020 06:14:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SmhH2oMKB-At; Thu, 28 May 2020 06:14:03 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 57A2386D7B; Thu, 28 May 2020 06:14:03 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 31BE8C088D; Thu, 28 May 2020 06:14:03 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id B6455C016F for ; Thu, 28 May 2020 06:13:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 9F14586D7B for ; Thu, 28 May 2020 06:13:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PLbq7I0D3s_k for ; Thu, 28 May 2020 06:13:55 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 670DA86D20 for ; Thu, 28 May 2020 06:13:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zni0B8k5iMx2062s+cLkcal1ezBX/6+aSXESnytrVBA=; b=n6L4oCgg5qx1q88mtA0neKBlJH VH5WkwsKABSpxb2nXXripcejQz22sXvL/OXW6RXPrCwIl3MJy9Z0HTPAP2asJIv+VT3HxqDGr6Qtj Db/jZtyXSdRaq03bWrdWmluP1qui019NEK5NZkiRVdb6cNJNj85irS1+kavTyvaJ3gwBTlAAShxgF 6jcnT1yUoRPamgODIO4mqAstUWV9KEQzTDTcyuAukl73XzsP2imQk1CtHPU8waqlwRAPN6V8CP717 A1wABNoblFdvkivbGnODWd7/NBuXGGgYsjNhvA4Qmt3/7dasgoJfiboIkWqXJ2iSsbO87fAqkCStm SIyURPEA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeBnd-0007EK-9j; Thu, 28 May 2020 06:13:53 +0000 Date: Wed, 27 May 2020 23:13:53 -0700 From: Christoph Hellwig To: Joerg Roedel Subject: Re: [PATCH 02/10] iommu/amd: Unexport get_dev_data() Message-ID: <20200528061353.GA17035@infradead.org> References: <20200527115313.7426-1-joro@8bytes.org> <20200527115313.7426-3-joro@8bytes.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200527115313.7426-3-joro@8bytes.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Cc: iommu@lists.linux-foundation.org, jroedel@suse.de, linux-kernel@vger.kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Wed, May 27, 2020 at 01:53:05PM +0200, Joerg Roedel wrote: > From: Joerg Roedel > > This function is internal to the AMD IOMMU driver and only exported > because the amd_iommu_v2 modules calls it. But the reason it is called > from there could better be handled by amd_iommu_is_attach_deferred(). > So unexport get_dev_data() and use amd_iommu_is_attach_deferred() > instead. Btw, what is the reason amd_iommu_v2 is a separate module? It is very little code, and other drivers seem to just integrate such functionality. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu