All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Phil Blundell" <pb@pbcl.net>
To: Khem Raj <raj.khem@gmail.com>
Cc: Andre McCurdy <armccurdy@gmail.com>,
	Richard Purdie <richard.purdie@linuxfoundation.org>,
	Denys Dmytriyenko <denis@denix.org>,
	Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] linux-libc-headers: Check for asm/bpf_perf_event.h before multilibbing
Date: Thu, 28 May 2020 11:01:12 +0200	[thread overview]
Message-ID: <20200528090112.GA1314@pbcl.net> (raw)
In-Reply-To: <CAMKF1spUHqFeyhr6R+3rQ8_1foDFZf6HgFNN70OOHgtFijjWaQ@mail.gmail.com>

On Wed, May 27, 2020 at 05:02:00PM -0700, Khem Raj wrote:
> https://github.com/torvalds/linux/commit/052876f8e5aec887d22c4d06e54aa5531ffcec75
> 
> this change e.g. in userspace checks for UINPUT_VERSION and decides to
> use one method
> or legacy to setup the device but this is really not gonna work with
> kernels where these ioctls
> are not available, it perhaps can be fixed to not check for
> UINPUT_VERSION but then there
> could be many such cases, how many can we chase.

There's nothing inherently incompatible about that kernel change.  The
compile-time UINPUT_VERSION tells you that things like struct uinput_setup
have been declared.  If you want to be compatible with both old and new
kernels at run time, the right way to do it is either to call
ioctl(UI_GET_VERSION) or just to handle the appropriate error returns
from the newly introduced ioctls.  It's entirely possible that there
is userspace code out there that's doing something silly with this,
but if there is then again I would take the view that it's just a bug
and ought to be fixed.

In terms of OE, the theory is that generated binaries ought to work with
any kernel of ${OLDEST_KERNEL} or newer.  Obviously, individual distros
are welcome to do whatever is tactically appropriate for them, that's
always fine.  If they know that they are only shipping a single kernel
version then it might be reasonable to compile against the matching
linux-libc-headers and set OLDEST_KERNEL to the same version in order
to minimise compatibility issues.  Of course, that then means they're
likely to be building against a different linux-libc-headers to
everyone else and that might introduce a different set of problems,
but it's a reasonable tradeoff to consider.

p.

  reply	other threads:[~2020-05-28  9:01 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-27 15:50 [PATCH] linux-libc-headers: Check for asm/bpf_perf_event.h before multilibbing Khem Raj
2020-05-27 15:59 ` [OE-core] " Denys Dmytriyenko
2020-05-27 20:45   ` Khem Raj
2020-05-27 20:56     ` Andre McCurdy
2020-05-27 21:25   ` Richard Purdie
2020-05-27 21:46     ` Khem Raj
2020-05-27 21:50       ` Richard Purdie
2020-05-27 21:52       ` Phil Blundell
2020-05-27 22:42         ` Andre McCurdy
2020-05-27 22:57           ` Khem Raj
2020-05-28  0:02             ` Khem Raj
2020-05-28  9:01               ` Phil Blundell [this message]
2020-05-28 18:37                 ` Khem Raj
2020-05-27 23:11     ` Denys Dmytriyenko
2020-05-28 13:20       ` Richard Purdie
2020-05-28 13:39         ` Adrian Bunk
2020-05-28 17:38           ` Andre McCurdy
2020-05-28 19:04             ` Adrian Bunk
2020-05-28 19:30               ` Andre McCurdy
2020-05-28 21:10                 ` Phil Blundell
2020-05-28 21:33             ` Phil Blundell
2020-05-28 18:31           ` Khem Raj
2020-05-28 18:33         ` Khem Raj
2020-05-28 20:10           ` Adrian Bunk
2020-05-27 21:20 ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200528090112.GA1314@pbcl.net \
    --to=pb@pbcl.net \
    --cc=armccurdy@gmail.com \
    --cc=denis@denix.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.