All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, fam@euphon.net, vsementsov@virtuozzo.com,
	ronniesahlberg@gmail.com, codyprime@gmail.com, sw@weilnetz.de,
	pl@kamp.de, qemu-devel@nongnu.org, mreitz@redhat.com,
	stefanha@redhat.com, pbonzini@redhat.com, den@openvz.org
Subject: [PATCH v3 08/10] block/vhdx: drop unallocated_blocks_are_zero
Date: Thu, 28 May 2020 12:44:03 +0300	[thread overview]
Message-ID: <20200528094405.145708-9-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20200528094405.145708-1-vsementsov@virtuozzo.com>

vhdx doesn't have .bdrv_co_block_status handler, so DATA|ALLOCATED is
always assumed for it in bdrv_co_block_status().
unallocated_blocks_are_zero is useless (it doesn't affect the only user
of the field: bdrv_co_block_status()), drop it.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
 block/vhdx.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/block/vhdx.c b/block/vhdx.c
index fa9e544a5e..645dc4b4f4 100644
--- a/block/vhdx.c
+++ b/block/vhdx.c
@@ -1164,9 +1164,6 @@ static int vhdx_get_info(BlockDriverState *bs, BlockDriverInfo *bdi)
 
     bdi->cluster_size = s->block_size;
 
-    bdi->unallocated_blocks_are_zero =
-        (s->params.data_bits & VHDX_PARAMS_HAS_PARENT) == 0;
-
     return 0;
 }
 
-- 
2.18.0



  parent reply	other threads:[~2020-05-28  9:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-28  9:43 [PATCH v3 00/10] drop unallocated_blocks_are_zero Vladimir Sementsov-Ogievskiy
2020-05-28  9:43 ` [PATCH v3 01/10] qemu-img: convert: don't use unallocated_blocks_are_zero Vladimir Sementsov-Ogievskiy
2020-05-28  9:43 ` [PATCH v3 02/10] block: inline bdrv_unallocated_blocks_are_zero() Vladimir Sementsov-Ogievskiy
2020-05-28  9:43 ` [PATCH v3 03/10] block/vdi: return ZERO block-status when appropriate Vladimir Sementsov-Ogievskiy
2020-05-28  9:43 ` [PATCH v3 04/10] block/vpc: " Vladimir Sementsov-Ogievskiy
2020-07-06  8:28   ` Max Reitz
2020-07-06  9:17     ` Vladimir Sementsov-Ogievskiy
2020-05-28  9:44 ` [PATCH v3 05/10] block/crypto: drop unallocated_blocks_are_zero Vladimir Sementsov-Ogievskiy
2020-05-28  9:44 ` [PATCH v3 06/10] block/iscsi: " Vladimir Sementsov-Ogievskiy
2020-05-28  9:44 ` [PATCH v3 07/10] block/file-posix: " Vladimir Sementsov-Ogievskiy
2020-05-28  9:44 ` Vladimir Sementsov-Ogievskiy [this message]
2020-05-28  9:44 ` [PATCH v3 09/10] block: " Vladimir Sementsov-Ogievskiy
2020-05-28  9:44 ` [PATCH v3 10/10] qed: Simplify backing reads Vladimir Sementsov-Ogievskiy
2020-07-03 14:06 ` [PATCH v3 00/10] drop unallocated_blocks_are_zero Max Reitz
2020-07-03 18:08   ` Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200528094405.145708-9-vsementsov@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=codyprime@gmail.com \
    --cc=den@openvz.org \
    --cc=fam@euphon.net \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=pl@kamp.de \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=ronniesahlberg@gmail.com \
    --cc=stefanha@redhat.com \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.