From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E19CDC433DF for ; Thu, 28 May 2020 10:47:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC490207D3 for ; Thu, 28 May 2020 10:47:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Mo7IIjA/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387978AbgE1Kru (ORCPT ); Thu, 28 May 2020 06:47:50 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:33358 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387953AbgE1Krt (ORCPT ); Thu, 28 May 2020 06:47:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590662867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RZGL7uquooLD1KGPOGdGR27lMV+XbVUTgYsP13xHC+s=; b=Mo7IIjA/QmEKc+s5G0QrPN3v8XtgGPTdeAS2zJ1XTsYLHvy7g1450amHKd0nAm2VDWQVb2 wQUOKYRJydgdhJAuyRCwiieM1jBPmlLGfq0+F+aw8RfZaXLT0gB02k5m/00dHkpuBI82Wl yMp4/5rsx9ri8xiZxZc+8lawHDYLqRY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-448-s92uV4J7MESKELxraHEMVA-1; Thu, 28 May 2020 06:47:33 -0400 X-MC-Unique: s92uV4J7MESKELxraHEMVA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BCB7E8010EC; Thu, 28 May 2020 10:47:32 +0000 (UTC) Received: from bfoster (dhcp-41-2.bos.redhat.com [10.18.41.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 633105D9EF; Thu, 28 May 2020 10:47:32 +0000 (UTC) Date: Thu, 28 May 2020 06:47:30 -0400 From: Brian Foster To: bugzilla-daemon@bugzilla.kernel.org Cc: linux-xfs@vger.kernel.org Subject: Re: [Bug 207053] fsfreeze deadlock on XFS (the FIFREEZE ioctl and subsequent FITHAW hang indefinitely) Message-ID: <20200528104730.GA16657@bfoster> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Thu, May 28, 2020 at 06:00:38AM +0000, bugzilla-daemon@bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=207053 > > --- Comment #8 from Paul Furtado (paulfurtado91@gmail.com) --- > The patches that came from this issue have given us many weeks of stability now > and we were ready to declare this as totally fixed, however, we hit another > instance of this issue this week which I'm assuming is probably on a slightly > different and much rarer code path. > > Here's a link to the blocked tasks log (beware that it's 2MB due to endless > processes getting hung inside the container once the filesystem was frozen): > https://gist.githubusercontent.com/PaulFurtado/48253a6978763671f70dc94d933df851/raw/6bad12023ac56e9b6cb3dde771fcb5b15f0bd679/patched_kernel_fsfreeze_sys_w.log > This shows the eofblocks scan in the following (massaged) trace: [1259466.349224] Workqueue: xfs-eofblocks/nvme4n1 xfs_eofblocks_worker [xfs] [1259466.353550] Call Trace: [1259466.359370] schedule+0x2f/0xa0 [1259466.362297] rwsem_down_read_slowpath+0x196/0x530 [1259466.372467] __percpu_down_read+0x49/0x60 [1259466.375778] __sb_start_write+0x5b/0x60 [1259466.379139] xfs_trans_alloc+0x152/0x160 [xfs] [1259466.382715] xfs_free_eofblocks+0x12d/0x1f0 [xfs] [1259466.386407] xfs_inode_free_eofblocks+0x128/0x1a0 [xfs] [1259466.394058] xfs_inode_ag_walk.isra.17+0x1a7/0x410 [xfs] [1259466.536551] xfs_inode_ag_iterator_tag+0x73/0xb0 [xfs] [1259466.540235] xfs_eofblocks_worker+0x29/0x40 [xfs] [1259466.543748] process_one_work+0x195/0x380 [1259466.546996] worker_thread+0x30/0x390 [1259466.553449] kthread+0x113/0x130 [1259466.559579] ret_from_fork+0x1f/0x40 This should be addressed by upstream commit 4b674b9ac8529 ("xfs: acquire superblock freeze protection on eofblocks scans"), which causes xfs_eofblocks_worker() to bail unless it acquires freeze write protection. What exact kernel is this seen on? Brian > Thanks, > Paul > > -- > You are receiving this mail because: > You are watching the assignee of the bug. >