* [PATCH] ath10k: Remove ath10k_qmi_register_service_notifier() declaration
@ 2020-05-28 19:21 ` Douglas Anderson
0 siblings, 0 replies; 4+ messages in thread
From: Douglas Anderson @ 2020-05-28 19:21 UTC (permalink / raw)
To: Kalle Valo
Cc: Niklas Cassel, Brian Norris, Govind Singh, Bjorn Andersson,
Douglas Anderson, David S. Miller, Jakub Kicinski, ath10k,
linux-kernel, linux-wireless, netdev
The ath10k/qmi.h header file contains a declaration for the function
ath10k_qmi_register_service_notifier(). This function doesn't exist.
Remove the declaration.
This patch is a no-op and was just found by code inspection.
Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/net/wireless/ath/ath10k/qmi.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/qmi.h b/drivers/net/wireless/ath/ath10k/qmi.h
index dc257375f161..e03581182919 100644
--- a/drivers/net/wireless/ath/ath10k/qmi.h
+++ b/drivers/net/wireless/ath/ath10k/qmi.h
@@ -112,7 +112,6 @@ int ath10k_qmi_wlan_enable(struct ath10k *ar,
enum wlfw_driver_mode_enum_v01 mode,
const char *version);
int ath10k_qmi_wlan_disable(struct ath10k *ar);
-int ath10k_qmi_register_service_notifier(struct notifier_block *nb);
int ath10k_qmi_init(struct ath10k *ar, u32 msa_size);
int ath10k_qmi_deinit(struct ath10k *ar);
int ath10k_qmi_set_fw_log_mode(struct ath10k *ar, u8 fw_log_mode);
--
2.27.0.rc0.183.gde8f92d652-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ath10k: Remove ath10k_qmi_register_service_notifier() declaration
@ 2020-05-28 19:21 ` Douglas Anderson
0 siblings, 0 replies; 4+ messages in thread
From: Douglas Anderson @ 2020-05-28 19:21 UTC (permalink / raw)
To: Kalle Valo
Cc: Govind Singh, linux-kernel, Brian Norris, linux-wireless,
Douglas Anderson, ath10k, Bjorn Andersson, netdev, Niklas Cassel,
Jakub Kicinski, David S. Miller
The ath10k/qmi.h header file contains a declaration for the function
ath10k_qmi_register_service_notifier(). This function doesn't exist.
Remove the declaration.
This patch is a no-op and was just found by code inspection.
Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/net/wireless/ath/ath10k/qmi.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/qmi.h b/drivers/net/wireless/ath/ath10k/qmi.h
index dc257375f161..e03581182919 100644
--- a/drivers/net/wireless/ath/ath10k/qmi.h
+++ b/drivers/net/wireless/ath/ath10k/qmi.h
@@ -112,7 +112,6 @@ int ath10k_qmi_wlan_enable(struct ath10k *ar,
enum wlfw_driver_mode_enum_v01 mode,
const char *version);
int ath10k_qmi_wlan_disable(struct ath10k *ar);
-int ath10k_qmi_register_service_notifier(struct notifier_block *nb);
int ath10k_qmi_init(struct ath10k *ar, u32 msa_size);
int ath10k_qmi_deinit(struct ath10k *ar);
int ath10k_qmi_set_fw_log_mode(struct ath10k *ar, u8 fw_log_mode);
--
2.27.0.rc0.183.gde8f92d652-goog
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ath10k: Remove ath10k_qmi_register_service_notifier() declaration
2020-05-28 19:21 ` Douglas Anderson
(?)
(?)
@ 2020-05-30 14:18 ` Kalle Valo
-1 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2020-05-30 14:18 UTC (permalink / raw)
To: Douglas Anderson
Cc: Niklas Cassel, Brian Norris, Govind Singh, Bjorn Andersson,
Douglas Anderson, David S. Miller, Jakub Kicinski, ath10k,
linux-kernel, linux-wireless, netdev
Douglas Anderson <dianders@chromium.org> wrote:
> The ath10k/qmi.h header file contains a declaration for the function
> ath10k_qmi_register_service_notifier(). This function doesn't exist.
> Remove the declaration.
>
> This patch is a no-op and was just found by code inspection.
>
> Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
23cc6bb5a2e6 ath10k: Remove ath10k_qmi_register_service_notifier() declaration
--
https://patchwork.kernel.org/patch/11576663/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ath10k: Remove ath10k_qmi_register_service_notifier() declaration
2020-05-28 19:21 ` Douglas Anderson
(?)
@ 2020-05-30 14:18 ` Kalle Valo
-1 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2020-05-30 14:18 UTC (permalink / raw)
To: Douglas Anderson
Cc: Govind Singh, linux-kernel, Brian Norris, linux-wireless, ath10k,
Bjorn Andersson, netdev, Niklas Cassel, Jakub Kicinski,
David S. Miller
Douglas Anderson <dianders@chromium.org> wrote:
> The ath10k/qmi.h header file contains a declaration for the function
> ath10k_qmi_register_service_notifier(). This function doesn't exist.
> Remove the declaration.
>
> This patch is a no-op and was just found by code inspection.
>
> Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
23cc6bb5a2e6 ath10k: Remove ath10k_qmi_register_service_notifier() declaration
--
https://patchwork.kernel.org/patch/11576663/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-30 14:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-28 19:21 [PATCH] ath10k: Remove ath10k_qmi_register_service_notifier() declaration Douglas Anderson
2020-05-28 19:21 ` Douglas Anderson
2020-05-30 14:18 ` Kalle Valo
2020-05-30 14:18 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.