All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Igor Mitsyanko" <i.mitsyanko@gmail.com>,
	"Alistair Francis" <alistair@alistair23.me>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: [PULL 01/21] hw/display/edid: Add missing 'qdev-properties.h' header
Date: Thu, 28 May 2020 14:35:49 +0200	[thread overview]
Message-ID: <20200528123609.27362-2-kraxel@redhat.com> (raw)
In-Reply-To: <20200528123609.27362-1-kraxel@redhat.com>

From: Philippe Mathieu-Daudé <f4bug@amsat.org>

When trying to consume the DEFINE_EDID_PROPERTIES() macro
by including "hw/display/edid.h", we get this build failure:

  include/hw/display/edid.h:24:5: error: implicit declaration of
  function ‘DEFINE_PROP_UINT32’ [-Werror=implicit-function-declaration]
     24 |     DEFINE_PROP_UINT32("xres", _state, _edid_info.prefx, 0),    \
        |     ^~~~~~~~~~~~~~~~~~

Headers should be self-contained, and one shouldn't have to
dig to find the missing headers.
In this case "hw/qdev-properties.h" is missing. Add it.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-id: 20200526062252.19852-2-f4bug@amsat.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 include/hw/display/edid.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/hw/display/edid.h b/include/hw/display/edid.h
index ff99dc0a052b..23371ee82c63 100644
--- a/include/hw/display/edid.h
+++ b/include/hw/display/edid.h
@@ -2,6 +2,7 @@
 #define EDID_H
 
 #include "qom/object.h"
+#include "hw/qdev-properties.h"
 
 typedef struct qemu_edid_info {
     const char *vendor; /* http://www.uefi.org/pnp_id_list */
-- 
2.18.4



  reply	other threads:[~2020-05-28 12:45 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-28 12:35 [PULL 00/21] Vga 20200528 patches Gerd Hoffmann
2020-05-28 12:35 ` Gerd Hoffmann [this message]
2020-05-28 12:35 ` [PULL 02/21] hw/display/cg3: Convert debug printf()s to trace events Gerd Hoffmann
2020-05-28 12:35 ` [PULL 03/21] hw/display/cirrus_vga: Convert debug printf() to trace event Gerd Hoffmann
2020-05-28 12:35 ` [PULL 04/21] hw/display/cirrus_vga: Use qemu_log_mask(UNIMP) instead of debug printf Gerd Hoffmann
2020-05-28 12:35 ` [PULL 05/21] hw/display/cirrus_vga: Use qemu_log_mask(ERROR) " Gerd Hoffmann
2020-05-28 12:35 ` [PULL 06/21] hw/display/cirrus_vga: Convert debug printf() to trace event Gerd Hoffmann
2020-05-28 12:35 ` [PULL 07/21] hw/display/dpcd: Fix memory region size Gerd Hoffmann
2020-05-28 12:35 ` [PULL 08/21] hw/display/dpcd: Convert debug printf()s to trace events Gerd Hoffmann
2020-05-28 12:35 ` [PULL 09/21] hw/display/xlnx_dp: Replace disabled DPRINTF() by error_report() Gerd Hoffmann
2020-05-28 12:35 ` [PULL 10/21] hw/display/vmware_vga: Replace printf() calls by qemu_log_mask(ERROR) Gerd Hoffmann
2020-05-28 12:35 ` [PULL 11/21] hw/display/vmware_vga: Let the PCI device own its I/O MemoryRegion Gerd Hoffmann
2020-05-28 12:36 ` [PULL 12/21] hw/display/exynos4210_fimd: Use qemu_log_mask(GUEST_ERROR) Gerd Hoffmann
2020-05-28 12:36 ` [PULL 13/21] hw/display/omap_dss: Replace fprintf() call by qemu_log_mask(LOG_UNIMP) Gerd Hoffmann
2020-05-28 12:36 ` [PULL 14/21] hw/display/pxa2xx_lcd: Replace printf() call by qemu_log_mask() Gerd Hoffmann
2020-05-28 12:36 ` [PULL 15/21] sm501: Convert printf + abort to qemu_log_mask Gerd Hoffmann
2020-05-28 12:36 ` [PULL 16/21] sm501: Shorten long variable names in sm501_2d_operation Gerd Hoffmann
2020-05-28 12:36 ` [PULL 17/21] sm501: Use BIT(x) macro to shorten constant Gerd Hoffmann
2020-05-28 12:36 ` [PULL 18/21] sm501: Clean up local variables in sm501_2d_operation Gerd Hoffmann
2020-05-28 12:36 ` [PULL 19/21] sm501: Replace hand written implementation with pixman where possible Gerd Hoffmann
2020-05-28 12:36 ` [PULL 20/21] sm501: Optimize small overlapping blits Gerd Hoffmann
2020-05-28 12:36 ` [PULL 21/21] sm501: Remove obsolete changelog and todo comment Gerd Hoffmann
2020-05-28 19:25 ` [PULL 00/21] Vga 20200528 patches no-reply
2020-05-29 10:29 ` Peter Maydell
2020-05-29 16:15   ` Philippe Mathieu-Daudé
2020-05-29 16:36     ` Peter Maydell
2020-05-29 16:47       ` Philippe Mathieu-Daudé
2020-06-02  9:48       ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200528123609.27362-2-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=alistair@alistair23.me \
    --cc=edgar.iglesias@gmail.com \
    --cc=f4bug@amsat.org \
    --cc=i.mitsyanko@gmail.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.