From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49D9AC433DF for ; Thu, 28 May 2020 14:32:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1ECD720897 for ; Thu, 28 May 2020 14:32:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590676330; bh=akyLuHeiAlZIZHfR0soky+wL6Do/cboTPXXRrmLbVcM=; h=From:To:Cc:Subject:Date:List-ID:From; b=u2MwMA0dB7z+G6ad2Rsb3OUvkh/wlL0qGRzBhYeG+JjdMgg4n0ND3vvwvGX8Rz/74 v26eiFHjm2Gt9yGGNStIiEcwXmUkzbsMCzrn4kvWeltWd4csm3t9lwIR0sDebytw+O V3Ri9J1fbGICuBgcyiEVdoihXHBzOhSHpPWpxnoQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391170AbgE1OcJ (ORCPT ); Thu, 28 May 2020 10:32:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:37944 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391060AbgE1OcI (ORCPT ); Thu, 28 May 2020 10:32:08 -0400 Received: from pali.im (pali.im [31.31.79.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0F098207D3; Thu, 28 May 2020 14:32:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590676328; bh=akyLuHeiAlZIZHfR0soky+wL6Do/cboTPXXRrmLbVcM=; h=From:To:Cc:Subject:Date:From; b=d2K+pAeTDZ5RpezmH6ZH/G46972OO1eS9ejtgl4eRc+z7CDanFwXHD1jvVuStpsI5 fwr7nmGoeDP3rq4Ie9BtO8Gr19T8OYE3cDJ41T8Iz8Mgrg0s9egdszpU5+1TEu6Rgk rRysRM5YScuyL1XYDRPU9YQDjqjugHwQLtkIgmaI= Received: by pali.im (Postfix) id 8BC2B865; Thu, 28 May 2020 16:32:05 +0200 (CEST) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Thomas Petazzoni , Lorenzo Pieralisi , Andrew Murray , Bjorn Helgaas , =?UTF-8?q?Marek=20Beh=C3=BAn?= , Remi Pommarel , Tomasz Maciej Nowak , Xogium Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] PCI: aardvark: Don't touch PCIe registers if no card connected Date: Thu, 28 May 2020 16:31:41 +0200 Message-Id: <20200528143141.29956-1-pali@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When there is no PCIe card connected and advk_pcie_rd_conf() or advk_pcie_wr_conf() is called for PCI bus which doesn't belong to emulated root bridge, the aardvark driver throws the following error message: advk-pcie d0070000.pcie: config read/write timed out Obviously accessing PCIe registers of disconnected card is not possible. Extend check in advk_pcie_valid_device() function for validating availability of PCIe bus. If PCIe link is down, then the device is marked as Not Found and the driver does not try to access these registers. Signed-off-by: Pali Rohár --- drivers/pci/controller/pci-aardvark.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c index 90ff291c24f0..53a4cfd7d377 100644 --- a/drivers/pci/controller/pci-aardvark.c +++ b/drivers/pci/controller/pci-aardvark.c @@ -644,6 +644,9 @@ static bool advk_pcie_valid_device(struct advk_pcie *pcie, struct pci_bus *bus, if ((bus->number == pcie->root_bus_nr) && PCI_SLOT(devfn) != 0) return false; + if (bus->number != pcie->root_bus_nr && !advk_pcie_link_up(pcie)) + return false; + return true; } -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 209FAC433DF for ; Thu, 28 May 2020 14:32:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD560207D3 for ; Thu, 28 May 2020 14:32:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kZHoskoJ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="d2K+pAeT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD560207D3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=EL9qjniwwxz1PSbt6OeMmg4hOQtMTqO7wgf85Bmkpgo=; b=kZHoskoJOYZUUd wKni4vE+UJtrmk+m3AJHHcPIjarSSNlhYNvfGY4pveayE2QvoJIRMMajw5cEIf+8KVsB1BXo69aMJ lA1pVDRPiVA0gKeCID9Qj56ubiAP20rzVI3lLve6FpgpY9zqKsz5ROy3aeWOT8ay2jeZJBOUG8Nf5 0iznJAhUPuVSzyVHs6aIyKrVPalVoIzO95Fa9xso4fSG3t9kCvDuVHvXDKQUDB6YfpUvrvzTYMHXr eyPKaw1VHfyr4VAvZhzZCE7KShoIXaDRiZ4TSj6qf1yfwYaCxxNgBI6OcS4SCHwS7PFJKw76uqClt vD3yAqGtEXxhohq7qwqA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeJa6-0003dn-VS; Thu, 28 May 2020 14:32:26 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeJZp-0003Mi-RP for linux-arm-kernel@lists.infradead.org; Thu, 28 May 2020 14:32:11 +0000 Received: from pali.im (pali.im [31.31.79.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0F098207D3; Thu, 28 May 2020 14:32:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590676328; bh=akyLuHeiAlZIZHfR0soky+wL6Do/cboTPXXRrmLbVcM=; h=From:To:Cc:Subject:Date:From; b=d2K+pAeTDZ5RpezmH6ZH/G46972OO1eS9ejtgl4eRc+z7CDanFwXHD1jvVuStpsI5 fwr7nmGoeDP3rq4Ie9BtO8Gr19T8OYE3cDJ41T8Iz8Mgrg0s9egdszpU5+1TEu6Rgk rRysRM5YScuyL1XYDRPU9YQDjqjugHwQLtkIgmaI= Received: by pali.im (Postfix) id 8BC2B865; Thu, 28 May 2020 16:32:05 +0200 (CEST) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Thomas Petazzoni , Lorenzo Pieralisi , Andrew Murray , Bjorn Helgaas , =?UTF-8?q?Marek=20Beh=C3=BAn?= , Remi Pommarel , Tomasz Maciej Nowak , Xogium Subject: [PATCH] PCI: aardvark: Don't touch PCIe registers if no card connected Date: Thu, 28 May 2020 16:31:41 +0200 Message-Id: <20200528143141.29956-1-pali@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200528_073209_912735_D8EC3D1F X-CRM114-Status: GOOD ( 12.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org V2hlbiB0aGVyZSBpcyBubyBQQ0llIGNhcmQgY29ubmVjdGVkIGFuZCBhZHZrX3BjaWVfcmRfY29u ZigpIG9yCmFkdmtfcGNpZV93cl9jb25mKCkgaXMgY2FsbGVkIGZvciBQQ0kgYnVzIHdoaWNoIGRv ZXNuJ3QgYmVsb25nIHRvIGVtdWxhdGVkCnJvb3QgYnJpZGdlLCB0aGUgYWFyZHZhcmsgZHJpdmVy IHRocm93cyB0aGUgZm9sbG93aW5nIGVycm9yIG1lc3NhZ2U6CgogIGFkdmstcGNpZSBkMDA3MDAw MC5wY2llOiBjb25maWcgcmVhZC93cml0ZSB0aW1lZCBvdXQKCk9idmlvdXNseSBhY2Nlc3Npbmcg UENJZSByZWdpc3RlcnMgb2YgZGlzY29ubmVjdGVkIGNhcmQgaXMgbm90IHBvc3NpYmxlLgoKRXh0 ZW5kIGNoZWNrIGluIGFkdmtfcGNpZV92YWxpZF9kZXZpY2UoKSBmdW5jdGlvbiBmb3IgdmFsaWRh dGluZwphdmFpbGFiaWxpdHkgb2YgUENJZSBidXMuIElmIFBDSWUgbGluayBpcyBkb3duLCB0aGVu IHRoZSBkZXZpY2UgaXMgbWFya2VkCmFzIE5vdCBGb3VuZCBhbmQgdGhlIGRyaXZlciBkb2VzIG5v dCB0cnkgdG8gYWNjZXNzIHRoZXNlIHJlZ2lzdGVycy4KClNpZ25lZC1vZmYtYnk6IFBhbGkgUm9o w6FyIDxwYWxpQGtlcm5lbC5vcmc+Ci0tLQogZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2ktYWFy ZHZhcmsuYyB8IDMgKysrCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspCgpkaWZmIC0t Z2l0IGEvZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2ktYWFyZHZhcmsuYyBiL2RyaXZlcnMvcGNp L2NvbnRyb2xsZXIvcGNpLWFhcmR2YXJrLmMKaW5kZXggOTBmZjI5MWMyNGYwLi41M2E0Y2ZkN2Qz NzcgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpLWFhcmR2YXJrLmMKKysr IGIvZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2ktYWFyZHZhcmsuYwpAQCAtNjQ0LDYgKzY0NCw5 IEBAIHN0YXRpYyBib29sIGFkdmtfcGNpZV92YWxpZF9kZXZpY2Uoc3RydWN0IGFkdmtfcGNpZSAq cGNpZSwgc3RydWN0IHBjaV9idXMgKmJ1cywKIAlpZiAoKGJ1cy0+bnVtYmVyID09IHBjaWUtPnJv b3RfYnVzX25yKSAmJiBQQ0lfU0xPVChkZXZmbikgIT0gMCkKIAkJcmV0dXJuIGZhbHNlOwogCisJ aWYgKGJ1cy0+bnVtYmVyICE9IHBjaWUtPnJvb3RfYnVzX25yICYmICFhZHZrX3BjaWVfbGlua191 cChwY2llKSkKKwkJcmV0dXJuIGZhbHNlOworCiAJcmV0dXJuIHRydWU7CiB9CiAKLS0gCjIuMjAu MQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4 LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFy bS1rZXJuZWwK