From: Thomas Gleixner <tglx@linutronix.de> To: LKML <linux-kernel@vger.kernel.org> Cc: x86@kernel.org Subject: [patch 3/5] x86/idt: Use proper constants for table sizes Date: Thu, 28 May 2020 16:53:18 +0200 [thread overview] Message-ID: <20200528145522.898591501@linutronix.de> (raw) In-Reply-To: <20200528145315.727724091@linutronix.de> Use the actual struct size to calculate the IDT table sizes instead of two different hardcoded values. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> --- arch/x86/kernel/idt.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) --- a/arch/x86/kernel/idt.c +++ b/arch/x86/kernel/idt.c @@ -51,6 +51,8 @@ struct idt_data { #define TSKG(_vector, _gdt) \ G(_vector, NULL, DEFAULT_STACK, GATE_TASK, DPL0, _gdt << 3) +#define IDT_TABLE_SIZE (IDT_ENTRIES * sizeof(gate_desc)) +#define IDT_DEBUG_TABLE_SIZE (16 * sizeof(gate_desc)) static bool idt_setup_done __initdata; @@ -176,7 +178,7 @@ static const __initconst struct idt_data gate_desc idt_table[IDT_ENTRIES] __page_aligned_bss; struct desc_ptr idt_descr __ro_after_init = { - .size = (IDT_ENTRIES * 2 * sizeof(unsigned long)) - 1, + .size = IDT_TABLE_SIZE - 1, .address = (unsigned long) idt_table, }; @@ -202,7 +204,7 @@ static const __initconst struct idt_data * stack set to DEFAULT_STACK (0). Required for NMI trap handling. */ const struct desc_ptr debug_idt_descr = { - .size = IDT_ENTRIES * 16 - 1, + .size = IDT_DEBUG_TABLE_SIZE - 1, .address = (unsigned long) debug_idt_table, }; #endif @@ -304,9 +306,10 @@ void __init idt_setup_ist_traps(void) */ void __init idt_setup_debugidt_traps(void) { - memcpy(&debug_idt_table, &idt_table, IDT_ENTRIES * 16); + memcpy(&debug_idt_table, &idt_table, IDT_DEBUG_TABLE_SIZE); - idt_setup_from_table(debug_idt_table, dbg_idts, ARRAY_SIZE(dbg_idts), false); + idt_setup_from_table(debug_idt_table, dbg_idts, ARRAY_SIZE(dbg_idts), + false); } #endif
next prev parent reply other threads:[~2020-05-28 14:56 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-28 14:53 [patch 0/5] x86/idt: Cleanups and consolidation Thomas Gleixner 2020-05-28 14:53 ` [patch 1/5] x86/idt: Mark init only functions __init Thomas Gleixner 2020-05-30 9:57 ` [tip: x86/entry] " tip-bot2 for Thomas Gleixner 2020-05-28 14:53 ` [patch 2/5] x86/idt: Add comments about early #PF handling Thomas Gleixner 2020-05-28 16:14 ` Peter Zijlstra 2020-05-28 18:44 ` Thomas Gleixner 2020-05-30 9:57 ` [tip: x86/entry] " tip-bot2 for Thomas Gleixner 2020-05-28 14:53 ` Thomas Gleixner [this message] 2020-05-30 9:57 ` [tip: x86/entry] x86/idt: Use proper constants for table size tip-bot2 for Thomas Gleixner 2020-05-28 14:53 ` [patch 4/5] x86/idt: Cleanup trap_init() Thomas Gleixner 2020-05-30 9:57 ` [tip: x86/entry] " tip-bot2 for Thomas Gleixner 2020-05-28 14:53 ` [patch 5/5] x86/idt: Consolidate idt functionality Thomas Gleixner 2020-05-28 16:16 ` Peter Zijlstra 2020-05-30 9:57 ` [tip: x86/entry] " tip-bot2 for Thomas Gleixner 2020-06-01 12:55 ` tip-bot2 for Thomas Gleixner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200528145522.898591501@linutronix.de \ --to=tglx@linutronix.de \ --cc=linux-kernel@vger.kernel.org \ --cc=x86@kernel.org \ --subject='Re: [patch 3/5] x86/idt: Use proper constants for table sizes' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.