From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16CECC433DF for ; Thu, 28 May 2020 16:43:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F351920829 for ; Thu, 28 May 2020 16:43:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405088AbgE1QnB (ORCPT ); Thu, 28 May 2020 12:43:01 -0400 Received: from verein.lst.de ([213.95.11.211]:57285 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405075AbgE1QnA (ORCPT ); Thu, 28 May 2020 12:43:00 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id DE5B068AFE; Thu, 28 May 2020 18:42:56 +0200 (CEST) Date: Thu, 28 May 2020 18:42:56 +0200 From: Christoph Hellwig To: Keith Busch Cc: linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me, linux-block@vger.kernel.org, axboe@kernel.dk Subject: Re: [PATCHv2 1/2] blk-mq: export __blk_mq_complete_request Message-ID: <20200528164256.GA25651@lst.de> References: <20200528151931.3501506-1-kbusch@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200528151931.3501506-1-kbusch@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, May 28, 2020 at 08:19:30AM -0700, Keith Busch wrote: > For when drivers have a need to bypass error injection. EXPORT_SYMBOL_GPL, and as hinted I think this needs a better name. It also absolutely needs a kerneldoc comment describing the use case. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 005CDC433DF for ; Thu, 28 May 2020 16:43:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C2CE92075A for ; Thu, 28 May 2020 16:43:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GHK30OYX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C2CE92075A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LzcYNYk6m9C/DXAnT8j7tgKRs6+tv7cR355E9HkZhsQ=; b=GHK30OYXvbhvtY vj8qQ9+5mbLMbeq2ybLS/Od8retv6Q4WRXbIZSp+97FwU9JMAi8/jwNM9p2EhChWgf21PMBQ4GroU WjFSGAdE4aYcIFEYklWfmCnu35GjG/urBvaiQX5gOerlmD1v3/A7zqGaHMe4OWsKwmggsBfogcPeE lceDvnsZVeLJMSKQqNfy5RkG9nrkTWdz2i25LNkU4dL7/ZJoc9DoqaH881IKSCgCd+/1U3Pamt33j uNaaQQ0Rb//5awwuwyVnjmiT4fPbu6hNARXOXZceJVdyK3im5iuf6kjeTr9yDX2BPsC2XJ8Ef3dD5 BU4VfOeNLtD1GIF2HszA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeLcY-0007Tw-05; Thu, 28 May 2020 16:43:06 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeLcU-0007T3-PK for linux-nvme@lists.infradead.org; Thu, 28 May 2020 16:43:04 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id DE5B068AFE; Thu, 28 May 2020 18:42:56 +0200 (CEST) Date: Thu, 28 May 2020 18:42:56 +0200 From: Christoph Hellwig To: Keith Busch Subject: Re: [PATCHv2 1/2] blk-mq: export __blk_mq_complete_request Message-ID: <20200528164256.GA25651@lst.de> References: <20200528151931.3501506-1-kbusch@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200528151931.3501506-1-kbusch@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200528_094302_972073_F07D6ADC X-CRM114-Status: UNSURE ( 6.52 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-block@vger.kernel.org, axboe@kernel.dk, hch@lst.de, linux-nvme@lists.infradead.org, sagi@grimberg.me Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, May 28, 2020 at 08:19:30AM -0700, Keith Busch wrote: > For when drivers have a need to bypass error injection. EXPORT_SYMBOL_GPL, and as hinted I think this needs a better name. It also absolutely needs a kerneldoc comment describing the use case. _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme