From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A46DEC433DF for ; Thu, 28 May 2020 15:57:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A0D52053B for ; Thu, 28 May 2020 15:57:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404511AbgE1P5A (ORCPT ); Thu, 28 May 2020 11:57:00 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:55694 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404637AbgE1P5A (ORCPT ); Thu, 28 May 2020 11:57:00 -0400 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 726632A336C; Thu, 28 May 2020 16:56:58 +0100 (BST) Date: Thu, 28 May 2020 17:56:56 +0200 From: Boris Brezillon To: Miquel Raynal Cc: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , , Rob Herring , Mark Rutland , , Thomas Petazzoni , Paul Cercueil , Chuanhong Guo , Weijie Gao , , Mason Yang , Julien Su Subject: Re: [PATCH v6 18/18] mtd: rawnand: Move generic bits to the ECC framework Message-ID: <20200528175656.0a32dd7c@collabora.com> In-Reply-To: <20200528113113.9166-19-miquel.raynal@bootlin.com> References: <20200528113113.9166-1-miquel.raynal@bootlin.com> <20200528113113.9166-19-miquel.raynal@bootlin.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 28 May 2020 13:31:13 +0200 Miquel Raynal wrote: > +/** > + * nanddev_get_flash_node() - Get the device node attached to a NAND device > + * @nand: NAND device > + * > + * Return: the device node linked to @nand. > + */ > +static inline struct device_node *nanddev_get_flash_node(struct nand_device *nand) > +{ > + return mtd_get_of_node(nanddev_to_mtd(nand)); > +} > + Can we name that one nanddev_get_of_node(). We'll probably want to expose fwnode at some point, and get_flash_node() is a bit too generic IMO. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60786C433E0 for ; Thu, 28 May 2020 15:57:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C3792053B for ; Thu, 28 May 2020 15:57:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="shRTUvrT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C3792053B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5zk+DAHBiaNPM5ec+mhVaFvK/WyR2BTqnaQUmvhzCdA=; b=shRTUvrT3m5Sml XkUPVoNPyRi+FTlkhjZ4DQvFZi8/aziDksYUDoCgXhVASLyKKdt11AnaORCTFXfnS6puo5sFe3gW4 sn28bv+6OUZqOvxLdzH5QVDWIxp1t0dfLKz0PpAebEYZWu3iLsuYZKM9ELD1m/qSp0j0Vn83qrtJP fx3pouxWVIFTlYPlm7FcqtsCIbeLZEhpAf8fhDLvOyiq2J8FotVMle2IO3bJbansmOvdqXwxdd74J HtR3vgviLipJ8cXkB0MC+/c+Y0Y7oQ4oTL9x2WG6ELMi2sSdAHIMjRYEJ9zU6bcOAVD1ev0FpvSr8 W6+Brgvnj43+rmeI5+cA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeKu6-0003iV-VX; Thu, 28 May 2020 15:57:11 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeKtv-0003ZT-TP; Thu, 28 May 2020 15:57:01 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 726632A336C; Thu, 28 May 2020 16:56:58 +0100 (BST) Date: Thu, 28 May 2020 17:56:56 +0200 From: Boris Brezillon To: Miquel Raynal Subject: Re: [PATCH v6 18/18] mtd: rawnand: Move generic bits to the ECC framework Message-ID: <20200528175656.0a32dd7c@collabora.com> In-Reply-To: <20200528113113.9166-19-miquel.raynal@bootlin.com> References: <20200528113113.9166-1-miquel.raynal@bootlin.com> <20200528113113.9166-19-miquel.raynal@bootlin.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200528_085700_074121_10EF8249 X-CRM114-Status: GOOD ( 11.73 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Vignesh Raghavendra , Tudor Ambarus , Julien Su , Richard Weinberger , Weijie Gao , Paul Cercueil , Rob Herring , linux-mtd@lists.infradead.org, Thomas Petazzoni , Mason Yang , Chuanhong Guo , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Thu, 28 May 2020 13:31:13 +0200 Miquel Raynal wrote: > +/** > + * nanddev_get_flash_node() - Get the device node attached to a NAND device > + * @nand: NAND device > + * > + * Return: the device node linked to @nand. > + */ > +static inline struct device_node *nanddev_get_flash_node(struct nand_device *nand) > +{ > + return mtd_get_of_node(nanddev_to_mtd(nand)); > +} > + Can we name that one nanddev_get_of_node(). We'll probably want to expose fwnode at some point, and get_flash_node() is a bit too generic IMO. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEE59C433E0 for ; Thu, 28 May 2020 15:57:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B60B02053B for ; Thu, 28 May 2020 15:57:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="f91hg45P" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B60B02053B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ig9ZsDWI7SR/HLoB8VbyHsbVU4zlkr9xVvyS3tHMOFo=; b=f91hg45PnIwRVD dRZ7P+vsuIxewdCovFSUHXzdWIWtV0QE+kHqDQUF00Xw36zQPbLflb+FOw1BD4VfhqFByuDr+YljV AnGBUV6yn3u5Lyx0F18hfubEafs5WJOaUbgYEr+oM9iiag6tNgJOmO9ceamN7J+fGdl6w6n9fa6sn v/8cGCpJyF5+PfNZjqFdIUW1uq+b+HCTVbnRKsNH4+E8reEYkGk5Fc1qioiX6B6prin6qXFWMOmsF s0cgxrYI79EjcT1Cw6S+EM4wi/hxnf0aT0G4eSAKGsp/u1WPT7z2DYmpRwz+yrlsXc6unYH7lYsZK hGR9jTVuecbn6zmP3KAQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeKty-0003Zw-E3; Thu, 28 May 2020 15:57:02 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeKtv-0003ZT-TP; Thu, 28 May 2020 15:57:01 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 726632A336C; Thu, 28 May 2020 16:56:58 +0100 (BST) Date: Thu, 28 May 2020 17:56:56 +0200 From: Boris Brezillon To: Miquel Raynal Subject: Re: [PATCH v6 18/18] mtd: rawnand: Move generic bits to the ECC framework Message-ID: <20200528175656.0a32dd7c@collabora.com> In-Reply-To: <20200528113113.9166-19-miquel.raynal@bootlin.com> References: <20200528113113.9166-1-miquel.raynal@bootlin.com> <20200528113113.9166-19-miquel.raynal@bootlin.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200528_085700_074121_10EF8249 X-CRM114-Status: GOOD ( 11.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Vignesh Raghavendra , Tudor Ambarus , Julien Su , Richard Weinberger , Weijie Gao , Paul Cercueil , Rob Herring , linux-mtd@lists.infradead.org, Thomas Petazzoni , Mason Yang , Chuanhong Guo , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 28 May 2020 13:31:13 +0200 Miquel Raynal wrote: > +/** > + * nanddev_get_flash_node() - Get the device node attached to a NAND device > + * @nand: NAND device > + * > + * Return: the device node linked to @nand. > + */ > +static inline struct device_node *nanddev_get_flash_node(struct nand_device *nand) > +{ > + return mtd_get_of_node(nanddev_to_mtd(nand)); > +} > + Can we name that one nanddev_get_of_node(). We'll probably want to expose fwnode at some point, and get_flash_node() is a bit too generic IMO. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel