From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19AB6C433DF for ; Thu, 28 May 2020 20:38:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EBD922073B for ; Thu, 28 May 2020 20:38:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407328AbgE1UiT (ORCPT ); Thu, 28 May 2020 16:38:19 -0400 Received: from muru.com ([72.249.23.125]:56084 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407218AbgE1UiP (ORCPT ); Thu, 28 May 2020 16:38:15 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 8EE1580BF; Thu, 28 May 2020 20:39:03 +0000 (UTC) Date: Thu, 28 May 2020 13:38:10 -0700 From: Tony Lindgren To: Arnd Bergmann Cc: Santosh Shilimkar , arm-soc , Rob Herring , Grygorii Strashko , Geert Uytterhoeven , Lokesh Vutla , Keerthy , "linux-kernel@vger.kernel.org" , Tero Kristo , Olof Johansson , linux-omap , afzal mohammed , Linux ARM Subject: Re: [PATCH] ARM: omap2: drop broken broadcast timer hack Message-ID: <20200528203810.GQ37466@atomide.com> References: <20200528091923.2951100-1-arnd@arndb.de> <20200528134621.GN37466@atomide.com> <20200528135057.GO37466@atomide.com> <20200528155759.GP37466@atomide.com> <34e8fb61-b452-529b-b2c6-3849b2395096@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Arnd Bergmann [200528 20:35]: > On Thu, May 28, 2020 at 6:18 PM wrote: > > On 5/28/20 8:57 AM, Tony Lindgren wrote: > > > * Tony Lindgren [200528 13:51]: > > >> * Tony Lindgren [200528 13:47]: > > >>> * Arnd Bergmann [200528 09:20]: > > >>>> The OMAP4 timer code had a special hack for using the broadcast timer > > >>>> without SMP. Since the dmtimer is now gone, this also needs to be dropped > > >>>> to avoid a link failure for non-SMP AM43xx configurations: > > >>>> > > >>>> kernel/time/tick-broadcast.o: in function `tick_device_uses_broadcast': > > >>>> tick-broadcast.c:(.text+0x130): undefined reference to `tick_broadcast' > > >>> > > >>> Hmm this sounds like a regression though. Isn't this needed for using > > >>> the ARM local timers on non-SMP SoC, so a separate timer from dmtimer? > > >>> > > >>> I've probably removed something accidentally to cause this. > > >> > > >> Sounds like arch/arm/mach-omap2/Makefile change needs to be removed > > >> to always still build in timer.o. And probably timer.c needs back > > >> the ifdef for CONFIG_SOC_HAS_REALTIME_COUNTER. > > >> > > >> I'll take a look today. > > > > > > I've sent a patch along those lines as: > > > > > > [PATCH] ARM: OMAP2+: Fix regression for using local timer on non-SMP SoCs > > > > > > A link for the patch at [0] below. > > > > > CPU local timers not being in always ON power domain use to be the > > reason on early version of the SOCs but later SOC moved the CPU local > > timer also in always on domain. Probably AM43xx does loose local timer > > on CPU PD in low power so yes broadcast would be needed with dmtimer > > help. > > > > > > > > [0] https://lore.kernel.org/linux-omap/20200528155453.8585-1-tony@atomide.com/T/#u > > > > > This should restore it. > > Should I apply the fix directly to the arm/soc branch that has the > other changes then? Sure please do, that saves a single-fix pull request. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D68DC433E1 for ; Thu, 28 May 2020 20:38:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 15A43212CC for ; Thu, 28 May 2020 20:38:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ac3gvyoT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 15A43212CC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S0Qaz9GqOBh3I35FcZwLtJLwWp/9LF9GROt6r/UD0WQ=; b=Ac3gvyoTdmZ9+b ESjtktB1WrleMkcS8m3cjRlJnKNE2Cf7QTQYjKFq53Nlqs7IyBAgMdybtBtK21UtbYAudJfOn+hY+ lDvkX4o2gJhFsQNZWZ63W1mZ6xHrsVjrJLiqSYyKZtwiIGMYPyPs02rrjI6upis0qyY+9lbrhw1qq g2Zsef09+F2G1OhV4o9ACyusK3Y0lwf8YtfHjmGwHEe8673GG0w+GJr39fokIJk3yR+UKjzcvKeQk gFec+7rab01bULGRErSZnbQkk+YBYfhZNalVOC800igNnbe8gqjvU9AmNc500cQAyCKMhKR2Cgzc7 0y9LydDee5N9+o8diIEA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jePIB-0000Dl-Dk; Thu, 28 May 2020 20:38:19 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jePI8-0000Cs-9M for linux-arm-kernel@lists.infradead.org; Thu, 28 May 2020 20:38:17 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 8EE1580BF; Thu, 28 May 2020 20:39:03 +0000 (UTC) Date: Thu, 28 May 2020 13:38:10 -0700 From: Tony Lindgren To: Arnd Bergmann Subject: Re: [PATCH] ARM: omap2: drop broken broadcast timer hack Message-ID: <20200528203810.GQ37466@atomide.com> References: <20200528091923.2951100-1-arnd@arndb.de> <20200528134621.GN37466@atomide.com> <20200528135057.GO37466@atomide.com> <20200528155759.GP37466@atomide.com> <34e8fb61-b452-529b-b2c6-3849b2395096@oracle.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200528_133816_366434_4E067870 X-CRM114-Status: GOOD ( 17.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Grygorii Strashko , Geert Uytterhoeven , Lokesh Vutla , Keerthy , Santosh Shilimkar , "linux-kernel@vger.kernel.org" , Tero Kristo , arm-soc , Olof Johansson , linux-omap , afzal mohammed , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Arnd Bergmann [200528 20:35]: > On Thu, May 28, 2020 at 6:18 PM wrote: > > On 5/28/20 8:57 AM, Tony Lindgren wrote: > > > * Tony Lindgren [200528 13:51]: > > >> * Tony Lindgren [200528 13:47]: > > >>> * Arnd Bergmann [200528 09:20]: > > >>>> The OMAP4 timer code had a special hack for using the broadcast timer > > >>>> without SMP. Since the dmtimer is now gone, this also needs to be dropped > > >>>> to avoid a link failure for non-SMP AM43xx configurations: > > >>>> > > >>>> kernel/time/tick-broadcast.o: in function `tick_device_uses_broadcast': > > >>>> tick-broadcast.c:(.text+0x130): undefined reference to `tick_broadcast' > > >>> > > >>> Hmm this sounds like a regression though. Isn't this needed for using > > >>> the ARM local timers on non-SMP SoC, so a separate timer from dmtimer? > > >>> > > >>> I've probably removed something accidentally to cause this. > > >> > > >> Sounds like arch/arm/mach-omap2/Makefile change needs to be removed > > >> to always still build in timer.o. And probably timer.c needs back > > >> the ifdef for CONFIG_SOC_HAS_REALTIME_COUNTER. > > >> > > >> I'll take a look today. > > > > > > I've sent a patch along those lines as: > > > > > > [PATCH] ARM: OMAP2+: Fix regression for using local timer on non-SMP SoCs > > > > > > A link for the patch at [0] below. > > > > > CPU local timers not being in always ON power domain use to be the > > reason on early version of the SOCs but later SOC moved the CPU local > > timer also in always on domain. Probably AM43xx does loose local timer > > on CPU PD in low power so yes broadcast would be needed with dmtimer > > help. > > > > > > > > [0] https://lore.kernel.org/linux-omap/20200528155453.8585-1-tony@atomide.com/T/#u > > > > > This should restore it. > > Should I apply the fix directly to the arm/soc branch that has the > other changes then? Sure please do, that saves a single-fix pull request. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel