All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Marek Vasut <marex@denx.de>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
	Lukas Wunner <lukas@wunner.de>, Petr Stetiar <ynezz@true.cz>,
	YueHaibing <yuehaibing@huawei.com>
Subject: Re: [PATCH V7 04/19] net: ks8851: Pass device node into ks8851_init_mac()
Date: Fri, 29 May 2020 00:26:34 +0200	[thread overview]
Message-ID: <20200528222634.GC853774@lunn.ch> (raw)
In-Reply-To: <20200528222146.348805-5-marex@denx.de>

On Fri, May 29, 2020 at 12:21:31AM +0200, Marek Vasut wrote:
> Since the driver probe function already has a struct device *dev pointer
> and can easily derive of_node pointer from it, pass the of_node pointer as
> a parameter to ks8851_init_mac() to avoid fishing it out from ks->spidev.
> This is the only reference to spidev in the function, so get rid of it.
> This is done in preparation for unifying the KS8851 SPI and parallel bus
> drivers.
> 
> No functional change.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

  reply	other threads:[~2020-05-28 22:27 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-28 22:21 [PATCH V7 00/19] net: ks8851: Unify KS8851 SPI and MLL drivers Marek Vasut
2020-05-28 22:21 ` [PATCH V7 01/19] net: ks8851: Factor out spi->dev in probe()/remove() Marek Vasut
2020-05-28 22:21 ` [PATCH V7 02/19] net: ks8851: Rename ndev to netdev in probe Marek Vasut
2020-05-28 22:21 ` [PATCH V7 03/19] net: ks8851: Replace dev_err() with netdev_err() in IRQ handler Marek Vasut
2020-05-28 22:21 ` [PATCH V7 04/19] net: ks8851: Pass device node into ks8851_init_mac() Marek Vasut
2020-05-28 22:26   ` Andrew Lunn [this message]
2020-05-28 22:21 ` [PATCH V7 05/19] net: ks8851: Use devm_alloc_etherdev() Marek Vasut
2020-05-28 22:21 ` [PATCH V7 06/19] net: ks8851: Use dev_{get,set}_drvdata() Marek Vasut
2020-05-28 22:21 ` [PATCH V7 07/19] net: ks8851: Remove ks8851_rdreg32() Marek Vasut
2020-05-28 22:27   ` Andrew Lunn
2020-05-28 22:21 ` [PATCH V7 08/19] net: ks8851: Use 16-bit writes to program MAC address Marek Vasut
2020-05-28 22:21 ` [PATCH V7 09/19] net: ks8851: Use 16-bit read of RXFC register Marek Vasut
2020-05-28 22:29   ` Andrew Lunn
2020-05-28 22:21 ` [PATCH V7 10/19] net: ks8851: Factor out bus lock handling Marek Vasut
2020-05-28 22:21 ` [PATCH V7 11/19] net: ks8851: Factor out SKB receive function Marek Vasut
2020-05-28 22:29   ` Andrew Lunn
2020-05-28 22:21 ` [PATCH V7 12/19] net: ks8851: Split out SPI specific entries in struct ks8851_net Marek Vasut
2020-05-28 22:21 ` [PATCH V7 13/19] net: ks8851: Split out SPI specific code from probe() and remove() Marek Vasut
2020-05-28 22:21 ` [PATCH V7 14/19] net: ks8851: Factor out TX work flush function Marek Vasut
2020-05-28 22:21 ` [PATCH V7 15/19] net: ks8851: Permit overridding interrupt enable register Marek Vasut
2020-05-28 22:21 ` [PATCH V7 16/19] net: ks8851: Implement register, FIFO, lock accessor callbacks Marek Vasut
2020-05-28 22:21 ` [PATCH V7 17/19] net: ks8851: Separate SPI operations into separate file Marek Vasut
2020-05-28 22:21 ` [PATCH V7 18/19] net: ks8851: Implement Parallel bus operations Marek Vasut
2020-05-28 22:35   ` Andrew Lunn
2020-05-28 22:21 ` [PATCH V7 19/19] net: ks8851: Remove ks8851_mll.c Marek Vasut
2020-05-28 22:33   ` Andrew Lunn
2020-05-28 23:30 ` [PATCH V7 00/19] net: ks8851: Unify KS8851 SPI and MLL drivers David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200528222634.GC853774@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=lukas@wunner.de \
    --cc=marex@denx.de \
    --cc=netdev@vger.kernel.org \
    --cc=ynezz@true.cz \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.