From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E1EDC433DF for ; Fri, 29 May 2020 03:16:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E862F2075F for ; Fri, 29 May 2020 03:16:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="R/p0GsIG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391660AbgE2DQ2 (ORCPT ); Thu, 28 May 2020 23:16:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390190AbgE2DQ1 (ORCPT ); Thu, 28 May 2020 23:16:27 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96C1AC08C5C8 for ; Thu, 28 May 2020 20:16:26 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id t16so464401plo.7 for ; Thu, 28 May 2020 20:16:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xBYSOZ99yeQDDwcg84UQj/J2oS6UqYxmljieBL0TXDQ=; b=R/p0GsIG7LAKQvppr80JcPfO0lsLrZ23GICGf/kQTwCTO7sa7RxUTV3pbtf4pk78UQ wL0WnxOJR0MSG3d3XwT2TTYOVjQTfzqS5nAA0FPnvjLrMPs7AAFLOQb/0JlNe385+Yuc aS1rgbzn21sbs1cO6/rbemQzp09pYQEAzUvdHf+V8a//9dbGlpvVUyr6muM84gEl52yE 0yGghTv1SWWlKCQJLpUHXbdlGmK2T9TmpE/lDWVivXYv1Ee7j7s03LA/5tRW7Bd3T4Ud BDQpjKMIyi+BxsRg4cQkY8/qnHQKoymyiPtPAHre+tJ2Tup6KQGlXyl19f/znppy8CY9 Xi4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xBYSOZ99yeQDDwcg84UQj/J2oS6UqYxmljieBL0TXDQ=; b=cdJFhvV0thj9y7i6AMbwSB6OYe5TPUz5zq2nlWSnD8PzjCsALqv7lP6iUhR0XvK2Fm u+8m2Jnp/yzaSt7F1UP223wXfquSfKc1gdmNczZU7nnNB4f3k1m8uDM80o+hRVmwo+m9 5nDhx7rtpn8FKD2UZUzqfBkz69DR9FtksWSvQWPogiA1Uo8I9xVgbQG+vhyJfuLjVUoa w9qujEy4S9TSwdcLOqUijv5S5nIWNzN6Gq6oqQZ+Uvonfnph9hZTaR8sEmBl5qy/gwNS DNyQExEcW3Fv2ao/bsT3BZ+3SYModoQO6JjJGFNFtB51RMKSISU7muIgTI/lwJynGvWK FkfA== X-Gm-Message-State: AOAM530ZotejQTjR6wtGDhyvddZG5ZzXxrJTBjdQekltQtaAef/EQ5Vd bVrbgdqt021YA10iNzlxNotAlsMhuts= X-Google-Smtp-Source: ABdhPJy16q7kVGr1kuNIRKxaUU7CzK1khrd/ICI5Mfpk53w3KlzidqUW5/X0Tkf/FR6suKS5hAahTg== X-Received: by 2002:a17:902:b216:: with SMTP id t22mr7045362plr.36.1590722185946; Thu, 28 May 2020 20:16:25 -0700 (PDT) Received: from builder.lan (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id m2sm5745815pfe.41.2020.05.28.20.16.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2020 20:16:25 -0700 (PDT) Date: Thu, 28 May 2020 20:15:20 -0700 From: Bjorn Andersson To: Jonathan Marek Cc: linux-arm-msm@vger.kernel.org, Andy Gross , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [PATCH 1/6] arm64: dts: qcom: sm8150: add apps_smmu node Message-ID: <20200529031520.GA1799770@builder.lan> References: <20200524023815.21789-1-jonathan@marek.ca> <20200524023815.21789-2-jonathan@marek.ca> <20200529025246.GV279327@builder.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu 28 May 20:02 PDT 2020, Jonathan Marek wrote: > > > On 5/28/20 10:52 PM, Bjorn Andersson wrote: > > On Sat 23 May 19:38 PDT 2020, Jonathan Marek wrote: > > > > > Add the apps_smmu node for sm8150. Note that adding the iommus field for > > > UFS is required because initializing the iommu removes the bypass mapping > > > that created by the bootloader. > > > > > > > Unrelated to the patch itself; how do you disable the splash screen on > > 8150? "fastboot oem select-display-panel none" doesn't seem to work for > > me on the MTP - and hence this would prevent my device from booting. > > > > Thanks, > > Bjorn > > > > I don't have a MTP, but on HDK855, "fastboot oem select-display-panel none" > combined with setting the physical switch to HDMI mode (which switches off > the 1440x2560 panel) gets it to not setup the display at all (just the > fastboot command isn't enough). > Okay, I don't think we have anything equivalent on the MTP, but good to know. > With HDK865 though that doesn't work and I have a hack to work around it > (writing 0 to INTF_TIMING_ENGINE_EN early on in boot will stop video mode > scanout and it won't crash). > Then we need to sort this out in the arm-smmu driver before we can enable the apps_smmu node on 8250. I did receive some guidance from Will on the subject and have started looking into this. Thanks, Bjorn > > > Signed-off-by: Jonathan Marek > > > --- > > > arch/arm64/boot/dts/qcom/sm8150.dtsi | 91 ++++++++++++++++++++++++++++ > > > 1 file changed, 91 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi > > > index a36512d1f6a1..acb839427b12 100644 > > > --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi > > > +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi > > > @@ -442,6 +442,8 @@ ufs_mem_hc: ufshc@1d84000 { > > > resets = <&gcc GCC_UFS_PHY_BCR>; > > > reset-names = "rst"; > > > + iommus = <&apps_smmu 0x300 0>; > > > + > > > clock-names = > > > "core_clk", > > > "bus_aggr_clk", > > > @@ -706,6 +708,7 @@ usb_1_dwc3: dwc3@a600000 { > > > compatible = "snps,dwc3"; > > > reg = <0 0x0a600000 0 0xcd00>; > > > interrupts = ; > > > + iommus = <&apps_smmu 0x140 0>; > > > snps,dis_u2_susphy_quirk; > > > snps,dis_enblslpm_quirk; > > > phys = <&usb_1_hsphy>, <&usb_1_ssphy>; > > > @@ -742,6 +745,94 @@ spmi_bus: spmi@c440000 { > > > cell-index = <0>; > > > }; > > > + apps_smmu: iommu@15000000 { > > > + compatible = "qcom,sdm845-smmu-500", "arm,mmu-500"; > > > + reg = <0 0x15000000 0 0x100000>; > > > + #iommu-cells = <2>; > > > + #global-interrupts = <1>; > > > + interrupts = , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + , > > > + ; > > > + }; > > > + > > > remoteproc_adsp: remoteproc@17300000 { > > > compatible = "qcom,sm8150-adsp-pas"; > > > reg = <0x0 0x17300000 0x0 0x4040>; > > > -- > > > 2.26.1 > > >