* [PATCH 0/2] Enable all cache ways and Enable SiFive PWM driver
@ 2020-05-29 6:44 Pragnesh Patel
2020-05-29 6:44 ` [PATCH 1/2] riscv: sifive: fu540: enable all cache ways from U-Boot proper Pragnesh Patel
2020-05-29 6:44 ` [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver Pragnesh Patel
0 siblings, 2 replies; 15+ messages in thread
From: Pragnesh Patel @ 2020-05-29 6:44 UTC (permalink / raw)
To: u-boot
Patch 1: enable all cache ways from U-Boot proper
This patch enables all cache ways from U-Boot proper, earlier this was
done by FSBL.
(https://github.com/sifive/freedom-u540-c000-bootloader/blob/master/fsbl/main.c#L428)
L2 cache is of 2 MB (16 cache ways) and 1 cache way is of 128 KB.
FSBL is located on the latest way of L2 cache. Therefore, FSBL can
only enable the first 15 L2 cache ways to avoid corrupt itself.
U-Boot proper enables all cache ways (16 cache ways) in this patch.
Patch 2: Enable SiFive PWM driver
This patch enables SiFive PWM driver for the SiFive Unleashed board.
This series is rebase on
- [v13] RISC-V SiFive FU540 support SPL
This series depends on:
[1] https://patchwork.ozlabs.org/patch/1275883
All these together is available for testing here
[2] https://github.com/pragnesh26992/u-boot/tree/pwm
Pragnesh Patel (2):
riscv: sifive: fu540: enable all cache ways from U-Boot proper
riscv: sifive: fu540: Enable SiFive PWM driver
arch/riscv/cpu/fu540/Makefile | 1 +
arch/riscv/cpu/fu540/cache.c | 53 +++++++++++++++++++++++
arch/riscv/dts/fu540-c000-u-boot.dtsi | 4 ++
arch/riscv/include/asm/arch-fu540/cache.h | 14 ++++++
board/sifive/fu540/Kconfig | 2 +
board/sifive/fu540/fu540.c | 10 ++++-
6 files changed, 83 insertions(+), 1 deletion(-)
create mode 100644 arch/riscv/cpu/fu540/cache.c
create mode 100644 arch/riscv/include/asm/arch-fu540/cache.h
--
2.17.1
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 1/2] riscv: sifive: fu540: enable all cache ways from U-Boot proper
2020-05-29 6:44 [PATCH 0/2] Enable all cache ways and Enable SiFive PWM driver Pragnesh Patel
@ 2020-05-29 6:44 ` Pragnesh Patel
2020-05-29 13:05 ` Bin Meng
2020-05-29 6:44 ` [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver Pragnesh Patel
1 sibling, 1 reply; 15+ messages in thread
From: Pragnesh Patel @ 2020-05-29 6:44 UTC (permalink / raw)
To: u-boot
Add L2 cache node to enable all cache ways from U-Boot proper.
Signed-off-by: Pragnesh Patel <pragnesh.patel@sifive.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
---
arch/riscv/cpu/fu540/Makefile | 1 +
arch/riscv/cpu/fu540/cache.c | 53 +++++++++++++++++++++++
arch/riscv/dts/fu540-c000-u-boot.dtsi | 4 ++
arch/riscv/include/asm/arch-fu540/cache.h | 14 ++++++
board/sifive/fu540/fu540.c | 10 ++++-
5 files changed, 81 insertions(+), 1 deletion(-)
create mode 100644 arch/riscv/cpu/fu540/cache.c
create mode 100644 arch/riscv/include/asm/arch-fu540/cache.h
diff --git a/arch/riscv/cpu/fu540/Makefile b/arch/riscv/cpu/fu540/Makefile
index 043fb961a5..088205ef57 100644
--- a/arch/riscv/cpu/fu540/Makefile
+++ b/arch/riscv/cpu/fu540/Makefile
@@ -8,4 +8,5 @@ obj-y += spl.o
else
obj-y += dram.o
obj-y += cpu.o
+obj-y += cache.o
endif
diff --git a/arch/riscv/cpu/fu540/cache.c b/arch/riscv/cpu/fu540/cache.c
new file mode 100644
index 0000000000..9ee364b509
--- /dev/null
+++ b/arch/riscv/cpu/fu540/cache.c
@@ -0,0 +1,53 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2020 SiFive, Inc
+ *
+ * Authors:
+ * Pragnesh Patel <pragnesh.patel@sifive.com>
+ */
+
+#include <common.h>
+#include <asm/io.h>
+#include <linux/bitops.h>
+
+/* Register offsets */
+#define L2_CACHE_CONFIG 0x000
+#define L2_CACHE_ENABLE 0x008
+
+#define MASK_NUM_WAYS GENMASK(15, 8)
+#define NUM_WAYS_SHIFT 8
+
+DECLARE_GLOBAL_DATA_PTR;
+
+int cache_enable_ways(void)
+{
+ const void *blob = gd->fdt_blob;
+ int node = (-FDT_ERR_NOTFOUND);
+ fdt_addr_t base;
+ u32 config;
+ u32 ways;
+
+ volatile u32 *enable;
+
+ node = fdt_node_offset_by_compatible(blob, -1,
+ "sifive,fu540-c000-ccache");
+
+ if (node < 0)
+ return node;
+
+ base = fdtdec_get_addr(blob, node, "reg");
+ if (base == FDT_ADDR_T_NONE)
+ return FDT_ADDR_T_NONE;
+
+ config = readl((volatile u32 *)base + L2_CACHE_CONFIG);
+ ways = (config & MASK_NUM_WAYS) >> NUM_WAYS_SHIFT;
+
+ enable = (volatile u32 *)(base + L2_CACHE_ENABLE);
+
+ /* memory barrier */
+ mb();
+ (*enable) = ways - 1;
+ /* memory barrier */
+ mb();
+ return 0;
+}
diff --git a/arch/riscv/dts/fu540-c000-u-boot.dtsi b/arch/riscv/dts/fu540-c000-u-boot.dtsi
index 9bba554f9d..6e07c09f9f 100644
--- a/arch/riscv/dts/fu540-c000-u-boot.dtsi
+++ b/arch/riscv/dts/fu540-c000-u-boot.dtsi
@@ -87,3 +87,7 @@
assigned-clocks = <&prci PRCI_CLK_GEMGXLPLL>;
assigned-clock-rates = <125000000>;
};
+
+&l2cache {
+ status = "okay";
+};
diff --git a/arch/riscv/include/asm/arch-fu540/cache.h b/arch/riscv/include/asm/arch-fu540/cache.h
new file mode 100644
index 0000000000..135a17c679
--- /dev/null
+++ b/arch/riscv/include/asm/arch-fu540/cache.h
@@ -0,0 +1,14 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright (C) 2020 SiFive, Inc.
+ *
+ * Authors:
+ * Pragnesh Patel <pragnesh.patel@sifve.com>
+ */
+
+#ifndef _CACHE_SIFIVE_H
+#define _CACHE_SIFIVE_H
+
+int cache_enable_ways(void);
+
+#endif /* _CACHE_SIFIVE_H */
diff --git a/board/sifive/fu540/fu540.c b/board/sifive/fu540/fu540.c
index fa705dea71..27ff52f903 100644
--- a/board/sifive/fu540/fu540.c
+++ b/board/sifive/fu540/fu540.c
@@ -15,6 +15,7 @@
#include <linux/io.h>
#include <misc.h>
#include <spl.h>
+#include <asm/arch/cache.h>
/*
* This define is a value used for error/unknown serial.
@@ -114,7 +115,14 @@ int misc_init_r(void)
int board_init(void)
{
- /* For now nothing to do here. */
+ int ret;
+
+ /* enable all cache ways */
+ ret = cache_enable_ways();
+ if (ret) {
+ debug("%s: could not enable cache ways\n", __func__);
+ return ret;
+ }
return 0;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
2020-05-29 6:44 [PATCH 0/2] Enable all cache ways and Enable SiFive PWM driver Pragnesh Patel
2020-05-29 6:44 ` [PATCH 1/2] riscv: sifive: fu540: enable all cache ways from U-Boot proper Pragnesh Patel
@ 2020-05-29 6:44 ` Pragnesh Patel
2020-06-23 7:49 ` Bin Meng
[not found] ` <752D002CFF5D0F4FA35C0100F1D73F3FA471C0BE@ATCPCS16.andestech.com>
1 sibling, 2 replies; 15+ messages in thread
From: Pragnesh Patel @ 2020-05-29 6:44 UTC (permalink / raw)
To: u-boot
This patch enables SiFive PWM driver for the SiFive
Unleashed board.
Signed-off-by: Pragnesh Patel <pragnesh.patel@sifive.com>
---
board/sifive/fu540/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/board/sifive/fu540/Kconfig b/board/sifive/fu540/Kconfig
index 86193d7668..683668d059 100644
--- a/board/sifive/fu540/Kconfig
+++ b/board/sifive/fu540/Kconfig
@@ -65,5 +65,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
imply SMP
imply MISC
imply SIFIVE_OTP
+ imply DM_PWM
+ imply PWM_SIFIVE
endif
--
2.17.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 1/2] riscv: sifive: fu540: enable all cache ways from U-Boot proper
2020-05-29 6:44 ` [PATCH 1/2] riscv: sifive: fu540: enable all cache ways from U-Boot proper Pragnesh Patel
@ 2020-05-29 13:05 ` Bin Meng
0 siblings, 0 replies; 15+ messages in thread
From: Bin Meng @ 2020-05-29 13:05 UTC (permalink / raw)
To: u-boot
On Fri, May 29, 2020 at 2:45 PM Pragnesh Patel
<pragnesh.patel@sifive.com> wrote:
>
> Add L2 cache node to enable all cache ways from U-Boot proper.
>
> Signed-off-by: Pragnesh Patel <pragnesh.patel@sifive.com>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> ---
> arch/riscv/cpu/fu540/Makefile | 1 +
> arch/riscv/cpu/fu540/cache.c | 53 +++++++++++++++++++++++
> arch/riscv/dts/fu540-c000-u-boot.dtsi | 4 ++
> arch/riscv/include/asm/arch-fu540/cache.h | 14 ++++++
> board/sifive/fu540/fu540.c | 10 ++++-
> 5 files changed, 81 insertions(+), 1 deletion(-)
> create mode 100644 arch/riscv/cpu/fu540/cache.c
> create mode 100644 arch/riscv/include/asm/arch-fu540/cache.h
>
Tested-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
2020-05-29 6:44 ` [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver Pragnesh Patel
@ 2020-06-23 7:49 ` Bin Meng
[not found] ` <752D002CFF5D0F4FA35C0100F1D73F3FA471C0BE@ATCPCS16.andestech.com>
1 sibling, 0 replies; 15+ messages in thread
From: Bin Meng @ 2020-06-23 7:49 UTC (permalink / raw)
To: u-boot
On Fri, May 29, 2020 at 2:45 PM Pragnesh Patel
<pragnesh.patel@sifive.com> wrote:
>
> This patch enables SiFive PWM driver for the SiFive
> Unleashed board.
>
> Signed-off-by: Pragnesh Patel <pragnesh.patel@sifive.com>
> ---
> board/sifive/fu540/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Bin Meng <bin.meng@windriver.com>
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
[not found] ` <752D002CFF5D0F4FA35C0100F1D73F3FA471C0BE@ATCPCS16.andestech.com>
@ 2020-06-24 0:59 ` Rick Chen
2020-06-24 4:32 ` Pragnesh Patel
0 siblings, 1 reply; 15+ messages in thread
From: Rick Chen @ 2020-06-24 0:59 UTC (permalink / raw)
To: u-boot
Hi Pragnesh
> From: Pragnesh Patel [mailto:pragnesh.patel at sifive.com]
> Sent: Friday, May 29, 2020 2:45 PM
> To: u-boot at lists.denx.de
> Cc: atish.patra at wdc.com; palmerdabbelt at google.com; bmeng.cn at gmail.com; paul.walmsley at sifive.com; anup.patel at wdc.com; sagar.kadam at sifive.com; Rick Jian-Zhi Chen(???); Pragnesh Patel; Palmer Dabbelt
> Subject: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
>
> This patch enables SiFive PWM driver for the SiFive Unleashed board.
>
> Signed-off-by: Pragnesh Patel <pragnesh.patel@sifive.com>
> ---
> board/sifive/fu540/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/board/sifive/fu540/Kconfig b/board/sifive/fu540/Kconfig index 86193d7668..683668d059 100644
> --- a/board/sifive/fu540/Kconfig
> +++ b/board/sifive/fu540/Kconfig
> @@ -65,5 +65,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
> imply SMP
> imply MISC
> imply SIFIVE_OTP
> + imply DM_PWM
> + imply PWM_SIFIVE
>
This patch shall follow [PATCH v2 0/2] Add support for PWM SiFive.
It is weird to introduce here and not appropriate to depend on another patch.
Thanks,
Rick
> endif
> --
> 2.17.1
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
2020-06-24 0:59 ` Rick Chen
@ 2020-06-24 4:32 ` Pragnesh Patel
2020-06-24 5:14 ` Rick Chen
0 siblings, 1 reply; 15+ messages in thread
From: Pragnesh Patel @ 2020-06-24 4:32 UTC (permalink / raw)
To: u-boot
Hi Rick,
>-----Original Message-----
>From: Rick Chen <rickchen36@gmail.com>
>Sent: 24 June 2020 06:30
>To: Pragnesh Patel <pragnesh.patel@sifive.com>
>Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Atish Patra
><atish.patra@wdc.com>; palmerdabbelt at google.com; Bin Meng
><bmeng.cn@gmail.com>; Paul Walmsley ( Sifive)
><paul.walmsley@sifive.com>; Anup Patel <anup.patel@wdc.com>; Sagar
>Kadam <sagar.kadam@sifive.com>; Palmer Dabbelt <palmer@dabbelt.com>;
>Jagan Teki <jagan@amarulasolutions.com>; rick <rick@andestech.com>; Alan
>Kao <alankao@andestech.com>
>Subject: Re: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
>
>[External Email] Do not click links or attachments unless you recognize the
>sender and know the content is safe
>
>Hi Pragnesh
>
>> From: Pragnesh Patel [mailto:pragnesh.patel at sifive.com]
>> Sent: Friday, May 29, 2020 2:45 PM
>> To: u-boot at lists.denx.de
>> Cc: atish.patra at wdc.com; palmerdabbelt at google.com;
>bmeng.cn at gmail.com; paul.walmsley at sifive.com; anup.patel at wdc.com;
>sagar.kadam at sifive.com; Rick Jian-Zhi Chen(???); Pragnesh Patel; Palmer
>Dabbelt
>> Subject: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
>>
>> This patch enables SiFive PWM driver for the SiFive Unleashed board.
>>
>> Signed-off-by: Pragnesh Patel <pragnesh.patel@sifive.com>
>> ---
>> board/sifive/fu540/Kconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/board/sifive/fu540/Kconfig b/board/sifive/fu540/Kconfig index
>86193d7668..683668d059 100644
>> --- a/board/sifive/fu540/Kconfig
>> +++ b/board/sifive/fu540/Kconfig
>> @@ -65,5 +65,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
>> imply SMP
>> imply MISC
>> imply SIFIVE_OTP
>> + imply DM_PWM
>> + imply PWM_SIFIVE
>>
>
>This patch shall follow [PATCH v2 0/2] Add support for PWM SiFive.
>It is weird to introduce here and not appropriate to depend on another patch.
Do you want me to send this 2 patches separately independent of each other ?
>
>Thanks,
>Rick
>
>> endif
>> --
>> 2.17.1
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
2020-06-24 4:32 ` Pragnesh Patel
@ 2020-06-24 5:14 ` Rick Chen
2020-06-24 5:24 ` Pragnesh Patel
0 siblings, 1 reply; 15+ messages in thread
From: Rick Chen @ 2020-06-24 5:14 UTC (permalink / raw)
To: u-boot
Hi Pragnesh
> Hi Rick,
>
> >-----Original Message-----
> >From: Rick Chen <rickchen36@gmail.com>
> >Sent: 24 June 2020 06:30
> >To: Pragnesh Patel <pragnesh.patel@sifive.com>
> >Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Atish Patra
> ><atish.patra@wdc.com>; palmerdabbelt at google.com; Bin Meng
> ><bmeng.cn@gmail.com>; Paul Walmsley ( Sifive)
> ><paul.walmsley@sifive.com>; Anup Patel <anup.patel@wdc.com>; Sagar
> >Kadam <sagar.kadam@sifive.com>; Palmer Dabbelt <palmer@dabbelt.com>;
> >Jagan Teki <jagan@amarulasolutions.com>; rick <rick@andestech.com>; Alan
> >Kao <alankao@andestech.com>
> >Subject: Re: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
> >
> >[External Email] Do not click links or attachments unless you recognize the
> >sender and know the content is safe
> >
> >Hi Pragnesh
> >
> >> From: Pragnesh Patel [mailto:pragnesh.patel at sifive.com]
> >> Sent: Friday, May 29, 2020 2:45 PM
> >> To: u-boot at lists.denx.de
> >> Cc: atish.patra at wdc.com; palmerdabbelt at google.com;
> >bmeng.cn at gmail.com; paul.walmsley at sifive.com; anup.patel at wdc.com;
> >sagar.kadam at sifive.com; Rick Jian-Zhi Chen(???); Pragnesh Patel; Palmer
> >Dabbelt
> >> Subject: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
> >>
> >> This patch enables SiFive PWM driver for the SiFive Unleashed board.
> >>
> >> Signed-off-by: Pragnesh Patel <pragnesh.patel@sifive.com>
> >> ---
> >> board/sifive/fu540/Kconfig | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git a/board/sifive/fu540/Kconfig b/board/sifive/fu540/Kconfig index
> >86193d7668..683668d059 100644
> >> --- a/board/sifive/fu540/Kconfig
> >> +++ b/board/sifive/fu540/Kconfig
> >> @@ -65,5 +65,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
> >> imply SMP
> >> imply MISC
> >> imply SIFIVE_OTP
> >> + imply DM_PWM
> >> + imply PWM_SIFIVE
> >>
> >
> >This patch shall follow [PATCH v2 0/2] Add support for PWM SiFive.
> >It is weird to introduce here and not appropriate to depend on another patch.
>
> Do you want me to send this 2 patches separately independent of each other ?
How about merged [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
into [PATCH v2 0/2] Add support for PWM SiFive ?
Thanks,
Rick
>
> >
> >Thanks,
> >Rick
> >
> >> endif
> >> --
> >> 2.17.1
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
2020-06-24 5:14 ` Rick Chen
@ 2020-06-24 5:24 ` Pragnesh Patel
2020-06-24 5:29 ` Bin Meng
0 siblings, 1 reply; 15+ messages in thread
From: Pragnesh Patel @ 2020-06-24 5:24 UTC (permalink / raw)
To: u-boot
Hi Rick,
>-----Original Message-----
>From: Rick Chen <rickchen36@gmail.com>
>Sent: 24 June 2020 10:44
>To: Pragnesh Patel <pragnesh.patel@sifive.com>
>Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Atish Patra
><atish.patra@wdc.com>; palmerdabbelt at google.com; Bin Meng
><bmeng.cn@gmail.com>; Paul Walmsley ( Sifive)
><paul.walmsley@sifive.com>; Anup Patel <anup.patel@wdc.com>; Sagar
>Kadam <sagar.kadam@sifive.com>; Palmer Dabbelt <palmer@dabbelt.com>;
>Jagan Teki <jagan@amarulasolutions.com>; rick <rick@andestech.com>; Alan
>Kao <alankao@andestech.com>
>Subject: Re: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
>
>[External Email] Do not click links or attachments unless you recognize the
>sender and know the content is safe
>
>Hi Pragnesh
>
>> Hi Rick,
>>
>> >-----Original Message-----
>> >From: Rick Chen <rickchen36@gmail.com>
>> >Sent: 24 June 2020 06:30
>> >To: Pragnesh Patel <pragnesh.patel@sifive.com>
>> >Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Atish Patra
>> ><atish.patra@wdc.com>; palmerdabbelt at google.com; Bin Meng
>> ><bmeng.cn@gmail.com>; Paul Walmsley ( Sifive)
>> ><paul.walmsley@sifive.com>; Anup Patel <anup.patel@wdc.com>; Sagar
>> >Kadam <sagar.kadam@sifive.com>; Palmer Dabbelt
><palmer@dabbelt.com>;
>> >Jagan Teki <jagan@amarulasolutions.com>; rick <rick@andestech.com>;
>> >Alan Kao <alankao@andestech.com>
>> >Subject: Re: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM
>> >driver
>> >
>> >[External Email] Do not click links or attachments unless you
>> >recognize the sender and know the content is safe
>> >
>> >Hi Pragnesh
>> >
>> >> From: Pragnesh Patel [mailto:pragnesh.patel at sifive.com]
>> >> Sent: Friday, May 29, 2020 2:45 PM
>> >> To: u-boot at lists.denx.de
>> >> Cc: atish.patra at wdc.com; palmerdabbelt at google.com;
>> >bmeng.cn at gmail.com; paul.walmsley at sifive.com; anup.patel at wdc.com;
>> >sagar.kadam at sifive.com; Rick Jian-Zhi Chen(???); Pragnesh Patel;
>> >Palmer Dabbelt
>> >> Subject: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
>> >>
>> >> This patch enables SiFive PWM driver for the SiFive Unleashed board.
>> >>
>> >> Signed-off-by: Pragnesh Patel <pragnesh.patel@sifive.com>
>> >> ---
>> >> board/sifive/fu540/Kconfig | 2 ++
>> >> 1 file changed, 2 insertions(+)
>> >>
>> >> diff --git a/board/sifive/fu540/Kconfig
>> >> b/board/sifive/fu540/Kconfig index
>> >86193d7668..683668d059 100644
>> >> --- a/board/sifive/fu540/Kconfig
>> >> +++ b/board/sifive/fu540/Kconfig
>> >> @@ -65,5 +65,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
>> >> imply SMP
>> >> imply MISC
>> >> imply SIFIVE_OTP
>> >> + imply DM_PWM
>> >> + imply PWM_SIFIVE
>> >>
>> >
>> >This patch shall follow [PATCH v2 0/2] Add support for PWM SiFive.
>> >It is weird to introduce here and not appropriate to depend on another
>patch.
>>
>> Do you want me to send this 2 patches separately independent of each
>other ?
>
>How about merged [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
>into [PATCH v2 0/2] Add support for PWM SiFive ?
I am okay with it, you can go ahead and merge this patch into PWM series of Yash.
>
>Thanks,
>Rick
>
>>
>> >
>> >Thanks,
>> >Rick
>> >
>> >> endif
>> >> --
>> >> 2.17.1
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
2020-06-24 5:24 ` Pragnesh Patel
@ 2020-06-24 5:29 ` Bin Meng
2020-06-24 6:26 ` Rick Chen
0 siblings, 1 reply; 15+ messages in thread
From: Bin Meng @ 2020-06-24 5:29 UTC (permalink / raw)
To: u-boot
Hi Rick,
On Wed, Jun 24, 2020 at 1:24 PM Pragnesh Patel
<pragnesh.patel@sifive.com> wrote:
>
> Hi Rick,
>
> >-----Original Message-----
> >From: Rick Chen <rickchen36@gmail.com>
> >Sent: 24 June 2020 10:44
> >To: Pragnesh Patel <pragnesh.patel@sifive.com>
> >Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Atish Patra
> ><atish.patra@wdc.com>; palmerdabbelt at google.com; Bin Meng
> ><bmeng.cn@gmail.com>; Paul Walmsley ( Sifive)
> ><paul.walmsley@sifive.com>; Anup Patel <anup.patel@wdc.com>; Sagar
> >Kadam <sagar.kadam@sifive.com>; Palmer Dabbelt <palmer@dabbelt.com>;
> >Jagan Teki <jagan@amarulasolutions.com>; rick <rick@andestech.com>; Alan
> >Kao <alankao@andestech.com>
> >Subject: Re: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
> >
> >[External Email] Do not click links or attachments unless you recognize the
> >sender and know the content is safe
> >
> >Hi Pragnesh
> >
> >> Hi Rick,
> >>
> >> >-----Original Message-----
> >> >From: Rick Chen <rickchen36@gmail.com>
> >> >Sent: 24 June 2020 06:30
> >> >To: Pragnesh Patel <pragnesh.patel@sifive.com>
> >> >Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Atish Patra
> >> ><atish.patra@wdc.com>; palmerdabbelt at google.com; Bin Meng
> >> ><bmeng.cn@gmail.com>; Paul Walmsley ( Sifive)
> >> ><paul.walmsley@sifive.com>; Anup Patel <anup.patel@wdc.com>; Sagar
> >> >Kadam <sagar.kadam@sifive.com>; Palmer Dabbelt
> ><palmer@dabbelt.com>;
> >> >Jagan Teki <jagan@amarulasolutions.com>; rick <rick@andestech.com>;
> >> >Alan Kao <alankao@andestech.com>
> >> >Subject: Re: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM
> >> >driver
> >> >
> >> >[External Email] Do not click links or attachments unless you
> >> >recognize the sender and know the content is safe
> >> >
> >> >Hi Pragnesh
> >> >
> >> >> From: Pragnesh Patel [mailto:pragnesh.patel at sifive.com]
> >> >> Sent: Friday, May 29, 2020 2:45 PM
> >> >> To: u-boot at lists.denx.de
> >> >> Cc: atish.patra at wdc.com; palmerdabbelt at google.com;
> >> >bmeng.cn at gmail.com; paul.walmsley at sifive.com; anup.patel at wdc.com;
> >> >sagar.kadam at sifive.com; Rick Jian-Zhi Chen(???); Pragnesh Patel;
> >> >Palmer Dabbelt
> >> >> Subject: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
> >> >>
> >> >> This patch enables SiFive PWM driver for the SiFive Unleashed board.
> >> >>
> >> >> Signed-off-by: Pragnesh Patel <pragnesh.patel@sifive.com>
> >> >> ---
> >> >> board/sifive/fu540/Kconfig | 2 ++
> >> >> 1 file changed, 2 insertions(+)
> >> >>
> >> >> diff --git a/board/sifive/fu540/Kconfig
> >> >> b/board/sifive/fu540/Kconfig index
> >> >86193d7668..683668d059 100644
> >> >> --- a/board/sifive/fu540/Kconfig
> >> >> +++ b/board/sifive/fu540/Kconfig
> >> >> @@ -65,5 +65,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
> >> >> imply SMP
> >> >> imply MISC
> >> >> imply SIFIVE_OTP
> >> >> + imply DM_PWM
> >> >> + imply PWM_SIFIVE
> >> >>
> >> >
> >> >This patch shall follow [PATCH v2 0/2] Add support for PWM SiFive.
> >> >It is weird to introduce here and not appropriate to depend on another
> >patch.
> >>
> >> Do you want me to send this 2 patches separately independent of each
> >other ?
> >
> >How about merged [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
> >into [PATCH v2 0/2] Add support for PWM SiFive ?
>
> I am okay with it, you can go ahead and merge this patch into PWM series of Yash.
>
They are separate patches and should keep separate. I am not sure
what's the issue we want to resolve?
Regards,
Bin
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
2020-06-24 5:29 ` Bin Meng
@ 2020-06-24 6:26 ` Rick Chen
2020-06-24 7:34 ` Bin Meng
0 siblings, 1 reply; 15+ messages in thread
From: Rick Chen @ 2020-06-24 6:26 UTC (permalink / raw)
To: u-boot
Hi Bin
> Hi Rick,
>
> On Wed, Jun 24, 2020 at 1:24 PM Pragnesh Patel
> <pragnesh.patel@sifive.com> wrote:
> >
> > Hi Rick,
> >
> > >-----Original Message-----
> > >From: Rick Chen <rickchen36@gmail.com>
> > >Sent: 24 June 2020 10:44
> > >To: Pragnesh Patel <pragnesh.patel@sifive.com>
> > >Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Atish Patra
> > ><atish.patra@wdc.com>; palmerdabbelt at google.com; Bin Meng
> > ><bmeng.cn@gmail.com>; Paul Walmsley ( Sifive)
> > ><paul.walmsley@sifive.com>; Anup Patel <anup.patel@wdc.com>; Sagar
> > >Kadam <sagar.kadam@sifive.com>; Palmer Dabbelt <palmer@dabbelt.com>;
> > >Jagan Teki <jagan@amarulasolutions.com>; rick <rick@andestech.com>; Alan
> > >Kao <alankao@andestech.com>
> > >Subject: Re: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
> > >
> > >[External Email] Do not click links or attachments unless you recognize the
> > >sender and know the content is safe
> > >
> > >Hi Pragnesh
> > >
> > >> Hi Rick,
> > >>
> > >> >-----Original Message-----
> > >> >From: Rick Chen <rickchen36@gmail.com>
> > >> >Sent: 24 June 2020 06:30
> > >> >To: Pragnesh Patel <pragnesh.patel@sifive.com>
> > >> >Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Atish Patra
> > >> ><atish.patra@wdc.com>; palmerdabbelt at google.com; Bin Meng
> > >> ><bmeng.cn@gmail.com>; Paul Walmsley ( Sifive)
> > >> ><paul.walmsley@sifive.com>; Anup Patel <anup.patel@wdc.com>; Sagar
> > >> >Kadam <sagar.kadam@sifive.com>; Palmer Dabbelt
> > ><palmer@dabbelt.com>;
> > >> >Jagan Teki <jagan@amarulasolutions.com>; rick <rick@andestech.com>;
> > >> >Alan Kao <alankao@andestech.com>
> > >> >Subject: Re: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM
> > >> >driver
> > >> >
> > >> >[External Email] Do not click links or attachments unless you
> > >> >recognize the sender and know the content is safe
> > >> >
> > >> >Hi Pragnesh
> > >> >
> > >> >> From: Pragnesh Patel [mailto:pragnesh.patel at sifive.com]
> > >> >> Sent: Friday, May 29, 2020 2:45 PM
> > >> >> To: u-boot at lists.denx.de
> > >> >> Cc: atish.patra at wdc.com; palmerdabbelt at google.com;
> > >> >bmeng.cn at gmail.com; paul.walmsley at sifive.com; anup.patel at wdc.com;
> > >> >sagar.kadam at sifive.com; Rick Jian-Zhi Chen(???); Pragnesh Patel;
> > >> >Palmer Dabbelt
> > >> >> Subject: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
> > >> >>
> > >> >> This patch enables SiFive PWM driver for the SiFive Unleashed board.
> > >> >>
> > >> >> Signed-off-by: Pragnesh Patel <pragnesh.patel@sifive.com>
> > >> >> ---
> > >> >> board/sifive/fu540/Kconfig | 2 ++
> > >> >> 1 file changed, 2 insertions(+)
> > >> >>
> > >> >> diff --git a/board/sifive/fu540/Kconfig
> > >> >> b/board/sifive/fu540/Kconfig index
> > >> >86193d7668..683668d059 100644
> > >> >> --- a/board/sifive/fu540/Kconfig
> > >> >> +++ b/board/sifive/fu540/Kconfig
> > >> >> @@ -65,5 +65,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
> > >> >> imply SMP
> > >> >> imply MISC
> > >> >> imply SIFIVE_OTP
> > >> >> + imply DM_PWM
> > >> >> + imply PWM_SIFIVE
> > >> >>
> > >> >
> > >> >This patch shall follow [PATCH v2 0/2] Add support for PWM SiFive.
> > >> >It is weird to introduce here and not appropriate to depend on another
> > >patch.
> > >>
> > >> Do you want me to send this 2 patches separately independent of each
> > >other ?
> > >
> > >How about merged [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
> > >into [PATCH v2 0/2] Add support for PWM SiFive ?
> >
> > I am okay with it, you can go ahead and merge this patch into PWM series of Yash.
> >
>
> They are separate patches and should keep separate. I am not sure
> what's the issue we want to resolve?
Nothing about resolve.
Logically if they can be put together, it will be more reasonable.
Thanks,
Rick
>
> Regards,
> Bin
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
2020-06-24 6:26 ` Rick Chen
@ 2020-06-24 7:34 ` Bin Meng
2020-06-24 7:44 ` Pragnesh Patel
0 siblings, 1 reply; 15+ messages in thread
From: Bin Meng @ 2020-06-24 7:34 UTC (permalink / raw)
To: u-boot
Hi Rick,
On Wed, Jun 24, 2020 at 2:26 PM Rick Chen <rickchen36@gmail.com> wrote:
>
> Hi Bin
>
> > Hi Rick,
> >
> > On Wed, Jun 24, 2020 at 1:24 PM Pragnesh Patel
> > <pragnesh.patel@sifive.com> wrote:
> > >
> > > Hi Rick,
> > >
> > > >-----Original Message-----
> > > >From: Rick Chen <rickchen36@gmail.com>
> > > >Sent: 24 June 2020 10:44
> > > >To: Pragnesh Patel <pragnesh.patel@sifive.com>
> > > >Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Atish Patra
> > > ><atish.patra@wdc.com>; palmerdabbelt at google.com; Bin Meng
> > > ><bmeng.cn@gmail.com>; Paul Walmsley ( Sifive)
> > > ><paul.walmsley@sifive.com>; Anup Patel <anup.patel@wdc.com>; Sagar
> > > >Kadam <sagar.kadam@sifive.com>; Palmer Dabbelt <palmer@dabbelt.com>;
> > > >Jagan Teki <jagan@amarulasolutions.com>; rick <rick@andestech.com>; Alan
> > > >Kao <alankao@andestech.com>
> > > >Subject: Re: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
> > > >
> > > >[External Email] Do not click links or attachments unless you recognize the
> > > >sender and know the content is safe
> > > >
> > > >Hi Pragnesh
> > > >
> > > >> Hi Rick,
> > > >>
> > > >> >-----Original Message-----
> > > >> >From: Rick Chen <rickchen36@gmail.com>
> > > >> >Sent: 24 June 2020 06:30
> > > >> >To: Pragnesh Patel <pragnesh.patel@sifive.com>
> > > >> >Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Atish Patra
> > > >> ><atish.patra@wdc.com>; palmerdabbelt at google.com; Bin Meng
> > > >> ><bmeng.cn@gmail.com>; Paul Walmsley ( Sifive)
> > > >> ><paul.walmsley@sifive.com>; Anup Patel <anup.patel@wdc.com>; Sagar
> > > >> >Kadam <sagar.kadam@sifive.com>; Palmer Dabbelt
> > > ><palmer@dabbelt.com>;
> > > >> >Jagan Teki <jagan@amarulasolutions.com>; rick <rick@andestech.com>;
> > > >> >Alan Kao <alankao@andestech.com>
> > > >> >Subject: Re: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM
> > > >> >driver
> > > >> >
> > > >> >[External Email] Do not click links or attachments unless you
> > > >> >recognize the sender and know the content is safe
> > > >> >
> > > >> >Hi Pragnesh
> > > >> >
> > > >> >> From: Pragnesh Patel [mailto:pragnesh.patel at sifive.com]
> > > >> >> Sent: Friday, May 29, 2020 2:45 PM
> > > >> >> To: u-boot at lists.denx.de
> > > >> >> Cc: atish.patra at wdc.com; palmerdabbelt at google.com;
> > > >> >bmeng.cn at gmail.com; paul.walmsley at sifive.com; anup.patel at wdc.com;
> > > >> >sagar.kadam at sifive.com; Rick Jian-Zhi Chen(???); Pragnesh Patel;
> > > >> >Palmer Dabbelt
> > > >> >> Subject: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
> > > >> >>
> > > >> >> This patch enables SiFive PWM driver for the SiFive Unleashed board.
> > > >> >>
> > > >> >> Signed-off-by: Pragnesh Patel <pragnesh.patel@sifive.com>
> > > >> >> ---
> > > >> >> board/sifive/fu540/Kconfig | 2 ++
> > > >> >> 1 file changed, 2 insertions(+)
> > > >> >>
> > > >> >> diff --git a/board/sifive/fu540/Kconfig
> > > >> >> b/board/sifive/fu540/Kconfig index
> > > >> >86193d7668..683668d059 100644
> > > >> >> --- a/board/sifive/fu540/Kconfig
> > > >> >> +++ b/board/sifive/fu540/Kconfig
> > > >> >> @@ -65,5 +65,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
> > > >> >> imply SMP
> > > >> >> imply MISC
> > > >> >> imply SIFIVE_OTP
> > > >> >> + imply DM_PWM
> > > >> >> + imply PWM_SIFIVE
> > > >> >>
> > > >> >
> > > >> >This patch shall follow [PATCH v2 0/2] Add support for PWM SiFive.
> > > >> >It is weird to introduce here and not appropriate to depend on another
> > > >patch.
> > > >>
> > > >> Do you want me to send this 2 patches separately independent of each
> > > >other ?
> > > >
> > > >How about merged [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
> > > >into [PATCH v2 0/2] Add support for PWM SiFive ?
> > >
> > > I am okay with it, you can go ahead and merge this patch into PWM series of Yash.
> > >
> >
> > They are separate patches and should keep separate. I am not sure
> > what's the issue we want to resolve?
>
> Nothing about resolve.
> Logically if they can be put together, it will be more reasonable.
Agree. Thanks for the clarification.
That's why I recommend developers submit all related patch sets in a
series to help maintainers' work :)
Regards,
Bin
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
2020-06-24 7:34 ` Bin Meng
@ 2020-06-24 7:44 ` Pragnesh Patel
2020-07-20 6:49 ` Pragnesh Patel
0 siblings, 1 reply; 15+ messages in thread
From: Pragnesh Patel @ 2020-06-24 7:44 UTC (permalink / raw)
To: u-boot
Hi Rick,
>-----Original Message-----
>From: Bin Meng <bmeng.cn@gmail.com>
>Sent: 24 June 2020 13:04
>To: Rick Chen <rickchen36@gmail.com>
>Cc: Pragnesh Patel <pragnesh.patel@sifive.com>; U-Boot Mailing List <u-
>boot at lists.denx.de>; Atish Patra <atish.patra@wdc.com>;
>palmerdabbelt at google.com; Paul Walmsley ( Sifive)
><paul.walmsley@sifive.com>; Anup Patel <anup.patel@wdc.com>; Sagar
>Kadam <sagar.kadam@sifive.com>; Palmer Dabbelt <palmer@dabbelt.com>;
>Jagan Teki <jagan@amarulasolutions.com>; rick <rick@andestech.com>; Alan
>Kao <alankao@andestech.com>
>Subject: Re: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
>
>[External Email] Do not click links or attachments unless you recognize the
>sender and know the content is safe
>
>Hi Rick,
>
>On Wed, Jun 24, 2020 at 2:26 PM Rick Chen <rickchen36@gmail.com> wrote:
>>
>> Hi Bin
>>
>> > Hi Rick,
>> >
>> > On Wed, Jun 24, 2020 at 1:24 PM Pragnesh Patel
>> > <pragnesh.patel@sifive.com> wrote:
>> > >
>> > > Hi Rick,
>> > >
>> > > >-----Original Message-----
>> > > >From: Rick Chen <rickchen36@gmail.com>
>> > > >Sent: 24 June 2020 10:44
>> > > >To: Pragnesh Patel <pragnesh.patel@sifive.com>
>> > > >Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Atish Patra
>> > > ><atish.patra@wdc.com>; palmerdabbelt at google.com; Bin Meng
>> > > ><bmeng.cn@gmail.com>; Paul Walmsley ( Sifive)
>> > > ><paul.walmsley@sifive.com>; Anup Patel <anup.patel@wdc.com>;
>> > > >Sagar Kadam <sagar.kadam@sifive.com>; Palmer Dabbelt
>> > > ><palmer@dabbelt.com>; Jagan Teki <jagan@amarulasolutions.com>;
>> > > >rick <rick@andestech.com>; Alan Kao <alankao@andestech.com>
>> > > >Subject: Re: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM
>> > > >driver
>> > > >
>> > > >[External Email] Do not click links or attachments unless you
>> > > >recognize the sender and know the content is safe
>> > > >
>> > > >Hi Pragnesh
>> > > >
>> > > >> Hi Rick,
>> > > >>
>> > > >> >-----Original Message-----
>> > > >> >From: Rick Chen <rickchen36@gmail.com>
>> > > >> >Sent: 24 June 2020 06:30
>> > > >> >To: Pragnesh Patel <pragnesh.patel@sifive.com>
>> > > >> >Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Atish Patra
>> > > >> ><atish.patra@wdc.com>; palmerdabbelt at google.com; Bin Meng
>> > > >> ><bmeng.cn@gmail.com>; Paul Walmsley ( Sifive)
>> > > >> ><paul.walmsley@sifive.com>; Anup Patel <anup.patel@wdc.com>;
>> > > >> >Sagar Kadam <sagar.kadam@sifive.com>; Palmer Dabbelt
>> > > ><palmer@dabbelt.com>;
>> > > >> >Jagan Teki <jagan@amarulasolutions.com>; rick
>> > > >> ><rick@andestech.com>; Alan Kao <alankao@andestech.com>
>> > > >> >Subject: Re: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive
>> > > >> >PWM driver
>> > > >> >
>> > > >> >[External Email] Do not click links or attachments unless you
>> > > >> >recognize the sender and know the content is safe
>> > > >> >
>> > > >> >Hi Pragnesh
>> > > >> >
>> > > >> >> From: Pragnesh Patel [mailto:pragnesh.patel at sifive.com]
>> > > >> >> Sent: Friday, May 29, 2020 2:45 PM
>> > > >> >> To: u-boot at lists.denx.de
>> > > >> >> Cc: atish.patra at wdc.com; palmerdabbelt at google.com;
>> > > >> >bmeng.cn at gmail.com; paul.walmsley at sifive.com;
>> > > >> >anup.patel at wdc.com; sagar.kadam at sifive.com; Rick Jian-Zhi
>> > > >> >Chen(???); Pragnesh Patel; Palmer Dabbelt
>> > > >> >> Subject: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM
>> > > >> >> driver
>> > > >> >>
>> > > >> >> This patch enables SiFive PWM driver for the SiFive Unleashed
>board.
>> > > >> >>
>> > > >> >> Signed-off-by: Pragnesh Patel <pragnesh.patel@sifive.com>
>> > > >> >> ---
>> > > >> >> board/sifive/fu540/Kconfig | 2 ++
>> > > >> >> 1 file changed, 2 insertions(+)
>> > > >> >>
>> > > >> >> diff --git a/board/sifive/fu540/Kconfig
>> > > >> >> b/board/sifive/fu540/Kconfig index
>> > > >> >86193d7668..683668d059 100644
>> > > >> >> --- a/board/sifive/fu540/Kconfig
>> > > >> >> +++ b/board/sifive/fu540/Kconfig
>> > > >> >> @@ -65,5 +65,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
>> > > >> >> imply SMP
>> > > >> >> imply MISC
>> > > >> >> imply SIFIVE_OTP
>> > > >> >> + imply DM_PWM
>> > > >> >> + imply PWM_SIFIVE
>> > > >> >>
>> > > >> >
>> > > >> >This patch shall follow [PATCH v2 0/2] Add support for PWM SiFive.
>> > > >> >It is weird to introduce here and not appropriate to depend on
>> > > >> >another
>> > > >patch.
>> > > >>
>> > > >> Do you want me to send this 2 patches separately independent of
>> > > >> each
>> > > >other ?
>> > > >
>> > > >How about merged [PATCH 2/2] riscv: sifive: fu540: Enable SiFive
>> > > >PWM driver into [PATCH v2 0/2] Add support for PWM SiFive ?
>> > >
>> > > I am okay with it, you can go ahead and merge this patch into PWM
>series of Yash.
>> > >
>> >
>> > They are separate patches and should keep separate. I am not sure
>> > what's the issue we want to resolve?
>>
>> Nothing about resolve.
>> Logically if they can be put together, it will be more reasonable.
>
>Agree. Thanks for the clarification.
>
>That's why I recommend developers submit all related patch sets in a series to
>help maintainers' work :)
Just to clarify, you are going to merge this patch into [PATCH v2 0/2] Add support for PWM SiFive, right ?
Let me know if I am wrong and you want to resubmit anything from me.
>
>Regards,
>Bin
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
2020-06-24 7:44 ` Pragnesh Patel
@ 2020-07-20 6:49 ` Pragnesh Patel
2020-07-20 8:22 ` Rick Chen
0 siblings, 1 reply; 15+ messages in thread
From: Pragnesh Patel @ 2020-07-20 6:49 UTC (permalink / raw)
To: u-boot
Hi Rick,
Any comments on this patch ?
>-----Original Message-----
>From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Pragnesh Patel
>Sent: 24 June 2020 13:14
>To: Bin Meng <bmeng.cn@gmail.com>; Rick Chen <rickchen36@gmail.com>
>Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Atish Patra
><atish.patra@wdc.com>; palmerdabbelt at google.com; Paul Walmsley ( Sifive)
><paul.walmsley@sifive.com>; Anup Patel <anup.patel@wdc.com>; Sagar
>Kadam <sagar.kadam@sifive.com>; Palmer Dabbelt <palmer@dabbelt.com>;
>Jagan Teki <jagan@amarulasolutions.com>; rick <rick@andestech.com>; Alan
>Kao <alankao@andestech.com>
>Subject: RE: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
>
>Hi Rick,
>
>>-----Original Message-----
>>From: Bin Meng <bmeng.cn@gmail.com>
>>Sent: 24 June 2020 13:04
>>To: Rick Chen <rickchen36@gmail.com>
>>Cc: Pragnesh Patel <pragnesh.patel@sifive.com>; U-Boot Mailing List <u-
>>boot at lists.denx.de>; Atish Patra <atish.patra@wdc.com>;
>>palmerdabbelt at google.com; Paul Walmsley ( Sifive)
>><paul.walmsley@sifive.com>; Anup Patel <anup.patel@wdc.com>; Sagar
>>Kadam <sagar.kadam@sifive.com>; Palmer Dabbelt
><palmer@dabbelt.com>;
>>Jagan Teki <jagan@amarulasolutions.com>; rick <rick@andestech.com>;
>>Alan Kao <alankao@andestech.com>
>>Subject: Re: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
>>
>>[External Email] Do not click links or attachments unless you recognize
>>the sender and know the content is safe
>>
>>Hi Rick,
>>
>>On Wed, Jun 24, 2020 at 2:26 PM Rick Chen <rickchen36@gmail.com> wrote:
>>>
>>> Hi Bin
>>>
>>> > Hi Rick,
>>> >
>>> > On Wed, Jun 24, 2020 at 1:24 PM Pragnesh Patel
>>> > <pragnesh.patel@sifive.com> wrote:
>>> > >
>>> > > Hi Rick,
>>> > >
>>> > > >-----Original Message-----
>>> > > >From: Rick Chen <rickchen36@gmail.com>
>>> > > >Sent: 24 June 2020 10:44
>>> > > >To: Pragnesh Patel <pragnesh.patel@sifive.com>
>>> > > >Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Atish Patra
>>> > > ><atish.patra@wdc.com>; palmerdabbelt at google.com; Bin Meng
>>> > > ><bmeng.cn@gmail.com>; Paul Walmsley ( Sifive)
>>> > > ><paul.walmsley@sifive.com>; Anup Patel <anup.patel@wdc.com>;
>>> > > >Sagar Kadam <sagar.kadam@sifive.com>; Palmer Dabbelt
>>> > > ><palmer@dabbelt.com>; Jagan Teki <jagan@amarulasolutions.com>;
>>> > > >rick <rick@andestech.com>; Alan Kao <alankao@andestech.com>
>>> > > >Subject: Re: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM
>>> > > >driver
>>> > > >
>>> > > >[External Email] Do not click links or attachments unless you
>>> > > >recognize the sender and know the content is safe
>>> > > >
>>> > > >Hi Pragnesh
>>> > > >
>>> > > >> Hi Rick,
>>> > > >>
>>> > > >> >-----Original Message-----
>>> > > >> >From: Rick Chen <rickchen36@gmail.com>
>>> > > >> >Sent: 24 June 2020 06:30
>>> > > >> >To: Pragnesh Patel <pragnesh.patel@sifive.com>
>>> > > >> >Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Atish Patra
>>> > > >> ><atish.patra@wdc.com>; palmerdabbelt at google.com; Bin Meng
>>> > > >> ><bmeng.cn@gmail.com>; Paul Walmsley ( Sifive)
>>> > > >> ><paul.walmsley@sifive.com>; Anup Patel
><anup.patel@wdc.com>;
>>> > > >> >Sagar Kadam <sagar.kadam@sifive.com>; Palmer Dabbelt
>>> > > ><palmer@dabbelt.com>;
>>> > > >> >Jagan Teki <jagan@amarulasolutions.com>; rick
>>> > > >> ><rick@andestech.com>; Alan Kao <alankao@andestech.com>
>>> > > >> >Subject: Re: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive
>>> > > >> >PWM driver
>>> > > >> >
>>> > > >> >[External Email] Do not click links or attachments unless you
>>> > > >> >recognize the sender and know the content is safe
>>> > > >> >
>>> > > >> >Hi Pragnesh
>>> > > >> >
>>> > > >> >> From: Pragnesh Patel [mailto:pragnesh.patel at sifive.com]
>>> > > >> >> Sent: Friday, May 29, 2020 2:45 PM
>>> > > >> >> To: u-boot at lists.denx.de
>>> > > >> >> Cc: atish.patra at wdc.com; palmerdabbelt at google.com;
>>> > > >> >bmeng.cn at gmail.com; paul.walmsley at sifive.com;
>>> > > >> >anup.patel at wdc.com; sagar.kadam at sifive.com; Rick Jian-Zhi
>>> > > >> >Chen(???); Pragnesh Patel; Palmer Dabbelt
>>> > > >> >> Subject: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive
>>> > > >> >> PWM driver
>>> > > >> >>
>>> > > >> >> This patch enables SiFive PWM driver for the SiFive
>>> > > >> >> Unleashed
>>board.
>>> > > >> >>
>>> > > >> >> Signed-off-by: Pragnesh Patel <pragnesh.patel@sifive.com>
>>> > > >> >> ---
>>> > > >> >> board/sifive/fu540/Kconfig | 2 ++
>>> > > >> >> 1 file changed, 2 insertions(+)
>>> > > >> >>
>>> > > >> >> diff --git a/board/sifive/fu540/Kconfig
>>> > > >> >> b/board/sifive/fu540/Kconfig index
>>> > > >> >86193d7668..683668d059 100644
>>> > > >> >> --- a/board/sifive/fu540/Kconfig
>>> > > >> >> +++ b/board/sifive/fu540/Kconfig
>>> > > >> >> @@ -65,5 +65,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
>>> > > >> >> imply SMP
>>> > > >> >> imply MISC
>>> > > >> >> imply SIFIVE_OTP
>>> > > >> >> + imply DM_PWM
>>> > > >> >> + imply PWM_SIFIVE
>>> > > >> >>
>>> > > >> >
>>> > > >> >This patch shall follow [PATCH v2 0/2] Add support for PWM SiFive.
>>> > > >> >It is weird to introduce here and not appropriate to depend
>>> > > >> >on another
>>> > > >patch.
>>> > > >>
>>> > > >> Do you want me to send this 2 patches separately independent
>>> > > >> of each
>>> > > >other ?
>>> > > >
>>> > > >How about merged [PATCH 2/2] riscv: sifive: fu540: Enable SiFive
>>> > > >PWM driver into [PATCH v2 0/2] Add support for PWM SiFive ?
>>> > >
>>> > > I am okay with it, you can go ahead and merge this patch into PWM
>>series of Yash.
>>> > >
>>> >
>>> > They are separate patches and should keep separate. I am not sure
>>> > what's the issue we want to resolve?
>>>
>>> Nothing about resolve.
>>> Logically if they can be put together, it will be more reasonable.
>>
>>Agree. Thanks for the clarification.
>>
>>That's why I recommend developers submit all related patch sets in a
>>series to help maintainers' work :)
>
>Just to clarify, you are going to merge this patch into [PATCH v2 0/2] Add
>support for PWM SiFive, right ?
>Let me know if I am wrong and you want to resubmit anything from me.
>
>>
>>Regards,
>>Bin
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
2020-07-20 6:49 ` Pragnesh Patel
@ 2020-07-20 8:22 ` Rick Chen
0 siblings, 0 replies; 15+ messages in thread
From: Rick Chen @ 2020-07-20 8:22 UTC (permalink / raw)
To: u-boot
Hi Pragnesh
> Hi Rick,
>
> Any comments on this patch ?
Applied to u-boot-riscv/master !
Thanks,
Rick
> >From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Pragnesh Patel
> >Sent: 24 June 2020 13:14
> >To: Bin Meng <bmeng.cn@gmail.com>; Rick Chen <rickchen36@gmail.com>
> >Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Atish Patra
> ><atish.patra@wdc.com>; palmerdabbelt at google.com; Paul Walmsley ( Sifive)
> ><paul.walmsley@sifive.com>; Anup Patel <anup.patel@wdc.com>; Sagar
> >Kadam <sagar.kadam@sifive.com>; Palmer Dabbelt <palmer@dabbelt.com>;
> >Jagan Teki <jagan@amarulasolutions.com>; rick <rick@andestech.com>; Alan
> >Kao <alankao@andestech.com>
> >Subject: RE: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
> >
> >Hi Rick,
> >
> >>-----Original Message-----
> >>From: Bin Meng <bmeng.cn@gmail.com>
> >>Sent: 24 June 2020 13:04
> >>To: Rick Chen <rickchen36@gmail.com>
> >>Cc: Pragnesh Patel <pragnesh.patel@sifive.com>; U-Boot Mailing List <u-
> >>boot at lists.denx.de>; Atish Patra <atish.patra@wdc.com>;
> >>palmerdabbelt at google.com; Paul Walmsley ( Sifive)
> >><paul.walmsley@sifive.com>; Anup Patel <anup.patel@wdc.com>; Sagar
> >>Kadam <sagar.kadam@sifive.com>; Palmer Dabbelt
> ><palmer@dabbelt.com>;
> >>Jagan Teki <jagan@amarulasolutions.com>; rick <rick@andestech.com>;
> >>Alan Kao <alankao@andestech.com>
> >>Subject: Re: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
> >>
> >>[External Email] Do not click links or attachments unless you recognize
> >>the sender and know the content is safe
> >>
> >>Hi Rick,
> >>
> >>On Wed, Jun 24, 2020 at 2:26 PM Rick Chen <rickchen36@gmail.com> wrote:
> >>>
> >>> Hi Bin
> >>>
> >>> > Hi Rick,
> >>> >
> >>> > On Wed, Jun 24, 2020 at 1:24 PM Pragnesh Patel
> >>> > <pragnesh.patel@sifive.com> wrote:
> >>> > >
> >>> > > Hi Rick,
> >>> > >
> >>> > > >-----Original Message-----
> >>> > > >From: Rick Chen <rickchen36@gmail.com>
> >>> > > >Sent: 24 June 2020 10:44
> >>> > > >To: Pragnesh Patel <pragnesh.patel@sifive.com>
> >>> > > >Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Atish Patra
> >>> > > ><atish.patra@wdc.com>; palmerdabbelt at google.com; Bin Meng
> >>> > > ><bmeng.cn@gmail.com>; Paul Walmsley ( Sifive)
> >>> > > ><paul.walmsley@sifive.com>; Anup Patel <anup.patel@wdc.com>;
> >>> > > >Sagar Kadam <sagar.kadam@sifive.com>; Palmer Dabbelt
> >>> > > ><palmer@dabbelt.com>; Jagan Teki <jagan@amarulasolutions.com>;
> >>> > > >rick <rick@andestech.com>; Alan Kao <alankao@andestech.com>
> >>> > > >Subject: Re: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM
> >>> > > >driver
> >>> > > >
> >>> > > >[External Email] Do not click links or attachments unless you
> >>> > > >recognize the sender and know the content is safe
> >>> > > >
> >>> > > >Hi Pragnesh
> >>> > > >
> >>> > > >> Hi Rick,
> >>> > > >>
> >>> > > >> >-----Original Message-----
> >>> > > >> >From: Rick Chen <rickchen36@gmail.com>
> >>> > > >> >Sent: 24 June 2020 06:30
> >>> > > >> >To: Pragnesh Patel <pragnesh.patel@sifive.com>
> >>> > > >> >Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Atish Patra
> >>> > > >> ><atish.patra@wdc.com>; palmerdabbelt at google.com; Bin Meng
> >>> > > >> ><bmeng.cn@gmail.com>; Paul Walmsley ( Sifive)
> >>> > > >> ><paul.walmsley@sifive.com>; Anup Patel
> ><anup.patel@wdc.com>;
> >>> > > >> >Sagar Kadam <sagar.kadam@sifive.com>; Palmer Dabbelt
> >>> > > ><palmer@dabbelt.com>;
> >>> > > >> >Jagan Teki <jagan@amarulasolutions.com>; rick
> >>> > > >> ><rick@andestech.com>; Alan Kao <alankao@andestech.com>
> >>> > > >> >Subject: Re: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive
> >>> > > >> >PWM driver
> >>> > > >> >
> >>> > > >> >[External Email] Do not click links or attachments unless you
> >>> > > >> >recognize the sender and know the content is safe
> >>> > > >> >
> >>> > > >> >Hi Pragnesh
> >>> > > >> >
> >>> > > >> >> From: Pragnesh Patel [mailto:pragnesh.patel at sifive.com]
> >>> > > >> >> Sent: Friday, May 29, 2020 2:45 PM
> >>> > > >> >> To: u-boot at lists.denx.de
> >>> > > >> >> Cc: atish.patra at wdc.com; palmerdabbelt at google.com;
> >>> > > >> >bmeng.cn at gmail.com; paul.walmsley at sifive.com;
> >>> > > >> >anup.patel at wdc.com; sagar.kadam at sifive.com; Rick Jian-Zhi
> >>> > > >> >Chen(???); Pragnesh Patel; Palmer Dabbelt
> >>> > > >> >> Subject: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive
> >>> > > >> >> PWM driver
> >>> > > >> >>
> >>> > > >> >> This patch enables SiFive PWM driver for the SiFive
> >>> > > >> >> Unleashed
> >>board.
> >>> > > >> >>
> >>> > > >> >> Signed-off-by: Pragnesh Patel <pragnesh.patel@sifive.com>
> >>> > > >> >> ---
> >>> > > >> >> board/sifive/fu540/Kconfig | 2 ++
> >>> > > >> >> 1 file changed, 2 insertions(+)
> >>> > > >> >>
> >>> > > >> >> diff --git a/board/sifive/fu540/Kconfig
> >>> > > >> >> b/board/sifive/fu540/Kconfig index
> >>> > > >> >86193d7668..683668d059 100644
> >>> > > >> >> --- a/board/sifive/fu540/Kconfig
> >>> > > >> >> +++ b/board/sifive/fu540/Kconfig
> >>> > > >> >> @@ -65,5 +65,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
> >>> > > >> >> imply SMP
> >>> > > >> >> imply MISC
> >>> > > >> >> imply SIFIVE_OTP
> >>> > > >> >> + imply DM_PWM
> >>> > > >> >> + imply PWM_SIFIVE
> >>> > > >> >>
> >>> > > >> >
> >>> > > >> >This patch shall follow [PATCH v2 0/2] Add support for PWM SiFive.
> >>> > > >> >It is weird to introduce here and not appropriate to depend
> >>> > > >> >on another
> >>> > > >patch.
> >>> > > >>
> >>> > > >> Do you want me to send this 2 patches separately independent
> >>> > > >> of each
> >>> > > >other ?
> >>> > > >
> >>> > > >How about merged [PATCH 2/2] riscv: sifive: fu540: Enable SiFive
> >>> > > >PWM driver into [PATCH v2 0/2] Add support for PWM SiFive ?
> >>> > >
> >>> > > I am okay with it, you can go ahead and merge this patch into PWM
> >>series of Yash.
> >>> > >
> >>> >
> >>> > They are separate patches and should keep separate. I am not sure
> >>> > what's the issue we want to resolve?
> >>>
> >>> Nothing about resolve.
> >>> Logically if they can be put together, it will be more reasonable.
> >>
> >>Agree. Thanks for the clarification.
> >>
> >>That's why I recommend developers submit all related patch sets in a
> >>series to help maintainers' work :)
> >
> >Just to clarify, you are going to merge this patch into [PATCH v2 0/2] Add
> >support for PWM SiFive, right ?
> >Let me know if I am wrong and you want to resubmit anything from me.
> >
> >>
> >>Regards,
> >>Bin
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2020-07-20 8:22 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-29 6:44 [PATCH 0/2] Enable all cache ways and Enable SiFive PWM driver Pragnesh Patel
2020-05-29 6:44 ` [PATCH 1/2] riscv: sifive: fu540: enable all cache ways from U-Boot proper Pragnesh Patel
2020-05-29 13:05 ` Bin Meng
2020-05-29 6:44 ` [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver Pragnesh Patel
2020-06-23 7:49 ` Bin Meng
[not found] ` <752D002CFF5D0F4FA35C0100F1D73F3FA471C0BE@ATCPCS16.andestech.com>
2020-06-24 0:59 ` Rick Chen
2020-06-24 4:32 ` Pragnesh Patel
2020-06-24 5:14 ` Rick Chen
2020-06-24 5:24 ` Pragnesh Patel
2020-06-24 5:29 ` Bin Meng
2020-06-24 6:26 ` Rick Chen
2020-06-24 7:34 ` Bin Meng
2020-06-24 7:44 ` Pragnesh Patel
2020-07-20 6:49 ` Pragnesh Patel
2020-07-20 8:22 ` Rick Chen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.