From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lorenzo Pieralisi Subject: Re: [PATCH] PCI: tegra: fix runtime pm imbalance on error Date: Fri, 29 May 2020 11:23:17 +0100 Message-ID: <20200529102317.GA12270@e121166-lin.cambridge.arm.com> References: <20200520163739.GA1100601@bjorn-Precision-5520> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Vidya Sagar , Thierry Reding Cc: Bjorn Helgaas , Dinghao Liu , kjlu-OJFnDUYgAso@public.gmane.org, Rob Herring , Bjorn Helgaas , Jonathan Hunter , Andrew Murray , linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On Wed, May 20, 2020 at 11:39:08PM +0530, Vidya Sagar wrote: > Thanks for pushing a patch to fix it. I've been under the wrong assumption > that a failing pm_runtime_get_sync() wouldn't increment the usage counter. > With Thierry's and Bjorn's comments addressed > > Acked-by: Vidya Sagar Thierry, Vidya, are your ACKs applying also to: https://patchwork.kernel.org/patch/11562109/ Dinghao did not carry them over and I could not understand from this thread if your ACKs apply to both tegra and tegra194. Thanks, Lorenzo > On 20-May-20 10:07 PM, Bjorn Helgaas wrote: > > External email: Use caution opening links or attachments > > > > > > On Wed, May 20, 2020 at 11:59:08AM +0200, Thierry Reding wrote: > > > On Wed, May 20, 2020 at 04:52:23PM +0800, Dinghao Liu wrote: > > > > pm_runtime_get_sync() increments the runtime PM usage counter even > > > > it returns an error code. Thus a pairing decrement is needed on > > > > > > s/even it/even when it/ > > > > > > Might also be a good idea to use a different subject prefix because I > > > was almost not going to look at the other patch, taking this to be a > > > replacement for it. > > > > Amen. This would be a good change to start using "PCI: tegra194" or > > something for pcie-tegra194.c. Or will there be tegra195, tegra 196, > > etc added to this driver? > > > > Also, please capitalize the first word and "PM" in the subjects: > > > > PCI: tegra194: Fix runtime PM imbalance on error > > > > Bjorn > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 473EBC433DF for ; Fri, 29 May 2020 10:23:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1FCA2207BC for ; Fri, 29 May 2020 10:23:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726509AbgE2KXd (ORCPT ); Fri, 29 May 2020 06:23:33 -0400 Received: from foss.arm.com ([217.140.110.172]:34642 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725795AbgE2KX1 (ORCPT ); Fri, 29 May 2020 06:23:27 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 161EA1045; Fri, 29 May 2020 03:23:26 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 595753F52E; Fri, 29 May 2020 03:23:24 -0700 (PDT) Date: Fri, 29 May 2020 11:23:17 +0100 From: Lorenzo Pieralisi To: Vidya Sagar , Thierry Reding Cc: Bjorn Helgaas , Dinghao Liu , kjlu@umn.edu, Rob Herring , Bjorn Helgaas , Jonathan Hunter , Andrew Murray , linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: tegra: fix runtime pm imbalance on error Message-ID: <20200529102317.GA12270@e121166-lin.cambridge.arm.com> References: <20200520163739.GA1100601@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 20, 2020 at 11:39:08PM +0530, Vidya Sagar wrote: > Thanks for pushing a patch to fix it. I've been under the wrong assumption > that a failing pm_runtime_get_sync() wouldn't increment the usage counter. > With Thierry's and Bjorn's comments addressed > > Acked-by: Vidya Sagar Thierry, Vidya, are your ACKs applying also to: https://patchwork.kernel.org/patch/11562109/ Dinghao did not carry them over and I could not understand from this thread if your ACKs apply to both tegra and tegra194. Thanks, Lorenzo > On 20-May-20 10:07 PM, Bjorn Helgaas wrote: > > External email: Use caution opening links or attachments > > > > > > On Wed, May 20, 2020 at 11:59:08AM +0200, Thierry Reding wrote: > > > On Wed, May 20, 2020 at 04:52:23PM +0800, Dinghao Liu wrote: > > > > pm_runtime_get_sync() increments the runtime PM usage counter even > > > > it returns an error code. Thus a pairing decrement is needed on > > > > > > s/even it/even when it/ > > > > > > Might also be a good idea to use a different subject prefix because I > > > was almost not going to look at the other patch, taking this to be a > > > replacement for it. > > > > Amen. This would be a good change to start using "PCI: tegra194" or > > something for pcie-tegra194.c. Or will there be tegra195, tegra 196, > > etc added to this driver? > > > > Also, please capitalize the first word and "PM" in the subjects: > > > > PCI: tegra194: Fix runtime PM imbalance on error > > > > Bjorn > >