From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 759B5C433DF for ; Fri, 29 May 2020 09:27:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 46FA82072D for ; Fri, 29 May 2020 09:27:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iOoQfiq/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 46FA82072D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eDVxeHsZ6qXR2YTICBbAaSPz9I+Dek7QrUnt6d795Nc=; b=iOoQfiq/vIscrO 8TDSyHn54PFJBIVwhHiqT5NmnSd9PdselWLu/Fd+4CCtHYQ25xytntG+fq6oKMLtW2cUm5T0C0OcG YQC+YgOtVjG2sorXJLYoOQY0nMnQ6m5PgWBo6+tFn2x6IMTFprwTqb5qqjbEHjOM0LfCy/zPrxxLM lDCYT5PtwZaZs6cacpKcV6Z2Tp/ubihs60w29vdzrHV1FqvZIkkGPWre0aniuhbTRbQbKrh2rSrAU 33K9HEiI5o4sPWnRyl6tF75TrLtBVsbqitr6zfHl0UFNmdkaCLS4Ur01jLK9KO2itaH9y45WhCStw PpWXrnNFcnNDxzHqujvA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jebIp-0002LE-Ey; Fri, 29 May 2020 09:27:47 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jebIm-0002Kr-1D for linux-mtd@lists.infradead.org; Fri, 29 May 2020 09:27:45 +0000 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 56ABB2000E; Fri, 29 May 2020 09:27:39 +0000 (UTC) Date: Fri, 29 May 2020 11:27:38 +0200 From: Miquel Raynal To: Boris Brezillon Subject: Re: [PATCH v6 19/30] mtd: rawnand: Define a unique reset interface configuration Message-ID: <20200529112738.2f58858d@xps13> In-Reply-To: <20200529093205.626f36d9@collabora.com> References: <20200528231612.8958-1-miquel.raynal@bootlin.com> <20200528231612.8958-20-miquel.raynal@bootlin.com> <20200529093205.626f36d9@collabora.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200529_022744_344243_60CE85E3 X-CRM114-Status: GOOD ( 20.09 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rickard Andersson , Michal Simek , Vignesh Raghavendra , Tudor Ambarus , Richard Weinberger , linux-mtd@lists.infradead.org, Thomas Petazzoni , Naga Sureshkumar Relli Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Boris Brezillon wrote on Fri, 29 May 2020 09:32:05 +0200: > On Fri, 29 May 2020 01:16:01 +0200 > Miquel Raynal wrote: > > > All NAND chips will always use the same interface configuration for > > reset and at startup: SDR mode 0. Instead of copying around the > > interface configuration, let's just define a helper to retrieve the > > reset interface configuration object. > > > > Signed-off-by: Miquel Raynal > > --- > > drivers/mtd/nand/raw/nand_base.c | 10 +++------- > > drivers/mtd/nand/raw/nand_timings.c | 6 ++++++ > > include/linux/mtd/rawnand.h | 3 +++ > > 3 files changed, 12 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c > > index 07a7d918b462..4a72ec221262 100644 > > --- a/drivers/mtd/nand/raw/nand_base.c > > +++ b/drivers/mtd/nand/raw/nand_base.c > > @@ -928,9 +928,7 @@ static int nand_reset_interface(struct nand_chip *chip, int chipnr) > > * timings to timing mode 0. > > */ > > > > - onfi_fill_interface_config(chip, &chip->interface_config, > > - NAND_SDR_IFACE, 0); > > - ret = ops->setup_interface(chip, chipnr, &chip->interface_config); > > + ret = ops->setup_interface(chip, chipnr, nand_get_reset_interface()); > > if (ret) > > pr_err("Failed to configure data interface to SDR timing mode 0\n"); > > > > @@ -2483,7 +2481,6 @@ EXPORT_SYMBOL_GPL(nand_subop_get_data_len); > > */ > > int nand_reset(struct nand_chip *chip, int chipnr) > > { > > - struct nand_interface_config saved_intf_config = chip->interface_config; > > int ret; > > > > ret = nand_reset_interface(chip, chipnr); > > @@ -2508,11 +2505,10 @@ int nand_reset(struct nand_chip *chip, int chipnr) > > * nand_setup_interface() uses ->set/get_features() which would > > * fail anyway as the parameter page is not available yet. > > */ > > - if (!memcmp(&chip->interface_config, &saved_intf_config, > > - sizeof(saved_intf_config))) > > + if (!memcmp(&chip->interface_config, nand_get_reset_interface(), > > + sizeof(chip->interface_config))) > > return 0; > > > > - chip->interface_config = saved_intf_config; > > Are you sure you can do that now? Looks like the current interface > config is not preserved, and you end up with mode 0 after a reset. You're probably right, I'll move that to the patch handling interface_config pointers. > > > ret = nand_setup_interface(chip, chipnr); > > if (ret) > > return ret; > > diff --git a/drivers/mtd/nand/raw/nand_timings.c b/drivers/mtd/nand/raw/nand_timings.c > > index 6c12cd52323d..0089196b9e36 100644 > > --- a/drivers/mtd/nand/raw/nand_timings.c > > +++ b/drivers/mtd/nand/raw/nand_timings.c > > @@ -292,6 +292,12 @@ static const struct nand_interface_config onfi_sdr_timings[] = { > > }, > > }; > > > > +/* All NAND chips share the same reset data interface: SDR mode 0 */ > > +const struct nand_interface_config *nand_get_reset_interface(void) > > +{ > > + return &onfi_sdr_timings[0]; > > +} > > + > > /** > > * onfi_find_closest_sdr_mode - Derive the closest ONFI SDR timing mode given a > > * set of timings > > diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h > > index c2fcac38bcc2..b37eb5ee11c8 100644 > > --- a/include/linux/mtd/rawnand.h > > +++ b/include/linux/mtd/rawnand.h > > @@ -1202,6 +1202,9 @@ static inline struct device_node *nand_get_flash_node(struct nand_chip *chip) > > return mtd_get_of_node(nand_to_mtd(chip)); > > } > > > > +/* Default/reset data interface */ > > +const struct nand_interface_config *nand_get_reset_interface(void); > > + > > /* > > * A helper for defining older NAND chips where the second ID byte fully > > * defined the chip, including the geometry (chip size, eraseblock size, page > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/