From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4374C433E0 for ; Fri, 29 May 2020 12:09:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 826842077D for ; Fri, 29 May 2020 12:09:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590754157; bh=ePj9rbQ0Sk2NuJf9ZsB+VxMkuuhjLMWxfQxMQiI/sc8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=BGHnu0fXC/IMx3iwMtjLfEX2H/yKasVe8XStu8W6xO9Jrljf5TN0ALimZVDlJl0DW tAF2HQ4mVWwotJKPbrvGLc08E985GL4W6oGCtEIe5pvSuYJoxBw14QOOMmz3JO3Xtv Q+NKdsXaISrt+k/8Jeca0Npr9iFR50ymoLczsO7A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726886AbgE2MJQ (ORCPT ); Fri, 29 May 2020 08:09:16 -0400 Received: from mail-pj1-f68.google.com ([209.85.216.68]:39077 "EHLO mail-pj1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725306AbgE2MJP (ORCPT ); Fri, 29 May 2020 08:09:15 -0400 Received: by mail-pj1-f68.google.com with SMTP id h95so374791pje.4 for ; Fri, 29 May 2020 05:09:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6vvgKHZv01UUvGrvhAsOqf6+UpVrlcy+OwWplQqQmoA=; b=AEXCCEFXfWm5zZ114b0KWuB6nfRF8NMepHdNcqkFDCVJtmmHI1BeyolNi4xvRZT4c9 6MaHrXdsGgJAQqbbYvybIKPu8jZ2aDqjoEQAOrnMpvD0sy7QSvbJoJt1Bx51vWwoeU/o t7s2VJabJcG21+DMEluiYflda2X4xUA3iTo4xO0drxQlg7K0CEOh601kBFfpbggZbqkA 124w+0DTNnwsW5icBVhp4I5N6H94iwqNT7Fj8Jl3mXew7b0FXJXE7BRCJIwkZCG1P/Oe VrgKmBQiO0ixSovohDli8cniqmhMIyY3x9b16mWfOBAXHrs0J9PyWG+82sEQyBH1HXbD jUZA== X-Gm-Message-State: AOAM533Cxd3p00nIgp1fV6beFZ1R3CFwqELbsjge3w0L8Bz7yfy1j8Jh 6MWShLwvuBeWYkfXQkGwDow= X-Google-Smtp-Source: ABdhPJwH0ItHfFV94FqIi+i7pGGCJoHNOMavuCMZwaTSNJ24JRmSNe+lTFt06Kawbit8Fif5KqcKXw== X-Received: by 2002:a17:90a:ce11:: with SMTP id f17mr2283340pju.123.1590754154418; Fri, 29 May 2020 05:09:14 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id l187sm7199102pfl.218.2020.05.29.05.09.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2020 05:09:13 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id AE8314046C; Fri, 29 May 2020 12:09:12 +0000 (UTC) Date: Fri, 29 May 2020 12:09:12 +0000 From: Luis Chamberlain To: Greg KH Cc: keescook@chromium.org, yzaikin@google.com, nixiaoming@huawei.com, ebiederm@xmission.com, axboe@kernel.dk, clemens@ladisch.de, arnd@arndb.de, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, airlied@linux.ie, daniel@ffwll.ch, benh@kernel.crashing.org, rdna@fb.com, viro@zeniv.linux.org.uk, mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, vbabka@suse.cz, sfr@canb.auug.org.au, jack@suse.cz, amir73il@gmail.com, rafael@kernel.org, tytso@mit.edu, julia.lawall@lip6.fr, akpm@linux-foundation.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linuxppc-dev@lists.ozlabs.org, ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/13] firmware_loader: simplify sysctl declaration with register_sysctl_subdir() Message-ID: <20200529120912.GD11244@42.do-not-panic.com> References: <20200529074108.16928-1-mcgrof@kernel.org> <20200529074108.16928-10-mcgrof@kernel.org> <20200529102613.GA1345939@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200529102613.GA1345939@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 29, 2020 at 12:26:13PM +0200, Greg KH wrote: > On Fri, May 29, 2020 at 07:41:04AM +0000, Luis Chamberlain wrote: > > From: Xiaoming Ni > > > > Move the firmware config sysctl table to fallback_table.c and use the > > new register_sysctl_subdir() helper. This removes the clutter from > > kernel/sysctl.c. > > > > Signed-off-by: Xiaoming Ni > > Signed-off-by: Luis Chamberlain > > --- > > drivers/base/firmware_loader/fallback.c | 4 ++++ > > drivers/base/firmware_loader/fallback.h | 11 ++++++++++ > > drivers/base/firmware_loader/fallback_table.c | 22 +++++++++++++++++-- > > include/linux/sysctl.h | 1 - > > kernel/sysctl.c | 7 ------ > > 5 files changed, 35 insertions(+), 10 deletions(-) > > So it now takes more lines than the old stuff? :( Pretty much agreed with the other changes, thanks for the review! But this diff-stat change, indeed, it is unfortunate that we end up with more code here than before. We'll try to reduce it instead somehow, however in some cases during this spring-cleaning, since the goal is to move code from one file to another, it *may* require more code. So it won't always be negative. But we'll try! Luis From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luis Chamberlain Date: Fri, 29 May 2020 12:09:12 +0000 Subject: [Ocfs2-devel] [PATCH 09/13] firmware_loader: simplify sysctl declaration with register_sysctl_subdir() In-Reply-To: <20200529102613.GA1345939@kroah.com> References: <20200529074108.16928-1-mcgrof@kernel.org> <20200529074108.16928-10-mcgrof@kernel.org> <20200529102613.GA1345939@kroah.com> Message-ID: <20200529120912.GD11244@42.do-not-panic.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Greg KH Cc: jack@suse.cz, rafael@kernel.org, airlied@linux.ie, amir73il@gmail.com, clemens@ladisch.de, dri-devel@lists.freedesktop.org, joseph.qi@linux.alibaba.com, sfr@canb.auug.org.au, mark@fasheh.com, rdna@fb.com, yzaikin@google.com, keescook@chromium.org, arnd@arndb.de, intel-gfx@lists.freedesktop.org, julia.lawall@lip6.fr, jlbec@evilplan.org, rodrigo.vivi@intel.com, nixiaoming@huawei.com, vbabka@suse.cz, axboe@kernel.dk, tytso@mit.edu, linux-kernel@vger.kernel.org, ebiederm@xmission.com, akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org, ocfs2-devel@oss.oracle.com, viro@zeniv.linux.org.uk On Fri, May 29, 2020 at 12:26:13PM +0200, Greg KH wrote: > On Fri, May 29, 2020 at 07:41:04AM +0000, Luis Chamberlain wrote: > > From: Xiaoming Ni > > > > Move the firmware config sysctl table to fallback_table.c and use the > > new register_sysctl_subdir() helper. This removes the clutter from > > kernel/sysctl.c. > > > > Signed-off-by: Xiaoming Ni > > Signed-off-by: Luis Chamberlain > > --- > > drivers/base/firmware_loader/fallback.c | 4 ++++ > > drivers/base/firmware_loader/fallback.h | 11 ++++++++++ > > drivers/base/firmware_loader/fallback_table.c | 22 +++++++++++++++++-- > > include/linux/sysctl.h | 1 - > > kernel/sysctl.c | 7 ------ > > 5 files changed, 35 insertions(+), 10 deletions(-) > > So it now takes more lines than the old stuff? :( Pretty much agreed with the other changes, thanks for the review! But this diff-stat change, indeed, it is unfortunate that we end up with more code here than before. We'll try to reduce it instead somehow, however in some cases during this spring-cleaning, since the goal is to move code from one file to another, it *may* require more code. So it won't always be negative. But we'll try! Luis From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ECF1C433DF for ; Fri, 29 May 2020 12:12:40 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D54C92074D for ; Fri, 29 May 2020 12:12:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D54C92074D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49YNjx5N3ZzDqg5 for ; Fri, 29 May 2020 22:12:37 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.216.68; helo=mail-pj1-f68.google.com; envelope-from=mcgrof@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=fail (p=none dis=none) header.from=kernel.org Received: from mail-pj1-f68.google.com (mail-pj1-f68.google.com [209.85.216.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49YNf666txzDqf5 for ; Fri, 29 May 2020 22:09:16 +1000 (AEST) Received: by mail-pj1-f68.google.com with SMTP id q9so1263416pjm.2 for ; Fri, 29 May 2020 05:09:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6vvgKHZv01UUvGrvhAsOqf6+UpVrlcy+OwWplQqQmoA=; b=ZUYxIsIzZlRnFNjqaofJ9YtDneGHsFXwX81+PFwsVro4lBucPkswr8sx4fePrEI8lB BdrL5mWz9rwLeQFjzf9trbWeioy46gFCYCvH8rw8s3fiAb8HPp5atm7yy6UmwuNQWOob umUANVJ0Sn80GX1R3svdeJQmIKEr4epU07GOFzzL/RprMU6Jvg1She7EqZwuG5qTu1ow AS4R9H3sQkilMtWZkszPxB3lF5agyei1kereVe6tY+FjSIRUyh3aRbMR6IDdFDt88t+e v5e1sGvV3Z6SEWSUGI9LHaSVncy78govFGdhDw5EUS87rbLhLOIdj7G1gl7sU5OpxgBc h0SQ== X-Gm-Message-State: AOAM532FEGJG10wTQHr4JZOX9+T7CmQkULmGLrqCIMzos8VIISQLd7mj crxX1idmZco73D3IhFLuJw0= X-Google-Smtp-Source: ABdhPJwH0ItHfFV94FqIi+i7pGGCJoHNOMavuCMZwaTSNJ24JRmSNe+lTFt06Kawbit8Fif5KqcKXw== X-Received: by 2002:a17:90a:ce11:: with SMTP id f17mr2283340pju.123.1590754154418; Fri, 29 May 2020 05:09:14 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id l187sm7199102pfl.218.2020.05.29.05.09.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2020 05:09:13 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id AE8314046C; Fri, 29 May 2020 12:09:12 +0000 (UTC) Date: Fri, 29 May 2020 12:09:12 +0000 From: Luis Chamberlain To: Greg KH Subject: Re: [PATCH 09/13] firmware_loader: simplify sysctl declaration with register_sysctl_subdir() Message-ID: <20200529120912.GD11244@42.do-not-panic.com> References: <20200529074108.16928-1-mcgrof@kernel.org> <20200529074108.16928-10-mcgrof@kernel.org> <20200529102613.GA1345939@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200529102613.GA1345939@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jack@suse.cz, rafael@kernel.org, airlied@linux.ie, amir73il@gmail.com, clemens@ladisch.de, dri-devel@lists.freedesktop.org, joseph.qi@linux.alibaba.com, sfr@canb.auug.org.au, mark@fasheh.com, rdna@fb.com, yzaikin@google.com, joonas.lahtinen@linux.intel.com, keescook@chromium.org, arnd@arndb.de, intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com, julia.lawall@lip6.fr, jlbec@evilplan.org, rodrigo.vivi@intel.com, nixiaoming@huawei.com, vbabka@suse.cz, axboe@kernel.dk, tytso@mit.edu, linux-kernel@vger.kernel.org, ebiederm@xmission.com, daniel@ffwll.ch, akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org, ocfs2-devel@oss.oracle.com, viro@zeniv.linux.org.uk Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, May 29, 2020 at 12:26:13PM +0200, Greg KH wrote: > On Fri, May 29, 2020 at 07:41:04AM +0000, Luis Chamberlain wrote: > > From: Xiaoming Ni > > > > Move the firmware config sysctl table to fallback_table.c and use the > > new register_sysctl_subdir() helper. This removes the clutter from > > kernel/sysctl.c. > > > > Signed-off-by: Xiaoming Ni > > Signed-off-by: Luis Chamberlain > > --- > > drivers/base/firmware_loader/fallback.c | 4 ++++ > > drivers/base/firmware_loader/fallback.h | 11 ++++++++++ > > drivers/base/firmware_loader/fallback_table.c | 22 +++++++++++++++++-- > > include/linux/sysctl.h | 1 - > > kernel/sysctl.c | 7 ------ > > 5 files changed, 35 insertions(+), 10 deletions(-) > > So it now takes more lines than the old stuff? :( Pretty much agreed with the other changes, thanks for the review! But this diff-stat change, indeed, it is unfortunate that we end up with more code here than before. We'll try to reduce it instead somehow, however in some cases during this spring-cleaning, since the goal is to move code from one file to another, it *may* require more code. So it won't always be negative. But we'll try! Luis From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EE87C433DF for ; Fri, 29 May 2020 12:09:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2DE3B206F0 for ; Fri, 29 May 2020 12:09:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DE3B206F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 094846E8DF; Fri, 29 May 2020 12:09:16 +0000 (UTC) Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id E49676E8DA; Fri, 29 May 2020 12:09:14 +0000 (UTC) Received: by mail-pj1-f65.google.com with SMTP id 5so1270156pjd.0; Fri, 29 May 2020 05:09:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6vvgKHZv01UUvGrvhAsOqf6+UpVrlcy+OwWplQqQmoA=; b=UUVtofIwQNHqPTitzSAJjBz9ueAdSfUpALXKo4+RjiPgO/EgXDkNGXc+BwlvQEIgZq iw+1PoCNVP462mcYd9Qf9xmE2zYnjjQNjcxQ8KUj2YzVAP3Pp127N9j0C7XRaCMeE/ur BGjVMrOTi565aowPxyHTrxelVIf+k1q1F3IuztwpQIGNFSxm/QgiVAx7Yapr/HddizeW JMm3IvolNORwH6hpehAF0BRQ2NFCKqDT2idGGgXykeK49M7ircRKsWNnU3yTA6E7vhu/ Po/QUYKGXuZSZTQF1iXVqj4r05qFviFaMmexfyDSyux/ePCRuS3sl8JAT63kpPEi4kvR pnjw== X-Gm-Message-State: AOAM531NQMqpWsgIPXtwP0deb6xn1EFezLJnImJoT4nGYns2Ng/rIumq DGskBbcxTVlAZvVRTOuXNoY= X-Google-Smtp-Source: ABdhPJwH0ItHfFV94FqIi+i7pGGCJoHNOMavuCMZwaTSNJ24JRmSNe+lTFt06Kawbit8Fif5KqcKXw== X-Received: by 2002:a17:90a:ce11:: with SMTP id f17mr2283340pju.123.1590754154418; Fri, 29 May 2020 05:09:14 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id l187sm7199102pfl.218.2020.05.29.05.09.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2020 05:09:13 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id AE8314046C; Fri, 29 May 2020 12:09:12 +0000 (UTC) Date: Fri, 29 May 2020 12:09:12 +0000 From: Luis Chamberlain To: Greg KH Subject: Re: [PATCH 09/13] firmware_loader: simplify sysctl declaration with register_sysctl_subdir() Message-ID: <20200529120912.GD11244@42.do-not-panic.com> References: <20200529074108.16928-1-mcgrof@kernel.org> <20200529074108.16928-10-mcgrof@kernel.org> <20200529102613.GA1345939@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200529102613.GA1345939@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jack@suse.cz, rafael@kernel.org, airlied@linux.ie, amir73il@gmail.com, clemens@ladisch.de, dri-devel@lists.freedesktop.org, joseph.qi@linux.alibaba.com, sfr@canb.auug.org.au, mark@fasheh.com, rdna@fb.com, yzaikin@google.com, keescook@chromium.org, arnd@arndb.de, intel-gfx@lists.freedesktop.org, julia.lawall@lip6.fr, jlbec@evilplan.org, rodrigo.vivi@intel.com, nixiaoming@huawei.com, vbabka@suse.cz, axboe@kernel.dk, tytso@mit.edu, linux-kernel@vger.kernel.org, ebiederm@xmission.com, akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org, ocfs2-devel@oss.oracle.com, viro@zeniv.linux.org.uk Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, May 29, 2020 at 12:26:13PM +0200, Greg KH wrote: > On Fri, May 29, 2020 at 07:41:04AM +0000, Luis Chamberlain wrote: > > From: Xiaoming Ni > > > > Move the firmware config sysctl table to fallback_table.c and use the > > new register_sysctl_subdir() helper. This removes the clutter from > > kernel/sysctl.c. > > > > Signed-off-by: Xiaoming Ni > > Signed-off-by: Luis Chamberlain > > --- > > drivers/base/firmware_loader/fallback.c | 4 ++++ > > drivers/base/firmware_loader/fallback.h | 11 ++++++++++ > > drivers/base/firmware_loader/fallback_table.c | 22 +++++++++++++++++-- > > include/linux/sysctl.h | 1 - > > kernel/sysctl.c | 7 ------ > > 5 files changed, 35 insertions(+), 10 deletions(-) > > So it now takes more lines than the old stuff? :( Pretty much agreed with the other changes, thanks for the review! But this diff-stat change, indeed, it is unfortunate that we end up with more code here than before. We'll try to reduce it instead somehow, however in some cases during this spring-cleaning, since the goal is to move code from one file to another, it *may* require more code. So it won't always be negative. But we'll try! Luis _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12D01C433E1 for ; Fri, 29 May 2020 12:09:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7E53208B8 for ; Fri, 29 May 2020 12:09:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7E53208B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 76AFF6E8DA; Fri, 29 May 2020 12:09:15 +0000 (UTC) Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id E49676E8DA; Fri, 29 May 2020 12:09:14 +0000 (UTC) Received: by mail-pj1-f65.google.com with SMTP id 5so1270156pjd.0; Fri, 29 May 2020 05:09:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6vvgKHZv01UUvGrvhAsOqf6+UpVrlcy+OwWplQqQmoA=; b=UUVtofIwQNHqPTitzSAJjBz9ueAdSfUpALXKo4+RjiPgO/EgXDkNGXc+BwlvQEIgZq iw+1PoCNVP462mcYd9Qf9xmE2zYnjjQNjcxQ8KUj2YzVAP3Pp127N9j0C7XRaCMeE/ur BGjVMrOTi565aowPxyHTrxelVIf+k1q1F3IuztwpQIGNFSxm/QgiVAx7Yapr/HddizeW JMm3IvolNORwH6hpehAF0BRQ2NFCKqDT2idGGgXykeK49M7ircRKsWNnU3yTA6E7vhu/ Po/QUYKGXuZSZTQF1iXVqj4r05qFviFaMmexfyDSyux/ePCRuS3sl8JAT63kpPEi4kvR pnjw== X-Gm-Message-State: AOAM531NQMqpWsgIPXtwP0deb6xn1EFezLJnImJoT4nGYns2Ng/rIumq DGskBbcxTVlAZvVRTOuXNoY= X-Google-Smtp-Source: ABdhPJwH0ItHfFV94FqIi+i7pGGCJoHNOMavuCMZwaTSNJ24JRmSNe+lTFt06Kawbit8Fif5KqcKXw== X-Received: by 2002:a17:90a:ce11:: with SMTP id f17mr2283340pju.123.1590754154418; Fri, 29 May 2020 05:09:14 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id l187sm7199102pfl.218.2020.05.29.05.09.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2020 05:09:13 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id AE8314046C; Fri, 29 May 2020 12:09:12 +0000 (UTC) Date: Fri, 29 May 2020 12:09:12 +0000 From: Luis Chamberlain To: Greg KH Message-ID: <20200529120912.GD11244@42.do-not-panic.com> References: <20200529074108.16928-1-mcgrof@kernel.org> <20200529074108.16928-10-mcgrof@kernel.org> <20200529102613.GA1345939@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200529102613.GA1345939@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH 09/13] firmware_loader: simplify sysctl declaration with register_sysctl_subdir() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jack@suse.cz, rafael@kernel.org, airlied@linux.ie, benh@kernel.crashing.org, amir73il@gmail.com, clemens@ladisch.de, dri-devel@lists.freedesktop.org, joseph.qi@linux.alibaba.com, sfr@canb.auug.org.au, mark@fasheh.com, rdna@fb.com, yzaikin@google.com, keescook@chromium.org, arnd@arndb.de, intel-gfx@lists.freedesktop.org, julia.lawall@lip6.fr, jlbec@evilplan.org, nixiaoming@huawei.com, vbabka@suse.cz, axboe@kernel.dk, tytso@mit.edu, linux-kernel@vger.kernel.org, ebiederm@xmission.com, akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org, ocfs2-devel@oss.oracle.com, viro@zeniv.linux.org.uk Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, May 29, 2020 at 12:26:13PM +0200, Greg KH wrote: > On Fri, May 29, 2020 at 07:41:04AM +0000, Luis Chamberlain wrote: > > From: Xiaoming Ni > > > > Move the firmware config sysctl table to fallback_table.c and use the > > new register_sysctl_subdir() helper. This removes the clutter from > > kernel/sysctl.c. > > > > Signed-off-by: Xiaoming Ni > > Signed-off-by: Luis Chamberlain > > --- > > drivers/base/firmware_loader/fallback.c | 4 ++++ > > drivers/base/firmware_loader/fallback.h | 11 ++++++++++ > > drivers/base/firmware_loader/fallback_table.c | 22 +++++++++++++++++-- > > include/linux/sysctl.h | 1 - > > kernel/sysctl.c | 7 ------ > > 5 files changed, 35 insertions(+), 10 deletions(-) > > So it now takes more lines than the old stuff? :( Pretty much agreed with the other changes, thanks for the review! But this diff-stat change, indeed, it is unfortunate that we end up with more code here than before. We'll try to reduce it instead somehow, however in some cases during this spring-cleaning, since the goal is to move code from one file to another, it *may* require more code. So it won't always be negative. But we'll try! Luis _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx