From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23328C433DF for ; Fri, 29 May 2020 13:19:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 02C87208B8 for ; Fri, 29 May 2020 13:19:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726751AbgE2NT6 (ORCPT ); Fri, 29 May 2020 09:19:58 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:40796 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726712AbgE2NT6 (ORCPT ); Fri, 29 May 2020 09:19:58 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1jeevR-0006hX-6C; Fri, 29 May 2020 23:19:54 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 29 May 2020 23:19:53 +1000 Date: Fri, 29 May 2020 23:19:53 +1000 From: Herbert Xu To: Ard Biesheuvel Cc: Linux Crypto Mailing List , Linux ARM , Eric Biggers , Stephan Mueller Subject: Re: [RFC/RFT PATCH 0/2] crypto: add CTS output IVs for arm64 and testmgr Message-ID: <20200529131953.GA9187@gondor.apana.org.au> References: <20200519190211.76855-1-ardb@kernel.org> <20200528073349.GA32566@gondor.apana.org.au> <20200529080508.GA2880@gondor.apana.org.au> <20200529115126.GA3573@gondor.apana.org.au> <20200529120216.GA3752@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, May 29, 2020 at 03:10:43PM +0200, Ard Biesheuvel wrote: > > OK, so the undocumented assumption is that algif_skcipher requests are > delineated by ALG_SET_IV commands, and that anything that gets sent to > the socket in between should be treated as a single request, right? I Correct. > think that makes sense, but do note that this deviates from Stephan's > use case, where the ciphertext stealing block swap was applied after > every call into af_alg, with the IV being inherited from one request > to the next. I think that case was invalid to begin with, I just hope > no other use cases exist where this unspecified behavior is being > relied upon. That does indeed sound broken. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30DFFC433DF for ; Fri, 29 May 2020 13:20:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA602207F5 for ; Fri, 29 May 2020 13:20:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gorqsFTm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA602207F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gondor.apana.org.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Sej5FNMySSmUE6EqHBXcd1SwNfc7kVdu92rjmd/B2BQ=; b=gorqsFTm+1IzHf Wkc6I9RIxaC2KUXlLRavrAyqDAwyRU6zbwXN0EZ4YLvUxjpZEFu08zm0JXMUbG4oeDv1naSSjD5d2 OOv3e8DebwittW/gu96Q7eTFPjl8AZ9ncNXU8ILWr9nN1T1fX18JnoHaz2ZuGf6mQrP8n1NPMsH8t yExg0PFsj4bH6L5GFH+e8nGnV36R8Vp447PRGvaarW7ScHQNKpGJQ3YgaUPefV7NHfa/wdAOUuVY2 kpmixwZKoc6nlfRY7015XfFO3pNqv+47BEKV+2ZpAKfKvjVdwVKYdcTbNdoyu2pPGLzmNXFiuk+Cg QQdZrUa8gnjtmwVt0C3A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeevd-0004fJ-6c; Fri, 29 May 2020 13:20:05 +0000 Received: from helcar.hmeau.com ([216.24.177.18] helo=fornost.hmeau.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeevX-0004ND-Cw for linux-arm-kernel@lists.infradead.org; Fri, 29 May 2020 13:20:02 +0000 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1jeevR-0006hX-6C; Fri, 29 May 2020 23:19:54 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 29 May 2020 23:19:53 +1000 Date: Fri, 29 May 2020 23:19:53 +1000 From: Herbert Xu To: Ard Biesheuvel Subject: Re: [RFC/RFT PATCH 0/2] crypto: add CTS output IVs for arm64 and testmgr Message-ID: <20200529131953.GA9187@gondor.apana.org.au> References: <20200519190211.76855-1-ardb@kernel.org> <20200528073349.GA32566@gondor.apana.org.au> <20200529080508.GA2880@gondor.apana.org.au> <20200529115126.GA3573@gondor.apana.org.au> <20200529120216.GA3752@gondor.apana.org.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200529_061959_444192_BB91E7DA X-CRM114-Status: UNSURE ( 7.67 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eric Biggers , Stephan Mueller , Linux Crypto Mailing List , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 29, 2020 at 03:10:43PM +0200, Ard Biesheuvel wrote: > > OK, so the undocumented assumption is that algif_skcipher requests are > delineated by ALG_SET_IV commands, and that anything that gets sent to > the socket in between should be treated as a single request, right? I Correct. > think that makes sense, but do note that this deviates from Stephan's > use case, where the ciphertext stealing block swap was applied after > every call into af_alg, with the IV being inherited from one request > to the next. I think that case was invalid to begin with, I just hope > no other use cases exist where this unspecified behavior is being > relied upon. That does indeed sound broken. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel