From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FC1AC433DF for ; Fri, 29 May 2020 18:01:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6BFDE2074D for ; Fri, 29 May 2020 18:01:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727062AbgE2SB0 (ORCPT ); Fri, 29 May 2020 14:01:26 -0400 Received: from muru.com ([72.249.23.125]:56226 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725808AbgE2SB0 (ORCPT ); Fri, 29 May 2020 14:01:26 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 8826F8030; Fri, 29 May 2020 18:02:16 +0000 (UTC) Date: Fri, 29 May 2020 11:01:23 -0700 From: Tony Lindgren To: Sudeep Holla Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Greg Kroah-Hartman , linux-omap@vger.kernel.org Subject: Re: [PATCH 8/8] ARM: OMAP2: Use custom soc attribute group instead of device_create_file Message-ID: <20200529180123.GV37466@atomide.com> References: <20200523170859.50003-1-sudeep.holla@arm.com> <20200523170859.50003-9-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200523170859.50003-9-sudeep.holla@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Sudeep Holla [200523 17:10]: > Commit c31e73121f4c ("base: soc: Handle custom soc information sysfs > entries") introduced custom soc attribute group in soc_device_attribute > structure but there are no users treewide. While trying to understand > the motivation and tried to use it, it was found lot of existing custom > attributes can moved to use it instead of device_create_file. > > Though most of these never remove/cleanup the custom attribute as they > never call soc_device_unregister, using these custom attribute group > eliminate the need for any cleanup as the driver infrastructure will > take care of that. > > Let us remove device_create_file and start using the custom attribute > group in soc_device_attribute. Acked-by: Tony Lindgren From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDEA2C433E0 for ; Fri, 29 May 2020 18:01:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A4FFD2073B for ; Fri, 29 May 2020 18:01:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VL72tXCd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4FFD2073B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V8/ZIwqfN0/qmw78FV7D3DIXQ5mguty7pajMArWAL6k=; b=VL72tXCd7uKdZd GLAkbhrKWfYLqaosMeSSzcH+GokOKr0ERNoXM/OwwqW4gMSzCm3hpPsyw+UHzZGWwJh9C6Phwob2r G7zdX1Pi/FHf6c9wggK5KfzLTjUUUk3iMH2bB/4PayQbL+GunR/2sIZGk6gleWjngFfPXAWIbaB0V K0/NWnwjZ0bqA0HqSY35rGgEkM+EFbIJ+GLAyMhRJris119u+OuvUzwLt2ZiADn5DTeBdcm1SbG10 n3PgMcZwpNUK3mu4Ejhwkwrhom41TkGb06sdE1q+laqhky+Vd9cEGqDb1263RXZfaGXUYEfSfvtgz zJcTdQOw9K0lZJdhutOA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jejJx-0006eY-GL; Fri, 29 May 2020 18:01:29 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jejJu-0006dX-98 for linux-arm-kernel@lists.infradead.org; Fri, 29 May 2020 18:01:27 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 8826F8030; Fri, 29 May 2020 18:02:16 +0000 (UTC) Date: Fri, 29 May 2020 11:01:23 -0700 From: Tony Lindgren To: Sudeep Holla Subject: Re: [PATCH 8/8] ARM: OMAP2: Use custom soc attribute group instead of device_create_file Message-ID: <20200529180123.GV37466@atomide.com> References: <20200523170859.50003-1-sudeep.holla@arm.com> <20200523170859.50003-9-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200523170859.50003-9-sudeep.holla@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200529_110126_357373_34260AA8 X-CRM114-Status: UNSURE ( 9.10 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , linux-omap@vger.kernel.org, Arnd Bergmann , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Sudeep Holla [200523 17:10]: > Commit c31e73121f4c ("base: soc: Handle custom soc information sysfs > entries") introduced custom soc attribute group in soc_device_attribute > structure but there are no users treewide. While trying to understand > the motivation and tried to use it, it was found lot of existing custom > attributes can moved to use it instead of device_create_file. > > Though most of these never remove/cleanup the custom attribute as they > never call soc_device_unregister, using these custom attribute group > eliminate the need for any cleanup as the driver infrastructure will > take care of that. > > Let us remove device_create_file and start using the custom attribute > group in soc_device_attribute. Acked-by: Tony Lindgren _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel