linux-next: Fixes tag needs some work in the spi-nor tree

linux-next: Fixes tag needs some work in the spi-nor tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

Hi all,

In commit

  5587fa489747 ("mtd: spi-nor: spansion: fix writes on S25FS512S")

Fixes tag

  Fixes: dfd2b74530e ("mtd: spi-nor: add Spansion S25FS512S ID")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the spi-nor tree

[Tudor.Ambarus]

On Friday, May 29, 2020 12:06:47 AM EEST Stephen Rothwell wrote:
> Hi all,

Hi, Stephen,

> 
> In commit
> 
>   5587fa489747 ("mtd: spi-nor: spansion: fix writes on S25FS512S")
> 
> Fixes tag
> 
>   Fixes: dfd2b74530e ("mtd: spi-nor: add Spansion S25FS512S ID")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").

Right. Maybe it is worth to add this kind of check in checkpatch.pl. One can 
generate the Fixes tag by adding an alias in .gitconfig:

[alias]
        fixes = show --format='Fixes: %h (\"%s\")' -s

And generate the Fixes tag with "git fixes sha1"

Cheers,
ta

Re: linux-next: Fixes tag needs some work in the spi-nor tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 555 bytes --]

Hi,

On Fri, 29 May 2020 07:31:47 +0000 <Tudor.Ambarus@microchip.com> wrote:
>
> Right. Maybe it is worth to add this kind of check in checkpatch.pl. One can 
> generate the Fixes tag by adding an alias in .gitconfig:
> 
> [alias]
>         fixes = show --format='Fixes: %h (\"%s\")' -s

I usually suggest

	git log -1 --format='Fixes: %h ("%s")' <SHA>

but pretty much the same.  The trick is to make sure you have a new
enough version of git and make sure that core.abbrev is not set (or set
to "auto").
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the spi-nor tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

Hi all,

In commit

  1f241ad2a093 ("mtd: spi-nor: fix kernel-doc for spi_nor::spimem")

Fixes tag

  Fixes: b35b9a10362 ("mtd: spi-nor: Move m25p80 code in spi-nor.c")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]