From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jeyXS-0005eK-T4 for mharc-grub-devel@gnu.org; Sat, 30 May 2020 06:16:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56006) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeyXQ-0005e1-Rv for grub-devel@gnu.org; Sat, 30 May 2020 06:16:24 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:40797) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeyXP-0007Zb-5Z for grub-devel@gnu.org; Sat, 30 May 2020 06:16:24 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id B63025C006B; Sat, 30 May 2020 06:16:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sat, 30 May 2020 06:16:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=5ngn76dPPO+G3emCFbYJRHl4oce +U5Y1WWpZ2b/jSuM=; b=Z2LL6MTuaeYVnRrA29C4HLZtJ1MPExtXtKGAG137Vm4 Fjyrff7hviY/4C2XSr1IwZDiL1VfSdhvykiSRC6d0NGz9P7nz830LVNbOw+RBNvT AQ5BbbFxhGFyIP7CXwJ9BgEPMYQafuQNR5t6I5AYJxFb9dOUJgna4kSmkWOPjd+J WWHye6s/sXZ0eus20cbd18xSU7dRynjx9Z0Wr6o0xyFsBI6vyNm9wHlVMvdQh2q/ nuPY3KXIVtkR7SME1utgb1u0vwiDTTW5jkTS6HVQ22kC37PXg7srzhH47JRnH2jO 3W3UF9uDfG4F3jxNAX0w8w7dAJT4qZZaM3HElR63coQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=5ngn76 dPPO+G3emCFbYJRHl4oce+U5Y1WWpZ2b/jSuM=; b=WOKs051G6Y2DF5Ax+3aBYV 2KaG1R5L7z04nyokusZTgAfx+3faGTUGR2XS4aLGTPNnikW3DBkAzbIcAp/RLUCS oVoTurwczDwrEej+CRSvU6oo48Cg3U8+nIk4xOMAq5aJu6X1iRK5YKlwyt1gRhva 77Ekvfgt0d2Ps/ZUEzxGgC6zYbv4/AHzLagx12qcT0bMa9FsEoZ09e/E4dipNNZL vEFhnB5a0KYXn1pDZqRh9CkNsYrDPgSEzaawfQkjrJwOyT9FR0AvXBMJqr3wfPCX UQsCLhZmkH96iThw45KYW+dzzidYVJX5jmxNzPqnb8J8EctpMjwjWcxdZ+b9dvdg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudeftddgvdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefrrghtrhhi tghkucfuthgvihhnhhgrrhguthcuoehpshesphhkshdrihhmqeenucggtffrrghtthgvrh hnpeehgefhtdefueffheekgfffudelffejtdfhvdejkedthfehvdelgfetgfdvtedthfen ucfkphepjeejrdduledurdeghedrudegkeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehpshesphhkshdrihhm X-ME-Proxy: Received: from vm-mail.pks.im (x4dbf2d94.dyn.telefonica.de [77.191.45.148]) by mail.messagingengine.com (Postfix) with ESMTPA id EC10E30618B7; Sat, 30 May 2020 06:16:19 -0400 (EDT) Received: from localhost (ncase [10.192.0.11]) by vm-mail.pks.im (OpenSMTPD) with ESMTPSA id 7f8a1b60 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 30 May 2020 10:16:15 +0000 (UTC) Date: Sat, 30 May 2020 12:16:41 +0200 From: Patrick Steinhardt To: The development of GNU GRUB Cc: Daniel Kiper Subject: Re: [PATCH v2 0/2] Improve LUKS2 error reporting Message-ID: <20200530101641.GA27438@ncase.pks.im> References: <20200417135404.ipeldmdctdsoyany@tomti.i.net-space.pl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="UlVJffcvxoiEqYs2" Content-Disposition: inline In-Reply-To: <20200417135404.ipeldmdctdsoyany@tomti.i.net-space.pl> Received-SPF: pass client-ip=66.111.4.29; envelope-from=ps@pks.im; helo=out5-smtp.messagingengine.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/30 06:16:20 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 May 2020 10:16:25 -0000 --UlVJffcvxoiEqYs2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 17, 2020 at 03:54:04PM +0200, Daniel Kiper wrote: > On Thu, Apr 16, 2020 at 07:15:06PM +0200, Patrick Steinhardt wrote: > > Hi, > > > > this is the second version of my patch that has the aim of improving > > error reporting for LUKS2 in case decryption of the disk fails. There's > > no functional changes, but I've split up the single patch into two as > > proposed by Daniel. > > > > @Daniel: Note that I've added your Reviewed-by to the second patch, but > > not to the first one as it's message is completely new. >=20 > LGTM, Reviewed-by: Daniel Kiper for both... >=20 > Thanks, >=20 > Daniel I see you pulled in commit c543d6781 (luks2: Propagate error when reading area key fails, 2020-04-16), but didn't pull in the second patch to improve error reporting when recovering keys fails. Was this by accident or intentionally? Patrick --UlVJffcvxoiEqYs2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF9hrgiFbCdvenl/rVbJhu7ckPpQFAl7SMogACgkQVbJhu7ck PpTT3xAAopVyACO1/TYefFtWguTtUaF2P9C0CV+zWYZA+Jpn4aovzn+HdLq2JrGM qUnTu1QxFesmqBl+ezM+66YS4ll49Zv99/CKggDp63lp+bCZ9AS1TG4fTadjzqYP jbTn9gr4FKPAhgqiYShZV7FOxzappM03b2TOQU06Q50lMxxcb5HOhxBjESeitkiS tNNz5eYzLAEiY0UUp8c/Xx33OKHX1i1XR3DT9QWxhh850T/8+1BcktIuuVYBSO1R DHqIskmnP+kcwI4OhKgxxvmSzsF56zVfGznM+WwITdcjaY2qv2yhyHPPzNa19IoY n5FCwWiyfBf9V+VDv+uMVM5t/c3QswkePEavzYq8ngS2yyaV+5F59cZ1htxFHAOi F6QBpXxrMqDsCymzywthH+3kClpVaXCoGNC7Y5I7eP6Y/TAHIGsqLjzXlDwzjlQK 3/4R2yohePqvxrjqrjJ402fQqgyL4v/W4r9vNh5OkT09aCO0hhiLpWsCXYgv4i1T WBw4LpnBxw2CBkqBueWq/JVrSY0YqAHfDjR2c3sHyqbIBr30dUbx/A+M2NBzna8J QZcCdtDOYq7ZN1aG1MiOXt8ZlMKeA7LfS3CUbgvwLLsp+2CqJDs7p6DwatxWOgjC FVpyfLXcYi+BYVqm38sEWhYhYeFv6oYjZXIBcVba6rYc8ULmo5w= =0lGG -----END PGP SIGNATURE----- --UlVJffcvxoiEqYs2--