All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Rishabh Bhatnagar <rishabhb@codeaurora.org>,
	linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, bjorn.andersson@linaro.org,
	tsoni@codeaurora.org, psodagud@codeaurora.org,
	sidgup@codeaurora.org,
	Rishabh Bhatnagar <rishabhb@codeaurora.org>
Subject: Re: [PATCH v4 1/2] remoteproc: qcom: Add per subsystem SSR notification
Date: Sat, 30 May 2020 18:30:00 +0800	[thread overview]
Message-ID: <202005301840.8Kkbmw7k%lkp@intel.com> (raw)
In-Reply-To: <1590636883-30866-2-git-send-email-rishabhb@codeaurora.org>

[-- Attachment #1: Type: text/plain, Size: 2382 bytes --]

Hi Rishabh,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on next-20200526]
[also build test WARNING on v5.7-rc7]
[cannot apply to linus/master linux/master v5.7-rc7 v5.7-rc6 v5.7-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Rishabh-Bhatnagar/Extend-SSR-notifications-framework/20200528-115948
base:    b0523c7b1c9d0edcd6c0fe6d2cb558a9ad5c60a8
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/remoteproc/qcom_common.c:200:28: warning: no previous prototype for 'qcom_ssr_get_subsys' [-Wmissing-prototypes]
200 | struct qcom_ssr_subsystem *qcom_ssr_get_subsys(const char *name)
|                            ^~~~~~~~~~~~~~~~~~~

vim +/qcom_ssr_get_subsys +200 drivers/remoteproc/qcom_common.c

   199	
 > 200	struct qcom_ssr_subsystem *qcom_ssr_get_subsys(const char *name)
   201	{
   202		struct qcom_ssr_subsystem *info;
   203	
   204		/* Match in the global qcom_ssr_subsystem_list with name */
   205		list_for_each_entry(info, &qcom_ssr_subsystem_list, list) {
   206			if (!strcmp(info->name, name))
   207				return info;
   208		}
   209		info = kzalloc(sizeof(*info), GFP_KERNEL);
   210		if (!info)
   211			return ERR_PTR(-ENOMEM);
   212		info->name = kstrdup_const(name, GFP_KERNEL);
   213		srcu_init_notifier_head(&info->notifier_list);
   214	
   215		/* Add to global notif list */
   216		INIT_LIST_HEAD(&info->list);
   217		list_add_tail(&info->list, &qcom_ssr_subsystem_list);
   218	
   219		return info;
   220	}
   221	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 72782 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v4 1/2] remoteproc: qcom: Add per subsystem SSR notification
Date: Sat, 30 May 2020 18:30:00 +0800	[thread overview]
Message-ID: <202005301840.8Kkbmw7k%lkp@intel.com> (raw)
In-Reply-To: <1590636883-30866-2-git-send-email-rishabhb@codeaurora.org>

[-- Attachment #1: Type: text/plain, Size: 2443 bytes --]

Hi Rishabh,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on next-20200526]
[also build test WARNING on v5.7-rc7]
[cannot apply to linus/master linux/master v5.7-rc7 v5.7-rc6 v5.7-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Rishabh-Bhatnagar/Extend-SSR-notifications-framework/20200528-115948
base:    b0523c7b1c9d0edcd6c0fe6d2cb558a9ad5c60a8
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/remoteproc/qcom_common.c:200:28: warning: no previous prototype for 'qcom_ssr_get_subsys' [-Wmissing-prototypes]
200 | struct qcom_ssr_subsystem *qcom_ssr_get_subsys(const char *name)
|                            ^~~~~~~~~~~~~~~~~~~

vim +/qcom_ssr_get_subsys +200 drivers/remoteproc/qcom_common.c

   199	
 > 200	struct qcom_ssr_subsystem *qcom_ssr_get_subsys(const char *name)
   201	{
   202		struct qcom_ssr_subsystem *info;
   203	
   204		/* Match in the global qcom_ssr_subsystem_list with name */
   205		list_for_each_entry(info, &qcom_ssr_subsystem_list, list) {
   206			if (!strcmp(info->name, name))
   207				return info;
   208		}
   209		info = kzalloc(sizeof(*info), GFP_KERNEL);
   210		if (!info)
   211			return ERR_PTR(-ENOMEM);
   212		info->name = kstrdup_const(name, GFP_KERNEL);
   213		srcu_init_notifier_head(&info->notifier_list);
   214	
   215		/* Add to global notif list */
   216		INIT_LIST_HEAD(&info->list);
   217		list_add_tail(&info->list, &qcom_ssr_subsystem_list);
   218	
   219		return info;
   220	}
   221	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 72782 bytes --]

  reply	other threads:[~2020-05-30 10:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-28  3:34 [PATCH v4 0/2] Extend SSR notifications framework Rishabh Bhatnagar
2020-05-28  3:34 ` [PATCH v4 1/2] remoteproc: qcom: Add per subsystem SSR notification Rishabh Bhatnagar
2020-05-30 10:30   ` kbuild test robot [this message]
2020-05-30 10:30     ` kbuild test robot
2020-06-18 23:00   ` Alex Elder
2020-06-18 23:35     ` Bjorn Andersson
2020-06-20 19:48       ` rishabhb
2020-06-22 18:51         ` Bjorn Andersson
2020-05-28  3:34 ` [PATCH v4 2/2] remoteproc: qcom: Add notification types to SSR Rishabh Bhatnagar
2020-06-18 23:00   ` Alex Elder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202005301840.8Kkbmw7k%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=psodagud@codeaurora.org \
    --cc=rishabhb@codeaurora.org \
    --cc=sidgup@codeaurora.org \
    --cc=tsoni@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.