Re: [PATCH Kernel v24 5/8] vfio iommu: Implementation of ioctl for dirty pages tracking

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3404 bytes --]

Hi Kirti,

I love your patch! Perhaps something to improve:

[auto build test WARNING on v5.7-rc7]
[also build test WARNING on next-20200529]
[cannot apply to vfio/next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Kirti-Wankhede/Add-UAPIs-to-support-migration-for-VFIO-devices/20200531-020103
base:    9cb1fd0efd195590b828b9b865421ad345a4a145
config: i386-randconfig-s031-20200531 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-243-gc100a7ab-dirty
        # save the attached .config to linux build tree
        make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

   drivers/vfio/vfio_iommu_type1.c:952:37: sparse: sparse: cast removes address space '<asn:1>' of expression
>> drivers/vfio/vfio_iommu_type1.c:952:37: sparse: sparse: incorrect type in argument 2 (different address spaces) @@     expected void const [noderef] <asn:1> *from @@     got void const * @@
   drivers/vfio/vfio_iommu_type1.c:952:37: sparse:     expected void const [noderef] <asn:1> *from
>> drivers/vfio/vfio_iommu_type1.c:952:37: sparse:     got void const *
   drivers/vfio/vfio_iommu_type1.c:959:27: sparse: sparse: cast removes address space '<asn:1>' of expression
>> drivers/vfio/vfio_iommu_type1.c:959:27: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void [noderef] <asn:1> *to @@     got void * @@
   drivers/vfio/vfio_iommu_type1.c:959:27: sparse:     expected void [noderef] <asn:1> *to
>> drivers/vfio/vfio_iommu_type1.c:959:27: sparse:     got void *

vim +952 drivers/vfio/vfio_iommu_type1.c

   932	
   933	static int update_user_bitmap(u64 __user *bitmap, struct vfio_dma *dma,
   934				      dma_addr_t base_iova, size_t pgsize)
   935	{
   936		unsigned long pgshift = __ffs(pgsize);
   937		unsigned long nbits = dma->size >> pgshift;
   938		unsigned long bit_offset = (dma->iova - base_iova) >> pgshift;
   939		unsigned long copy_offset = bit_offset / BITS_PER_LONG;
   940		unsigned long shift = bit_offset % BITS_PER_LONG;
   941		unsigned long leftover;
   942	
   943		/* mark all pages dirty if all pages are pinned and mapped. */
   944		if (dma->iommu_mapped)
   945			bitmap_set(dma->bitmap, 0, nbits);
   946	
   947		if (shift) {
   948			bitmap_shift_left(dma->bitmap, dma->bitmap, shift,
   949					  nbits + shift);
   950	
   951			if (copy_from_user(&leftover,
 > 952					   (const void *)(bitmap + copy_offset),
   953					   sizeof(leftover)))
   954				return -EFAULT;
   955	
   956			bitmap_or(dma->bitmap, dma->bitmap, &leftover, shift);
   957		}
   958	
 > 959		if (copy_to_user((void *)(bitmap + copy_offset), dma->bitmap,
   960				 DIRTY_BITMAP_BYTES(nbits + shift)))
   961			return -EFAULT;
   962	
   963		return 0;
   964	}
   965	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 42831 bytes --]